Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <caa69e8e-f330-d819-e8cd-7b06aa8eb855@amd.com>
Date:   Wed, 21 Jun 2023 09:42:25 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [RFC PATCH v3 0/4] drm: Standardize device reset notification
Content-Language: en-US
To:     =?UTF-8?Q?Andr=c3=a9_Almeida?= <andrealmeid@igalia.com>,
        dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Cc:     kernel-dev@igalia.com, alexander.deucher@amd.com,
        pierre-eric.pelloux-prayer@amd.com,
        Simon Ser <contact@emersion.fr>,
        Rob Clark <robdclark@gmail.com>,
        Pekka Paalanen <ppaalanen@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Daniel Stone <daniel@fooishbar.org>,
        =?UTF-8?B?J01hcmVrIE9sxaHDoWsn?= <maraeo@gmail.com>,
        Dave Airlie <airlied@gmail.com>,
        =?UTF-8?Q?Michel_D=c3=a4nzer?= <michel.daenzer@mailbox.org>,
        Samuel Pitoiset <samuel.pitoiset@gmail.com>,
        =?UTF-8?Q?Timur_Krist=c3=b3f?= <timur.kristof@gmail.com>,
        Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
References: <20230621005719.836857-1-andrealmeid@igalia.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20230621005719.836857-1-andrealmeid@igalia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHZKZG9kUkI1d1g3OEJHblVPMW9KSnMrSFhKdisycjI3dU9aVHcrcCtWUU9G?=
 =?utf-8?B?aEIybklML2FXSG85REhPdTJnbFZnSmFmdktkb29EcHQvQVgwdTVHVUxKdllN?=
 =?utf-8?B?QW44a2hzMXQ0aG9ORkYwSGFFTDFraU96NCsxelkyekVyTytCTGtvMzBVUSt6?=
 =?utf-8?B?SE9jcDZwTk5QT1NtcWprU085U1RkU3FrZEpQOE12U0pTQ2Jiek9EdFd1eWRV?=
 =?utf-8?B?bnduR2FadGhVd2pobUgyd1hpUzJOM0VsOU9rU0t2TWt3clBEeHBmM2p3SVNF?=
 =?utf-8?B?YUZoUnM1YVZsNUorejdUTlpXRHF4VnkxdS9reStPZXNyMXdEcGxDVlNzY0ND?=
 =?utf-8?B?eGpHL1dHdkZ4OGNSVktVNEhkRTNRWVVBZFN5QjVpMEtjNlkyN2plQjBvOFVW?=
 =?utf-8?B?MTRMNTNicW9lVGNqUHhKSGdOd0Y0VmNTaEw3dzdseUFIdzlmbHNBUXJ0Q3JX?=
 =?utf-8?B?VjBBbjJ6NkhYeEs2bEtURkxJYlowbVFoaCthUU51aUg2NS8xL0J3OWN1bDVN?=
 =?utf-8?B?WmhEQisrVHZiU2FtOE8yalVCS2k4Wnl1TUw2a2ZZeitwWkJZT1NWL2E4bmZz?=
 =?utf-8?B?dkYwYWc4WkpqRC9uUU14M1Fac3hCcVd2U2ZTVVh4amhCN08rNDcxTUROdHY1?=
 =?utf-8?B?cG1uSGN5WTQra1FMVkpzV3pEM1duOXJ0V1pXZ1BoUnVHY3N3WDI1YnhoY1ZQ?=
 =?utf-8?B?Wm9UdHlhQmNtS1ZUSVVQTkVsSEZSYWN1dEtTdms0YllKT0s0Z05Mc1lkY3Iy?=
 =?utf-8?B?R1JVd2RRcURaOFFRWnVpQzBIYXBzYkFkVWJBa2h1Mi9kOEpoRjBnQmtLb3pp?=
 =?utf-8?B?RUFGbXUzb2J0SldhSFk4bVdReXdjeEJqbnp1NzlsNlBwaG5ZbS85WEVCT05q?=
 =?utf-8?B?cDlmQThrdkZnV1dJV3JvdUpFNEdqQ1FWSUxsb0RYYUsvRGxlcHZvOEhpanNC?=
 =?utf-8?B?KzRLd3dIYS9kdXdoSFpHWjJZUXYrU1VXY0pIa0I2WWFqTUpuL3gwdWVCZDEx?=
 =?utf-8?B?UXVKUm5FMlhyMEszNkpQSS9ndUEwNDNrOXkzakEycHV6WVNwV01oM0E1QTls?=
 =?utf-8?B?RiszTVFDejVhT0xLc1FsYnJKRVJIWDdOeGpQaTkwbk5UblZUTkVJb1I0NFM3?=
 =?utf-8?B?QVVWSWxSUWFHRHdzMjl1c01pR0FzZlA2Uno1YjRoYlN5V2xRUjlkcmFVaFpa?=
 =?utf-8?B?cWRrL3RSNGM4elNBbVI0L1Y3c0p1R2F6SDAxMmhsa2Uxa1FIV0ptZlIySGsr?=
 =?utf-8?B?d2xlUnRSbDB1N25TNmFZZkVQNW5MSjFJZUtMNVhCOW4vYWhkRHVuOTlISUdh?=
 =?utf-8?B?M2ZTb2x5aUE2WWhKSllUclQxRHhGcWVzRW4rcWVPK3pyai96TndIdlBVd1I4?=
 =?utf-8?B?anBNc0locG9UUU5XcnZoNXRSUnRXQ3BUcGhzWko4RXBVSVhaRVV3NitvaC9W?=
 =?utf-8?B?ajY1NDlRZDBNK205YzZsU0RLU2tvTUR4bktpZklQVTdJVjhBZVdXRGE1R0Rt?=
 =?utf-8?B?cEFpekt2ZG9OcEN6eTFtQmtmMTJwUjVMSXZiZzRTWmRJNjQ2ckh1bldkKzF1?=
 =?utf-8?B?dVZ6eFgxWWUyWXF2UE1SRDg2QnRjbnhFSHlNREtvaU5XV2Z2TTJqKzFRajI4?=
 =?utf-8?B?YW5xeWJIL0Z3L0hOSzNmMTc0MXJ3RXVpUzJSZWR2T1dMYy9HcmxvbGdpeG5F?=
 =?utf-8?B?Y0NMckFsS3ZLVXoyaitOa3o4bC9mcFlDTTVjcTAzOHBIRllJMG1vZ1ZKbXJN?=
 =?utf-8?B?Ui8xQVN3dmhrTGVPT0pKcG53K3lHVDE3NkpESTFqOTB1aW9hNWd0MUtuemc4?=
 =?utf-8?B?TWdNN3ZNUzNQQ2sxalB3V2lJc2NPV2J5akZwMHhQREJRakJuTDNEUG1xS1ZH?=
 =?utf-8?B?NnNjR21seUw2NEcvc1FJMzVhVW5xODVKeThOQ1drNGpkeWltRHplQWFhK1hu?=
 =?utf-8?B?SlFSWWdqZ09DdlQxR1ovV0JoRVFyNkpEMDVQczhSSE1VZUJvaG1zU3R5REZi?=
 =?utf-8?B?UVdmSFMvTVlHRnBXV0dsa3ZSLzF6UlNGbjVmMUxjcURwRklEa3lha0F1OVJ2?=
 =?utf-8?B?ZGZvMVo0STRzY3RYamU5OWdMOUVPNGRSeTNDNW5Bc0N2ZUQzZTh1WUhGTlJK?=
 =?utf-8?B?elY3S3BDdTN2OVd5WVNUanBRY2NIVmtyM2VGRHRxUTNPelgrUC9KbHU4S2Vy?=
 =?utf-8?Q?gTgLILLIeIkDM8C5bJq5+l9DVYRF55eBQSOkLzQ2/BdA?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 18e614de-78e1-4ca9-b505-08db722b11cb
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2023 07:42:31.3193
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RUTscHyUk76inKypOQ5cbvYX0Zg5I9dh5d1uQCqfSttSzWJbUq2jS5oSIZ+280HQ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7931
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 21.06.23 um 02:57 schrieb André Almeida:
> Hi,
>
> This is a new version of the documentation for DRM device resets. As I dived
> more in the subject, I started to believe that part of the problem was the lack
> of a DRM API to get reset information from the driver. With an API, we can
> better standardize reset queries, increase common code from both DRM and Mesa,
> and make easier to write end-to-end tests.
>
> So this patchset, along with the documentation, comes with a new IOCTL and two
> implementations of it for amdgpu and i915 (although just the former was really
> tested). This IOCTL uses the "context id" to query reset information, but this
> might be not generic enough to be included in a DRM API.

Well the basic problem with that is that we don't have a standard DRM 
context defined.

If you want to do this you should probably start there first.

Apart from that this looks like a really really good idea to me, 
especially that we document the reset expectations.

Regards,
Christian.

>    At least for amdgpu,
> this information is encapsulated by libdrm so one can't just call the ioctl
> directly from the UMD as I was planning to, but a small refactor can be done to
> expose the id. Anyway, I'm sharing it as it is to gather feedback if this seems
> to work.
>
> The amdgpu and i915 implementations are provided as a mean of testing and as
> exemplification, and not as reference code yet, as the goal is more about the
> interface itself then the driver parts.
>
> For the documentation itself, after spending some time reading the reset path in
> the kernel in Mesa, I decide to rewrite it to better reflect how it works, from
> bottom to top.
>
> You can check the userspace side of the IOCLT here:
>   Mesa: https://gitlab.freedesktop.org/andrealmeid/mesa/-/commit/cd687b22fb32c21b23596c607003e2a495f465
>   libdrm: https://gitlab.freedesktop.org/andrealmeid/libdrm/-/commit/b31e5404893ee9a85d1aa67e81c2f58c1dac3c46
>
> For testing, I use this vulkan app that has an infinity loop in the shader:
> https://github.com/andrealmeid/vulkan-triangle-v1
>
> Feedbacks are welcomed!
>
> Thanks,
> 		André
>
> v2: https://lore.kernel.org/all/20230227204000.56787-1-andrealmeid@igalia.com/
> v1: https://lore.kernel.org/all/20230123202646.356592-1-andrealmeid@igalia.com/
>
> André Almeida (4):
>    drm/doc: Document DRM device reset expectations
>    drm: Create DRM_IOCTL_GET_RESET
>    drm/amdgpu: Implement DRM_IOCTL_GET_RESET
>    drm/i915: Implement DRM_IOCTL_GET_RESET
>
>   Documentation/gpu/drm-uapi.rst                | 51 ++++++++++++++++
>   drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c        |  4 +-
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c       | 35 +++++++++++
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.h       |  5 ++
>   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c       |  1 +
>   drivers/gpu/drm/amd/amdgpu/amdgpu_job.c       | 12 +++-
>   drivers/gpu/drm/amd/amdgpu/amdgpu_job.h       |  2 +
>   drivers/gpu/drm/drm_debugfs.c                 |  2 +
>   drivers/gpu/drm/drm_ioctl.c                   | 58 +++++++++++++++++++
>   drivers/gpu/drm/i915/gem/i915_gem_context.c   | 18 ++++++
>   drivers/gpu/drm/i915/gem/i915_gem_context.h   |  2 +
>   .../gpu/drm/i915/gem/i915_gem_context_types.h |  2 +
>   drivers/gpu/drm/i915/i915_driver.c            |  2 +
>   include/drm/drm_device.h                      |  3 +
>   include/drm/drm_drv.h                         |  3 +
>   include/uapi/drm/drm.h                        | 21 +++++++
>   include/uapi/drm/drm_mode.h                   | 15 +++++
>   17 files changed, 233 insertions(+), 3 deletions(-)
>