Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp9005128rwd; Wed, 21 Jun 2023 01:31:21 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ58zcuNWPcKsaWLX+wcdRbGgN3jeu2s5MQcUYEjteTRJdA8NxK56LmJl7Hwos+54KgGWCkT X-Received: by 2002:a05:6870:956e:b0:19f:4350:b18c with SMTP id v46-20020a056870956e00b0019f4350b18cmr13937129oal.48.1687336281595; Wed, 21 Jun 2023 01:31:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687336281; cv=none; d=google.com; s=arc-20160816; b=FMDGe/2Ng73J2IcNVoUBpaXHbdLgIdTYwZ3gBKwX+cfbK7rU2NIngLF8nhQE7tygqn QGoMi8TRzJaP3cjA38NXahdEoA4EvPAbsvGi+3z5e6pcn2SNGxK9AMXZj1MJAsKi6je2 hu62Z6ZfTG+1ZnO6f3EFmuXmZmhu2DPJaBjhklaj3Xrm+sY1aVADLrAYRjAuAoWlaIlk myQ/Kdo+Noc0bFEsk/yLgg0b3TqjK/u0MNZHfnYlp72oToDOXJ3zZpNGNpguRGVEdkfo HoSc47rxJFc8uc3DDrQoJxoOEJjzE1W/sPpNEdCFXNmROXtyG5gog8YNYXvdC56vhHT6 bB7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=lTSU3An8gM6reX7gIYHv5XUzCbetDmgqSY0M6vDhJ+M=; b=dENAI0A5DCMx+FxutFcNYX2hXZVPy0RW5CfBblR7Ew+JdN8czReRFUb1vM89Sita08 BtGRg549emMnPXSp9MA4tZL3dSN8EMgWYKYwlj0zVauBKH1j93ETlr9OPvhqLxGoz1YT xuyAaGFzbM78eQhXljKeWEdg/k4qRa51X4u/HM+z1yl18m1J5iH65/dhPxPtB+ebZjHW /cKiDFTBVxEjQoqbKsqrZgPxMdlHpCot3bDxAUz+2+7aZwageFdSarUjNAbbxzXYFexU gelvrOlIsOXz/Gf7EQ3JB92+9Ebk/nIcNPWA6cFHcb7hco7orNZlrsDbI/7WLaOIFHD3 k2lQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=uhiGbTsu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x8-20020aa79ac8000000b0066866fbb7e7si93405pfp.31.2023.06.21.01.31.07; Wed, 21 Jun 2023 01:31:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=uhiGbTsu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231551AbjFUHjG (ORCPT + 99 others); Wed, 21 Jun 2023 03:39:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231492AbjFUHiq (ORCPT ); Wed, 21 Jun 2023 03:38:46 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD44F19BE; Wed, 21 Jun 2023 00:38:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lTSU3An8gM6reX7gIYHv5XUzCbetDmgqSY0M6vDhJ+M=; b=uhiGbTsu70yxmQ3RrqI7soy7kc gixwosjeuBeVAWWonw8yp58ecXYP1x4VufUnGvKSlRPg5fThgCqYhjtItGx3i13zMyf/yoRiHiPxu m0eMFvyUuLKoeu3zvOcZP2nxDxEwrd2qkFM31exDIpqmut3qT1VIvZ/gABjXntICVcLfqQN02ZZiM Ynu0eohRqKQomQCb/FwcFaFWhK3CYinJVB0O26eZ6bZ7a2v5DtBND+MLZers/5cbtmHJr7pAO7zaM ymZnW/VwvKHTRSAPvtjXCT1dUjeYzL6VXZyUb9HVqEzwH3cWvCImmWV1n1eC/IO5jlgP2HDVNKU+H Q8YYf0IA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qBsQG-00E6kq-1V; Wed, 21 Jun 2023 07:38:36 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 72C2B3002A9; Wed, 21 Jun 2023 09:38:35 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 56D222BC73BB9; Wed, 21 Jun 2023 09:38:35 +0200 (CEST) Date: Wed, 21 Jun 2023 09:38:35 +0200 From: Peter Zijlstra To: Waiman Long Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Josh Poimboeuf , Pawan Gupta , Jacob Pan , Len Brown , linux-kernel@vger.kernel.org, x86@kernel.org, linux-pm@vger.kernel.org, Robin Jarry , Joe Mario Subject: Re: [PATCH v2 3/5] intel_idle: Sync up the SPEC_CTRL MSR value to x86_spec_ctrl_current Message-ID: <20230621073835.GD2046280@hirez.programming.kicks-ass.net> References: <20230620140625.1001886-1-longman@redhat.com> <20230620140625.1001886-4-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230620140625.1001886-4-longman@redhat.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 20, 2023 at 10:06:23AM -0400, Waiman Long wrote: > When intel_idle_ibrs() is called, it modifies the SPEC_CTRL MSR to 0 > in order disable IBRS. However, the new MSR value isn't reflected in > x86_spec_ctrl_current. That will cause the new spec_ctrl_msrs debugfs > file to show incorrect result. Fix that by updating x86_spec_ctrl_current > percpu value to always match the content of the SPEC_CTRL MSR. What debugfs file?