Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Duan, Zhenzhong" <zhenzhong.duan@intel.com>
To:     Jason Gunthorpe <jgg@nvidia.com>,
        "Tian, Kevin" <kevin.tian@intel.com>
CC:     "Liu, Yi L" <yi.l.liu@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
        "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>
Subject: RE: [PATCH v2 00/11] iommufd: Add nesting infrastructure
Thread-Topic: [PATCH v2 00/11] iommufd: Add nesting infrastructure
Thread-Index: AQHZhBZTPfYFvaFemkeojX3Tn4M4A69haBIAgAAfs4CAB1VTgIAVHiGAgA71MYCABVzrgIAA28cAgAC5cgCAAUcGsA==
Date:   Wed, 21 Jun 2023 08:29:09 +0000
Message-ID: <SJ0PR11MB67441A87771D9140D1A1F2DC925DA@SJ0PR11MB6744.namprd11.prod.outlook.com>
References: <20230511143844.22693-1-yi.l.liu@intel.com>
 <BN9PR11MB5276DAF0A11809CF8433EE338C7C9@BN9PR11MB5276.namprd11.prod.outlook.com>
 <ZGdiS2m8jcd5OOt5@nvidia.com>
 <BN9PR11MB5276A74B2DA86C79908A420B8C419@BN9PR11MB5276.namprd11.prod.outlook.com>
 <ZH9AGWf1yRDu/86q@nvidia.com>
 <BN9PR11MB52763C7B838B04D3200322FD8C58A@BN9PR11MB5276.namprd11.prod.outlook.com>
 <ZJBL8QLLBiwRsUSI@nvidia.com>
 <BN9PR11MB527663567ECB8AD52D3170818C5CA@BN9PR11MB5276.namprd11.prod.outlook.com>
 <ZJGf3sgLKr9HLZuE@nvidia.com>
In-Reply-To: <ZJGf3sgLKr9HLZuE@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4BiYAlC/oxd1NE5inmZZ2h/irA9xoOXvoQAoajdmB0pdi4PfCMnjX9ikvKuT?=
 =?us-ascii?Q?zoUzRsvGnd7tLR1TyQ6jT0k1+as8Sg0fa1loD3utB4Da3PNjt53d0pr7ovHo?=
 =?us-ascii?Q?bPzZFw0CnzZDbcRig/yIlpTr0voF/YBD/Oy2gGEc5zhvRunPRXZHVdfhmLx2?=
 =?us-ascii?Q?irk8LxGDamYktojUIdpVR2AmohMAtDjSjr7RPv+giOiufpdq1rxArapUyRWV?=
 =?us-ascii?Q?NEC7oc0iKm0JzDnBj62HNZV8i+1c2Og1L5QKewbgXl/4hGDBTOFO558+ZgJH?=
 =?us-ascii?Q?SM0jZ7o4wI5jT/HRkCI3ME0NLcl0feX1SlxqBFybb3duKd7nP0XfkfUY1Nkk?=
 =?us-ascii?Q?wMBg2NYb3hOj/jIK3+qpQCvIfQwxum6QIREJOnasSCqe3mUgOZkld5rQwMFq?=
 =?us-ascii?Q?ElYRg9ZKPmdERm1pk4hq1WOpml4rpbNc8Xx6prJ4EeMaXMaKnHCHSoezwQQS?=
 =?us-ascii?Q?U+gLAEuNTWh9UOusyrAMb+xEbd1SVq+xHRzip/62tIHpKdmziT0/bzefulWm?=
 =?us-ascii?Q?DsO8euyg7sc8lOukSk0CxaNF1Ua1ZGNuU6+xI5ccYfnbnXHs6tqoWJl6a3Cw?=
 =?us-ascii?Q?b3SnXGTKsp0Rbj38Y2EWRBLrEThvifXgcZwSsctt5YfOOp+LfMaWP3uKkK6A?=
 =?us-ascii?Q?VQQwuDd8ITgdTGRAfMw2vZ0kJ2gX7sywd6Juf8MeBSQ1uMUQEA9CqQwmRE09?=
 =?us-ascii?Q?gFZbVkGE6e7VpgcWVj/mfcJfGwf4IPHK+8/3NgCYe19zIckxDBFaPNPD8BMd?=
 =?us-ascii?Q?yEMAtVgP+cPJfRQj7nqRP34boulBg2TB3L7AKDTVwNjA2h63tw7vYPRWgl78?=
 =?us-ascii?Q?H5ZGzhYef5976Lb/77XXCq8hvk0J2J3Snv4D/Tl/YLHRJyQp3h7zd0j88uS1?=
 =?us-ascii?Q?MRaadP5BwMajotBajaRd3wbgegetqVv3L/8EudD6DbzsIyid/LxxXoDGqlbp?=
 =?us-ascii?Q?jYRLYbqJMUwayvPLnHQFsXrpTFi8B1U8wLx38pcApxMDiju2xXbu3mgJyjvn?=
 =?us-ascii?Q?yUq9S4y8x97TCge8znbJZpZF4kYP5hgm4mOw1KXzbXSCfgGXAKgRGGHi3yM1?=
 =?us-ascii?Q?J/ZhIu/42cPwvpIOsGWXW1hMblotYbN6lF+lUqdoAheEAUMfKdDkPQ+01oAl?=
 =?us-ascii?Q?RrUfcGp+kTnmxmYq0JPadH22Y/poxCHjQgOB3GQEXOkxp4XjEeSm9CZdc9tL?=
 =?us-ascii?Q?6mm3zXciCbJvwAqPgrhsOO/G4eRIZ4etEqN1c5gRwYpw4ieuzeDHvo/+NgFA?=
 =?us-ascii?Q?bQnEJ+qDutOC6MHhTo1vc33Vg1SF0NshP4wE0ya5AVYa89032XRzvSbj8cFX?=
 =?us-ascii?Q?Ltn9m5OUV2eATrEWfmRUwno/3C4UrKUUdod3WGjnNaduKHQAcVmoxXF4m86O?=
 =?us-ascii?Q?Qu/zG7KIXA7Is0yKF4Bji8r3j5QE6Pq0O/cU4JhV2XxqNjxlavHSqj0p8j7n?=
 =?us-ascii?Q?TX2E/KI8H+t/GZug9r0GJGwv16wqCUjf90szqNZFoNESkD7wHH0gqGLjCDX9?=
 =?us-ascii?Q?KdsHWNyTlY61wR6S/tc5xzmhUvCEfLvS5fdaPKCOJxmmcyQ/tpRXKk7how0D?=
 =?us-ascii?Q?Q3UJG+92TH+DlTbWMZZsQFhhLGp15Yc2uHCj6Tcz?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB6744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ab1db489-9f87-4094-20d4-08db723195d7
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2023 08:29:09.5324
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fUujk1zuSk8uwPtFJMOBQPwpkMGPS/M4t/6acgQZlIs0kN9bjnZa54nSB0B8IaW12bfg2/SRVqp/zPAOwClE9k0c27eIfBurgQEfbkubkbw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5098
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>-----Original Message-----
>From: Jason Gunthorpe <jgg@nvidia.com>
>Sent: Tuesday, June 20, 2023 8:47 PM
>Subject: Re: [PATCH v2 00/11] iommufd: Add nesting infrastructure
>
>On Tue, Jun 20, 2023 at 01:43:42AM +0000, Tian, Kevin wrote:
>> I wonder whether we have argued passed each other.
>>
>> This series adds reserved regions to S2. I challenged the necessity as
>> S2 is not directly accessed by the device.
>>
>> Then you replied that doing so still made sense to support identity
>> S1.
>
>I think I said/ment if we attach the "s2" iommu domain as a direct attach =
for
>identity - eg at boot time, then the IOAS must gain the reserved regions. =
This is
>our normal protocol.
There is code to fail the attaching for device with RMRR in intel iommu dri=
ver,
do we plan to remove below check for IOMMUFD soon or later?

static int intel_iommu_attach_device(struct iommu_domain *domain,
                                     struct device *dev)
{
        struct device_domain_info *info =3D dev_iommu_priv_get(dev);
        int ret;

        if (domain->type =3D=3D IOMMU_DOMAIN_UNMANAGED &&
            device_is_rmrr_locked(dev)) {
                dev_warn(dev, "Device is ineligible for IOMMU domain attach=
 due to platform RMRR requirement.  Contact your platform vendor.\n");
                return -EPERM;
        }

Thanks
Zhenzhong