Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1766016AbXJRP7d (ORCPT ); Thu, 18 Oct 2007 11:59:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933681AbXJRP6o (ORCPT ); Thu, 18 Oct 2007 11:58:44 -0400 Received: from cerber.ds.pg.gda.pl ([153.19.208.18]:37929 "EHLO cerber.ds.pg.gda.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933610AbXJRP6l (ORCPT ); Thu, 18 Oct 2007 11:58:41 -0400 Date: Thu, 18 Oct 2007 16:58:34 +0100 (BST) From: "Maciej W. Rozycki" To: Oleg Nesterov cc: Jarek Poplawski , Andy Fleming , Andrew Morton , Jeff Garzik , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] flush_work_sync vs. flush_scheduled_work Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes In-Reply-To: <20071018154819.GA425@tv-sign.ru> Message-ID: References: <20071015125301.GC3015@ff.dom.local> <20071016062108.GB1000@ff.dom.local> <20071017085809.GA1658@ff.dom.local> <20071018063157.GA1694@ff.dom.local> <20071018070531.GA2065@ff.dom.local> <20071018154819.GA425@tv-sign.ru> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 620 Lines: 19 On Thu, 18 Oct 2007, Oleg Nesterov wrote: > If we can't just cancel the work, can't we do something like > > if (cancel_work_sync(w)) > w->func(w); > > instead? We do an equivalent of this -- all that we care about that w->func(w) would do is enable_irq() and the rest we want to skip at this point. We probably do not need the counter in the end though. Maciej - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/