Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <31cb09ae-dbb8-8ba0-08dc-fcc2af63ca30@quicinc.com>
Date:   Wed, 21 Jun 2023 14:48:23 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH V23 2/3] misc: dcc: Add driver support for Data Capture
 and Compare unit(DCC)
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Andy Gross <agross@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>, Alex Elder <elder@ieee.org>,
        Arnd Bergmann <arnd@arndb.de>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, Sibi Sankar <quic_sibis@quicinc.com>,
        "Rajendra Nayak" <quic_rjendra@quicinc.com>
References: <cover.1683265984.git.quic_schowdhu@quicinc.com>
 <2259ab0348282349e88905ea99bcb4aa815d941f.1683265984.git.quic_schowdhu@quicinc.com>
 <2023061542-reformed-unholy-10a3@gregkh>
 <cc9750f3-c85c-be7f-e63c-0fcf4eb160f0@quicinc.com>
 <2023061515-unbuckled-consonant-e207@gregkh>
 <5d9ab90f-4fc3-26c6-141e-e9388ac2f0cf@quicinc.com>
 <2023061548-subtly-cackle-8be2@gregkh>
Content-Language: en-US
From:   Souradeep Chowdhury <quic_schowdhu@quicinc.com>
In-Reply-To: <2023061548-subtly-cackle-8be2@gregkh>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/15/2023 7:36 PM, Greg Kroah-Hartman wrote:
> On Thu, Jun 15, 2023 at 07:17:34PM +0530, Souradeep Chowdhury wrote:
>>>>>> +static ssize_t ready_read(struct file *filp, char __user *userbuf,
>>>>>> +			  size_t count, loff_t *ppos)
>>>>>> +{
>>>>>> +	int ret = 0;
>>>>>> +	char *buf;
>>>>>> +	struct dcc_drvdata *drvdata = filp->private_data;
>>>>>> +
>>>>>> +	mutex_lock(&drvdata->mutex);
>>>>>> +
>>>>>> +	if (!is_dcc_enabled(drvdata)) {
>>>>>> +		ret = -EINVAL;
>>>>>> +		goto out_unlock;
>>>>>> +	}
>>>>>> +
>>>>>> +	if (!FIELD_GET(BIT(1), readl(drvdata->base + dcc_status(drvdata->mem_map_ver))))
>>>>>> +		buf = "Y\n";
>>>>>> +	else
>>>>>> +		buf = "N\n";
>>>>>> +out_unlock:
>>>>>> +	mutex_unlock(&drvdata->mutex);
>>>>>> +
>>>>>> +	if (ret < 0)
>>>>>> +		return -EINVAL;
>>>>>> +	else
>>>>>
>>>>> You do the "lock, get a value, unlock, do something with the value"
>>>>> thing a bunch, but what prevents the value from changing after the lock
>>>>> happens?  So why is the lock needed at all?
>>>>
>>>> The lock is used to prevent concurrent accesses of the drv_data when
>>>> scripts are being run from userspace.
>>>
>>> How would that matter?  The state can change instantly after the lock is
>>> given up, and then the returned value is now incorrect.  So no need for
>>> a lock at all as you really aren't "protecting" anything, or am I
>>> missing something else?
>>
>> This lock is needed to protect the access to the global instance of drv_data
>> structure instantiated at probe time within each individual callbacks of
>> debugfs.
> 
> What exactly are you "protecting" here that could change in a way that
> cause a problem?
> 
> You aren't returning a value that is ever guaranteed to be "correct"
> except that it happened sometime in the past, it might be right anymore.

Hi Greg,

The lock doesn't add any value in this particular case and I will be 
dropping it from here but in other cases it is being used to protect the 
concurrent access of the data-structures used inside the drv_data mainly 
the list which is being used to append register configurations, write 
the configuration to the dcc_sram and also delete it while doing a 
config reset. The lock is also used in case of software trigger to read 
the bitmap of the lists to set register values.

Thanks,
Souradeep

> 
> thanks,
> 
> greg k-h