Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp9206873rwd; Wed, 21 Jun 2023 04:38:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ63FeSmR7HDZmV1YaPqzRUzEgG2M9ZQ2xdebC0+U1DzxGQ8Nrt3j+qkgxaOPgvuOo8Nvni+ X-Received: by 2002:a05:6a20:12c7:b0:10f:f8e2:183c with SMTP id v7-20020a056a2012c700b0010ff8e2183cmr15404446pzg.51.1687347513911; Wed, 21 Jun 2023 04:38:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687347513; cv=none; d=google.com; s=arc-20160816; b=PR0Ma1yh6/YnVtl8t4Ggzp96W3jdQjBrJdX20kWd0pf/jVxEf0s70/FTccOsi8wpsO tsukMBJdFJzRjglv35SmOs/Bj8i5e6Qrx7fDR6Khqaol5vMP+upsxsgftpsWDbOL8DGL KMSncO0SuXAUXC/WjdVo37Ud/Irba9pg1grCe8qt8Zdzmps3afHDebAlOodkxfd6t1rv mRh7Z7peec1svZPFy0PDmdNrCY5tZpH8Jzw4gNPdJs41X5jctt8RIQ3xWFov6DDmMRN+ UJixbUr0+aWjWx9mwhErEKQ63Mo577jJ0ey+1McMU+7VIlnQ0RvoRs2KcaeXdlrGKJCD UXRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=HHkbLk/cLJhPHRHX27FHhhWp3DrX/nCJGGt+VLR1SzI=; b=bFTQAkRINEx3cnzio2Pj1tWoB+Q/YyR7Xkscf0lvPUvL8qERWIWO3KYZEGEKk01qgb ZJCM+iYf0IKM9lMZfvgRpIpg3XHC0MKLJFm6klnzRU2EQYmWjTkJRneXaL4f9ipVUdj3 3L+3qXDGXQibmDwTvY9KmYZ7WlQG3YK9q2CRRXjgwZdLa7bDWCavWhpZzLjOg6+kLE7r DiMxsuJ2mKGnbIXTq45lvFvECmXcY5owEEgGRQVknVBZloKmW9rot5JFGGNFOkw1ojiF boGQFpauR5dxWqPRudFSzRfsFUbQ72tpPUbp4IVxyUcEQVn7HECytjbUqqkSRzHLA6xo tOrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=gGyxtk4C; dkim=neutral (no key) header.i=@suse.de header.b=QYsModYH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w10-20020aa79a0a000000b0066a45e8ee49si806887pfj.103.2023.06.21.04.38.16; Wed, 21 Jun 2023 04:38:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=gGyxtk4C; dkim=neutral (no key) header.i=@suse.de header.b=QYsModYH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232656AbjFULUK (ORCPT + 99 others); Wed, 21 Jun 2023 07:20:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232735AbjFULTs (ORCPT ); Wed, 21 Jun 2023 07:19:48 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51BB9E69; Wed, 21 Jun 2023 04:19:33 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id EDBF31FDD5; Wed, 21 Jun 2023 11:19:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1687346371; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HHkbLk/cLJhPHRHX27FHhhWp3DrX/nCJGGt+VLR1SzI=; b=gGyxtk4CRVWFBztpC1rGErZc/Yx9a1BC/H90dzZ7W77getnyDY45MVlreaQOjjctagP6q+ u63OAFg3WhKhJdsBe0yueYNraFUBO74si03Y2gRIuobb2g+rXj3sg+745UIb/IGq3SlfDF eSRWB5UJqo1OlzXzTD/JquDJguSgW0g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1687346371; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HHkbLk/cLJhPHRHX27FHhhWp3DrX/nCJGGt+VLR1SzI=; b=QYsModYHdx6Ew+QFqgUL2c5xStel7OjLiIEsT8JEjjqZiMC2Vpv+HL6H+peDN8c2+QpLwN 4tLO/CKpYV5251AQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DCD4F134B1; Wed, 21 Jun 2023 11:19:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id QwPcNcPckmQeJwAAMHmgww (envelope-from ); Wed, 21 Jun 2023 11:19:31 +0000 Date: Wed, 21 Jun 2023 13:19:31 +0200 From: Daniel Wagner To: Sagi Grimberg Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Chaitanya Kulkarni , Shin'ichiro Kawasaki , Hannes Reinecke , James Smart , Martin Belanger Subject: Re: [PATCH blktests v1 1/3] nvme/048: Check for queue count check directly Message-ID: References: <20230620132703.20648-1-dwagner@suse.de> <20230620132703.20648-2-dwagner@suse.de> <380cde65-8794-cfbc-237f-30a8d7e9330c@grimberg.me> <083e29ff-4ad0-d05f-0521-56ace13629e6@grimberg.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <083e29ff-4ad0-d05f-0521-56ace13629e6@grimberg.me> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 21, 2023 at 12:50:29PM +0300, Sagi Grimberg wrote: > > > Why not simply wait for live? The connecting is obviously racy... > > > > That is what the new version is doing. It's waiting for the live state and then > > checks the queue count. > > Maybe don't fold waiting for live into waiting for queue_count. Alright, will do!