Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp9218285rwd; Wed, 21 Jun 2023 04:49:02 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7JhVPyaoCZDSIgwL2QRTJ4QAqp6AEmLSm2edwzZd/x6HIfoaXOw4VUya2z/u9baP6hBCey X-Received: by 2002:a05:6808:148a:b0:3a0:3ea9:c862 with SMTP id e10-20020a056808148a00b003a03ea9c862mr4856795oiw.46.1687348142278; Wed, 21 Jun 2023 04:49:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687348142; cv=none; d=google.com; s=arc-20160816; b=gzbd1qndbLF0s47/fps/h96+iv45lZOCNGof/I+lyNclrd+ZdGkEHVm68QNns33wsU kxjGgwcd/aeiZwmxEyw6PWSHoZbrzlrxb/sNY+OqWB/6RURzuB6Yyn9drCalYa6QXX3g NLls9TcBRLoiXd9utUpgQMd2wEZ5EkPoaA8JnBAncuk2nTyE0uIzfFzKxIX66TzY00Ja LytOSXOroOaX+L+YWh4DdQBIoGzclEWKfkA3Sil5JYNsJ2VCHReaWphD729sZAlXK4Lc UCFlpedXJG53aFw3IIyUSJ7iQTQ+FBa/DJVCBjlgPbmZq1fTG0lJFyo5TQufwnsDcBq5 cnyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:date:cc:to:from:subject:message-id :dkim-signature; bh=jGzlrCTKjqBQnnj9rWZsb7g14/hDJRb+BSJ2hQp+ReA=; b=hZgGBRHHWn0CfeRaU15+U0axCgSpxUpfcrO70WUPviRqJyL6yzdv4QuEcosbrf+hSp chFOPkwGR+ofWZftLIlFg+qe88yDsbCtdaw5gQ2kejsdzJB00cJn1A1zZepTMQ5OJdTX dFQJ4E2pNe0ocA14fu/rQhSgYm4d1/yDw8E02ml3X3b3cbqFk4JxHuspXOO8WwWndpJ0 mZQb2l3ua8MrABJFj3pPdc/477IibODvjEI6yhuZqRv6AjXEDMfaLyNGhNixmX4iho8O uGf/hLn7TnrcCMtLs+iFq3N3kheD/8b/7/zL/5PAwi86kscX4I3pVqVbogCSi+D/xzm4 HdrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@xry111.site header.s=default header.b=PwLKolzR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=xry111.site Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w8-20020a63f508000000b00552db57a742si3912908pgh.279.2023.06.21.04.48.47; Wed, 21 Jun 2023 04:49:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@xry111.site header.s=default header.b=PwLKolzR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=xry111.site Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231531AbjFUK5s (ORCPT + 99 others); Wed, 21 Jun 2023 06:57:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230464AbjFUK5q (ORCPT ); Wed, 21 Jun 2023 06:57:46 -0400 Received: from xry111.site (xry111.site [IPv6:2001:470:683e::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8ABE1A1 for ; Wed, 21 Jun 2023 03:57:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1687345063; bh=2m0Nc/TiyHFuh8a446e407hgjiDQ9WC/BQzH8iC0ShQ=; h=Subject:From:To:Cc:Date:From; b=PwLKolzRh4n2uw1xmWXMFyhfHjPRQ0ne81kpxu81GlXbfb2Us6ZgGzTCr0dRmlwgL OqkX+T2/3oE+xgbqiCYs37AfVwVjZ2v7PE3CNR2psxN2qowODxeKPWKD1QRSjO/kr8 F8i3flOmO2PwhOqbCefkZrvjYjIBJ4Eum/bJFOKQ= Received: from localhost.localdomain (xry111.site [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 4A54D66338; Wed, 21 Jun 2023 06:57:42 -0400 (EDT) Message-ID: <0b663d8f6802e8dbf443397718234bcb6d0811c8.camel@xry111.site> Subject: A question about prefetchw detection in "x86/asm: Cleanup prefetch primitives" From: Xi Ruoyao To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Borislav Petkov Date: Wed, 21 Jun 2023 18:57:40 +0800 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.3 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, In commit a930dc4543a2 ("x86/asm: Cleanup prefetch primitives"), a chunk of code was added: /* 3DNow or LM implies PREFETCHW */ if (!cpu_has(c, X86_FEATURE_3DNOWPREFETCH)) if (cpu_has(c, X86_FEATURE_3DNOW) || cpu_has(c, X86_FEATURE_LM)) set_cpu_cap(c, X86_FEATURE_3DNOWPREFETCH); But Glibc does not contain a similar logic in the CPU feature detection code, causing a test failure on old CPUs (https://sourceware.org/bugzilla/show_bug.cgi?id=3D30328). I intend to implement the same logic for Glibc. I can understand "3DNow implies PREFETCHW", but is there a bibliographical reference about "LM implies PREFETCHW" so I can convince the Glibc maintainers for the change? --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University