Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763683AbXJRRlf (ORCPT ); Thu, 18 Oct 2007 13:41:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758383AbXJRRl0 (ORCPT ); Thu, 18 Oct 2007 13:41:26 -0400 Received: from mail2.sea5.speakeasy.net ([69.17.117.4]:41854 "EHLO mail2.sea5.speakeasy.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758153AbXJRRlZ (ORCPT ); Thu, 18 Oct 2007 13:41:25 -0400 Message-ID: <47179ABB.9060104@freedesktop.org> Date: Thu, 18 Oct 2007 10:41:15 -0700 From: Josh Triplett User-Agent: Mozilla-Thunderbird 2.0.0.6 (X11/20071009) MIME-Version: 1.0 To: Alexey Dobriyan CC: linux-sparse@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: sparse breakage triggered by rcu_read_lock() lockdep annotations References: <20071016105521.GB6352@localhost.sw.ru> In-Reply-To: <20071016105521.GB6352@localhost.sw.ru> X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig591FEE2E43CC1C54566C6E09" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2066 Lines: 63 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig591FEE2E43CC1C54566C6E09 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Alexey Dobriyan wrote: > FWIW, commit 851a67b825540a8e00c0be3ee25e4627ba8b133b > aka "lockdep: annotate rcu_read_{,un}lock{,_bh}" > causes sparse to trigger internal assertion in quite a few places over > allyesconfig run. >=20 > sparse: flow.c:805: rewrite_parent_branch: Assertion `changed' failed.= >=20 > Trimmed down testcase: >=20 > void f(unsigned long ip); > static void g(void) > { > if (1) { > f(({ __label__ x; x: (unsigned long)&&x; })); > } > f(({ __label__ x; x: (unsigned long)&&x; })); > } >=20 > #0 0x4001c410 in __kernel_vsyscall () > (gdb) bt > #0 0x4001c410 in __kernel_vsyscall () > #1 0x40050701 in raise () from /lib/libc.so.6 > #2 0x40051e38 in abort () from /lib/libc.so.6 > #3 0x40049fcc in __assert_fail () from /lib/libc.so.6 > #4 0x08064947 in pack_basic_blocks (ep=3D0x411a1c6c) at flow.c:812 > #5 0x0805ffbf in linearize_symbol (sym=3D0x4103ec8c) at linearize.c:21= 54 > #6 0x080492a3 in main (argc=3DCannot access memory at address 0x274d) = at sparse.c:266 Thanks for the detailed report. Looking into it now. - Josh Triplett --------------enig591FEE2E43CC1C54566C6E09 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHF5q7GJuZRtD+evsRAi+yAJwOuuybjXRRSIVtdhymlpK2YzTCaACfTeAv o3T4QqwbeCF614dLCYgJIig= =OlIi -----END PGP SIGNATURE----- --------------enig591FEE2E43CC1C54566C6E09-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/