Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp9371100rwd; Wed, 21 Jun 2023 06:42:11 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7bIDFGgVEAyU6C7TqZchVwN5D2YS/Y+Qk/6oAIZPC+WYioLAXfxRwXbWl0o1CGFxIsP05L X-Received: by 2002:a17:902:e744:b0:1b6:9562:73d8 with SMTP id p4-20020a170902e74400b001b6956273d8mr2193554plf.50.1687354931237; Wed, 21 Jun 2023 06:42:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687354931; cv=none; d=google.com; s=arc-20160816; b=GKf7FV1MBaXJ9RKzlLRGhmFnSPb1SnvQvZhTHJ249R2OsIUb8xAYEi/HGEekPhNaQk 9SUQLaEp0MJffFgHDzP9uYieRw5RcwsTf/ts5/jRP+BYLXHich8pBwZk85FjVqKfK0wG Q9IqwEWt8f3w5JDLejarpx/AfTUXCB8U9fESKeuJYiKCXZRcDtrJI4dtxcD1FMWAXeqq bMlcwPtUbAYGKWjejxQ3OtZ9uMjHYimMhFqyn3aWI2c8cMC1r+ljhJBidtE0ewbka0yJ ZE3FvwuWmS4F2zKixmG6BNqpHwh5uq7tfyylM1hLeolNLcDt0lrUXeYFtu4tP04MOHOO uwJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=fNzgBv3S6Z9XVyqQGOlHUKzzBC7T0ZKsC6puwES5pQA=; b=VALBO4lu3dj7LOJli8mKrRdOtuZP2smEebwWkfEo2QIgh+W7SWAl/tctcaS0A4Mlk/ Z9F/OJwvFKjjPfHbTac9/AaNdD5F3owNhFnI3JNfmPExsTcjAlBmX4/Cpb1BtL+aZX9C ++lG8JLJuQ+JHzIlf5EMBnHd/HoOteHup/x6Sh7as2PfH+dY1xi1N9EvIhl/BTbDxDWY EfvRgJ6Vi3KTXoFrRlJESi8O7WKFpdpxK2dIv+7pHtFQyjoth1CS7Slea7w4EsFB92Z0 omqYpjk20rKheQ4e2pqM5+WKvZ+EafpOwfrSpiL6E58peRAMe6a7+X6l8/bpRAhZBh5S dEow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UzLCHXo4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e14-20020a170902ef4e00b001b55a5f3694si4528809plx.550.2023.06.21.06.41.49; Wed, 21 Jun 2023 06:42:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UzLCHXo4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232450AbjFUNSs (ORCPT + 99 others); Wed, 21 Jun 2023 09:18:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231134AbjFUNSk (ORCPT ); Wed, 21 Jun 2023 09:18:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B61D410C1 for ; Wed, 21 Jun 2023 06:18:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4ACB7614D7 for ; Wed, 21 Jun 2023 13:18:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BBDDC433C8; Wed, 21 Jun 2023 13:18:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687353518; bh=fNzgBv3S6Z9XVyqQGOlHUKzzBC7T0ZKsC6puwES5pQA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UzLCHXo4e0aRFNPwG0rKmRZ9TVR7a7NN1lkXVYfd9yPfJU1E6Lg07Ar/4It34XzUV g1835P2QVlAfUwL/EBQCqVeHkbXhGjyBlNGwelfSACYHzwFy7Lm3FcRlI4LPZHbVw/ E4aNvkzIJw9G3i9pY7BeuvjkXaqbqeJ6d1sfQR2qae8hDac/kQ4ZFDvTvaQg0vGn95 VTI/6/hHSiSDkYDP1YsdFRlzRboP3tpT06MS7rsrYtruEacD4hMjGcSJdwTxOVrQ0c cFyvNY2pMQYoYxp7zeKAFsm13UEUxM3+4dwcBkSvvtm62vhXe2q8hYCrE6ECimHnei a+dbmUfZ74W0Q== Date: Wed, 21 Jun 2023 14:18:32 +0100 From: Mark Brown To: Maxim Kochetkov Cc: alsa-devel@alsa-project.org, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Benjamin Mugnier , Krzysztof Kozlowski , Greg Kroah-Hartman , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Claudiu Beznea , Charles Keepax , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] ASoC: codecs: max98090: Allow dsp_a mode Message-ID: References: <20230621115328.156457-1-fido_max@inbox.ru> <3805dc65-113f-453a-90a9-2ae6204004ba@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7uVBzkQ09VJrlG8A" Content-Disposition: inline In-Reply-To: X-Cookie: When among apes, one must play the ape. X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --7uVBzkQ09VJrlG8A Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 21, 2023 at 04:02:34PM +0300, Maxim Kochetkov wrote: > On 21.06.2023 15:26, Mark Brown wrote: > > This is configuring DSP A identically to left justified mode, it looks > > like the format configuration needs at least some interlock with the TDM > > configuration. > According to datasheet MAX98090 supports only DSP_A (L data MSB after FRM > LRC) TDM mode. Allowing this mode will let us proper configure CPU audio > node via DT. Actual TDM mode activation is performed in > max98090_set_tdm_slot() via M98090_REG_TDM_FORMAT/M98090_REG_TDM_CONTROL > registers. I'm saying there should be some interlock between these two settings, if nothing else setting DSP A mode should force TDM mode with automatically configured slot sizes. --7uVBzkQ09VJrlG8A Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSS+KgACgkQJNaLcl1U h9BaHgf+PmazZFiaoqkNhCaUKsZylWCGAFPo+cgvXRDHq5Knkow2MpiNkogFgGJf I/9l7+LvZ8II/1BIxBVK4slt5eygq94wMkzA3q4UOVq0z0npBQZNfM3osCGXGOKW P3h77NAS5OSyNhe4GcKMSmRyiG4cPc1QYp6/KDJSuUWXHUaQMXQG9nWNv718Fsxj gtD96exbO3v2B5a/y8D0tGXhFCNU5xw9ZOlkXQULZtD/FD6oYL2loZ26os0Js7o5 qhmuoxz7ymH+ZLeLZZZxXNixaj8CcksYNiCWlWIj8VPxfEAmegLac3GzFWu7f8GW VH52b6Q6SFn9Gu5bjcJZGj8M6ClZfw== =1W9y -----END PGP SIGNATURE----- --7uVBzkQ09VJrlG8A--