Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 21 Jun 2023 15:46:45 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Xi Ruoyao <xry111@xry111.site>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: A question about prefetchw detection in "x86/asm: Cleanup
 prefetch primitives"
Message-ID: <20230621134645.GIZJL/Rf1IdeLMQGl2@fat_crate.local>
References: <0b663d8f6802e8dbf443397718234bcb6d0811c8.camel@xry111.site>
 <20230621111346.GFZJLbavDw1JiLi34n@fat_crate.local>
 <a155ebb791d3aefce5db32658e3c519a1cfac1f6.camel@xry111.site>
 <e76180a1b82d1c29715587e94e2d6923b64bb893.camel@xry111.site>
 <20230621125749.GGZJLzzUw0rA3goV1X@fat_crate.local>
 <b50735128c5a985634468d63fef092f093f0aebc.camel@xry111.site>
 <20230621130955.GHZJL2o771lIEPURUl@fat_crate.local>
 <29beee7faf370ea892cb4e5a85ddd1f7ee132164.camel@xry111.site>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <29beee7faf370ea892cb4e5a85ddd1f7ee132164.camel@xry111.site>
Precedence: bulk

On Wed, Jun 21, 2023 at 09:19:34PM +0800, Xi Ruoyao wrote:
> On Wed, 2023-06-21 at 15:09 +0200, Borislav Petkov wrote:
> > On Wed, Jun 21, 2023 at 09:06:51PM +0800, Xi Ruoyao wrote:
> > > I think it's not an issue in the kernel itself, but announcing
> > > 3dnowprefetch in /proc/cpuinfo for an old Intel CPU w/o real prefetchw
> > > implementation seems problematic (to me).
> > 
> > And this is a problem because?
> 
> If a code generator parses /proc/cpuinfo for CPU capabilities, it may
> generates a no-op prefetchw instead of prefetcht0 as a fallback.

Err, go back.

That code snippet you pasted, did you see where that comes from?

A function called init_amd().

Now, is Intel hardware and SDM PREFETCHW text at all relevant here?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette