Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932584AbXJRTnQ (ORCPT ); Thu, 18 Oct 2007 15:43:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756874AbXJRTnD (ORCPT ); Thu, 18 Oct 2007 15:43:03 -0400 Received: from hellhawk.shadowen.org ([80.68.90.175]:4593 "EHLO hellhawk.shadowen.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756773AbXJRTnB (ORCPT ); Thu, 18 Oct 2007 15:43:01 -0400 Date: Thu, 18 Oct 2007 20:43:04 +0100 From: Andy Whitcroft To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: latest checkpatch Message-ID: <20071018194304.GD21136@shadowen.org> References: <20071015182118.GA4459@shadowen.org> <200710161759.l9GHxnkK012590@agora.fsl.cs.sunysb.edu> <20071017163916.GO21136@shadowen.org> <20071018111352.GA17039@elte.hu> <20071018192521.GC21136@shadowen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071018192521.GC21136@shadowen.org> User-Agent: Mutt/1.5.13 (2006-08-11) X-SPF-Guess: neutral Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1197 Lines: 29 On Thu, Oct 18, 2007 at 08:25:21PM +0100, Andy Whitcroft wrote: > On Thu, Oct 18, 2007 at 01:13:52PM +0200, Ingo Molnar wrote: > > > > latest checkpatch.pl works really well on sched.c. > > > > there's only one problem left, this bogus false positive warning > > reappeared: > > > > WARNING: braces {} are not necessary for single statement blocks > > #5710: FILE: sched.c:5710: > > + if (parent->groups == parent->groups->next) { > > + pflags &= ~(SD_LOAD_BALANCE | > > + SD_BALANCE_NEWIDLE | > > + SD_BALANCE_FORK | > > + SD_BALANCE_EXEC | > > + SD_SHARE_CPUPOWER | > > + SD_SHARE_PKG_RESOURCES); > > + } > > > > (there's another place in sched.c that trips this up too.) Ok, checkpatch.pl-next should now no longer trip up on this statement. -apw - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/