Message-ID: <4717BBD0.7070504@qumranet.com>
Date: Thu, 18 Oct 2007 22:02:24 +0200
From: Avi Kivity <avi@qumranet.com>
User-Agent: Thunderbird 2.0.0.5 (X11/20070719)
MIME-Version: 1.0
To: Ingo Molnar <mingo@elte.hu>
CC: Andy Whitcroft <apw@shadowen.org>, linux-kernel@vger.kernel.org,
       Andrew Morton <akpm@linux-foundation.org>
Subject: Re: latest checkpatch
References: <20071015182118.GA4459@shadowen.org> <200710161759.l9GHxnkK012590@agora.fsl.cs.sunysb.edu> <20071017163916.GO21136@shadowen.org> <20071018111352.GA17039@elte.hu> <20071018192521.GC21136@shadowen.org> <20071018193929.GA22031@elte.hu>
In-Reply-To: <20071018193929.GA22031@elte.hu>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1296
Lines: 46

Ingo Molnar wrote:
> * Andy Whitcroft <apw@shadowen.org> wrote:
>
>   
>>> it's perfectly legitimate, in fact more robust. So if checkpatch.pl 
>>> wants to make any noise about such constructs it should warn about 
>>> the _lack_ of curly braces in every multi-line condition block 
>>> _except_ the only safe single-line statement:
>>>
>>> 	if (x)
>>> 		y();
>>>       
>> Indeed.  We should probabally do more on the indentation checks in
>> general.  The current direct check for:
>>
>> 	if (foo);
>> 		bar();
>>
>> Could probabally be generalised to look for this kind of error:
>>
>> 	if (foo)
>> 		bar();
>> 		baz();
>> 	one();
>>     
>
> detecting that would be awesome - it's often the sign of a real bug 
> because the intent is often to have bar() and baz() in the conditional 
> block.
>
>   

This is more useful operating on an entire file, so the script can see
all the context.

A 'gcc -Windentation-contradicts-codeflow -Werror' would be nice.


-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/