Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 21 Jun 2023 08:28:54 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     kernel test robot <oliver.sang@intel.com>
Cc:     oe-lkp@lists.linux.dev, lkp@intel.com,
        linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Ackerley Tng <ackerleytng@google.com>,
        Erdem Aktas <erdemaktas@google.com>,
        Matthew Wilcox <willy@infradead.org>,
        Muchun Song <songmuchun@bytedance.com>,
        Sidhartha Kumar <sidhartha.kumar@oracle.com>,
        Vishal Annapurve <vannapurve@google.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-fsdevel@vger.kernel.org, ying.huang@intel.com,
        feng.tang@intel.com, fengwei.yin@intel.com
Subject: Re: [linus:master] [page cache]  9425c591e0:
 vm-scalability.throughput -20.0% regression
Message-ID: <20230621152854.GA4155@monkey>
References: <202306211346.1e9ff03e-oliver.sang@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202306211346.1e9ff03e-oliver.sang@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Zbxa0kXpvGoNdRd92QbpO1wfmRtoOx7TsOHIqT1PC7CfJ9uSflTKAgHsjpGb?=
 =?us-ascii?Q?Z3wOPRY5m/TGcoMtS+CMYH7P2tJq1Sv3lnUAEK5KM0BH5MJJBdFgRGgGoplc?=
 =?us-ascii?Q?pf66ziukxxy2aV/k57uGyrARcbk11hn+qHD2tEd6/fjdSknygcn95I2dpeBz?=
 =?us-ascii?Q?iUs0jPFtsK5Q6uDkdPxe7RK9ryuUpiRsjfowVCvBpt2M27s+UYgJrURrKoaT?=
 =?us-ascii?Q?veZEoYj7rJ1WkwPIbuBDslgzbU64Y4NXXYRnPynbjtoTgHhIJuc6bijrqRja?=
 =?us-ascii?Q?R/S30Cr10EtCr4CrRRgJqZWMWLQDWQC/b64dNLtLKPtIrhzU1g4TkhnDSakV?=
 =?us-ascii?Q?1w8cMFLnIOVoGjs/Yy0tmTTxi5Opyt2grGj6A9pLRFdfoiT7I++gaeOUTQb5?=
 =?us-ascii?Q?Tu9xu2MpupdTfaCY1UTnM5T8ccEU+8X6fpu8hWhI+g5yhYc8e9N9VoWS4qfg?=
 =?us-ascii?Q?JWXgJYEb+RYY1tY6a5TFnuxJ0Iz8/bnKNhvY/hxKB/3yo8vgDgOm5bLuZs4H?=
 =?us-ascii?Q?950+1QL9ObjGygb5iGI6BooD1TXVSTqqD1lnaGVyDTYT61S0teCcUbZgrqlh?=
 =?us-ascii?Q?slLKaWryc9G/xzevu5Vg6ymWt8b+3TNCd1bJ/ADSnbuOKOfurmKzMKwXYfxP?=
 =?us-ascii?Q?E2rU/Uzza0m3EXN4hCCYLvmT6WPUsQ3iSDbuWrgVAf2yhInWIASD+itZyCf0?=
 =?us-ascii?Q?i4mz6zpSY3LpcXiiWVVS2dQcXh3uPDT6ifvYj2B7fnoqIuGPtDFKFDpq0wbL?=
 =?us-ascii?Q?ni+fpbSCjku13y1DYQ/4WRokHSIoqWxZ6qr+ItHCZgyN+/TKs8qVUT8xO8FS?=
 =?us-ascii?Q?IXAXRWdejzhDSvTHHVdVIaxfdiMVLZxRVU+Uff+rbkD92ej6B+wVzorCyzIz?=
 =?us-ascii?Q?zRcz3WZi+PoqjAHVdpo1c8V1GMqp5/Rjac5pge298Sh2cZ8HBXV+SvHSjwVL?=
 =?us-ascii?Q?7EhSF3Zq7Zfp+4Q4cg3fLs44odIvNy2lBxov4ykhyYTPzaQyWQpgo2gyB4sg?=
 =?us-ascii?Q?CfgZdOvqPgSodcOVthDAoOzbj/RRtC1kt0ZmoHb1LTXNkwx3L3DAkkE3Ny4Y?=
 =?us-ascii?Q?xpLQd/VqgiBYFWrFDXXUBWCr7Ve0h7S6pNcYsFg8oxzUKkWjaANZWe6Rp1ko?=
 =?us-ascii?Q?sme9Q/gCJDoVBzTLQCkLI5hA0s5iAO77ANSEBBgEKraiH0DZ++ggxOBPU3Se?=
 =?us-ascii?Q?fJN2HKHeVxA1SZh0f+bhRasqWFA6oxGhqlC0zklAeQt97qlQSTLSYVwgaL7Q?=
 =?us-ascii?Q?wkVHWDmwyDVl5ux9WnPimobC6Jn8gW0lTGtyTpnSBlZ0a7DtqcXPaZ0eTnHW?=
 =?us-ascii?Q?XG/sD7D/75FbV/4pUSQowib2bMxOuvE8Dncb8n1tXOUlxJnhXeAasj4svLGu?=
 =?us-ascii?Q?2xF9aXZyV42PF01iLSLRfG4IETR7roxUsUheYwvJ0e3bg7krM11YO7VBVfwr?=
 =?us-ascii?Q?Yw6CxYU9WDqqwT9baV1XNS+n0pEBvusy5CHPm12sY34hitiT8S8bz+rj1ZvA?=
 =?us-ascii?Q?xDmplbLl+5XfAxlga+/Axf9tgxgcL3BLnyohcU72lnBSDGRx+IXd+SMpyMGu?=
 =?us-ascii?Q?HcMW+JSizcy9rlf56c109H2dJFzecf4gbQ/0pLjk?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?cfTL1aINgtHct5n0kLh5P9oUIgCBwzvBenasTS3MXB8jcYtX+w0umG2fbaXW?=
 =?us-ascii?Q?6+BXT9Ij9cboEYjOCaoyAcNFZeY4KjCxNIZt6BcfVDQF8gAkkeTETGRt8Le8?=
 =?us-ascii?Q?x6X0g9puF7wE7hlF3U7t0qhqXvev+XlB1QYWSNYD9elVX0PTY+5f5UqjKsAm?=
 =?us-ascii?Q?C4HlCfXOZsKgYEBIShBuUDudKAaqu73KycHqqiE1eRr3lHjE3xHB8EgKpARv?=
 =?us-ascii?Q?L+lGVCl/0hUZxgEPYaFiJZXuJ84ClkNJoJn8UB74He1rRq96COLO+JoYDS8+?=
 =?us-ascii?Q?4u0mQqw5O7UfqZWEYDZa3N356N8hSdumXcWp3kXwEoGE5q3F9r0y4nJwT9BH?=
 =?us-ascii?Q?/ENLlfPg6PG377mH/pp4acLwXddv94ZvheOQOpimGSrc6b0kN36piYayZqKH?=
 =?us-ascii?Q?RKIQ4lfUL6LxpPSo9iG4TwJm7dUydKIHl/W6iNxdC5kiX1m6z8VzKEu/FEVN?=
 =?us-ascii?Q?6LiWBKBgAUGWikkech7K0FxrgcUyRMUx/fzPj6oQ0HUgdAWbXHg56IrIAA5n?=
 =?us-ascii?Q?OzTbAOyM65WSR5pVh1M+8TejaX3cpqrSi20TfrGLCBD0YOByB61g6dh3b1wy?=
 =?us-ascii?Q?ra1SMrTowDiISlgC9G9qdTlshF0BIrnoAarhhS9hozpYA2FsyUKTwkLZ6KX7?=
 =?us-ascii?Q?RaA0gKWSCpejWdYyXruyrDWIX3jLMbdSSuifuO4Napu4lGDpBazb9ciGSaiq?=
 =?us-ascii?Q?1+TiagYypQzfoUS1mZJbYfJTqN5B+puJ1vJMAbDMwRSnCTv3KLIV7O8TOoGV?=
 =?us-ascii?Q?UIsbQ7fxaVon64+MJRCToKjohK+rjBtEHt9BWa0sQux8QDJ8OdcvoRti6AYE?=
 =?us-ascii?Q?0ss3+HqLIxD6PhDdEMonmlrku3I9dj47udqPUoLYJ4TFD45jGXZbqGEd6+mE?=
 =?us-ascii?Q?UR4rVBLklK4wY/RNbFmxaHedfNB4KRlNyr3E8YPASyDni5PImmWxWuiBSicf?=
 =?us-ascii?Q?nKxZy/vRVu9sWsCcvpKWA7Y1c/xqmm/M+G5l5C8MHAstIO3mUX4dpgwb0dWg?=
 =?us-ascii?Q?8X1J7WKTjVcisDOV5HuGEkH7I0Ch+RZ2iZAd3+Zb5HC0EJI=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7890a4f2-11f1-4a63-b3e9-08db726c3b00
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2023 15:28:57.7035
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: y8tEJ1Szd3LSAx/y+dtP5svQgfzDXqKVQl26n0pZobLB7ppIguEBsRQwWhBGbzePk6REZm7Z4KVUG9eRjaP4yw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5151
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-06-21_08,2023-06-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0
 mlxlogscore=999 suspectscore=0 spamscore=0 adultscore=0 phishscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2305260000 definitions=main-2306210130
X-Proofpoint-GUID: AGRd1rb12D98pcHQaaIxuyfxUKB0AEpg
X-Proofpoint-ORIG-GUID: AGRd1rb12D98pcHQaaIxuyfxUKB0AEpg
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/21/23 15:19, kernel test robot wrote:
> 
> 
> Hello,
> 
> kernel test robot noticed a -20.0% regression of vm-scalability.throughput on:
> 
> 
> commit: 9425c591e06a9ab27a145ba655fb50532cf0bcc9 ("page cache: fix page_cache_next/prev_miss off by one")
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> 
> testcase: vm-scalability
> test machine: 96 threads 2 sockets Intel(R) Xeon(R) Platinum 8260L CPU @ 2.40GHz (Cascade Lake) with 128G memory
> parameters:
> 
> 	runtime: 300s
> 	test: lru-file-readonce
> 	cpufreq_governor: performance
> 
> test-description: The motivation behind this suite is to exercise functions and regions of the mm/ of the Linux kernel which are of interest to us.
> test-url: https://git.kernel.org/cgit/linux/kernel/git/wfg/vm-scalability.git/
> 
> In addition to that, the commit also has significant impact on the following tests:
> 
> +------------------+----------------------------------------------------------------------------------------------------+
> | testcase: change | vm-scalability: vm-scalability.throughput -18.9% regression                                        |
> | test machine     | 96 threads 2 sockets Intel(R) Xeon(R) Platinum 8260L CPU @ 2.40GHz (Cascade Lake) with 128G memory |
> | test parameters  | cpufreq_governor=performance                                                                       |
> |                  | debug-setup=no-monitor                                                                             |
> |                  | runtime=300s                                                                                       |
> |                  | test=lru-file-readonce                                                                             |
> +------------------+----------------------------------------------------------------------------------------------------+
> | testcase: change | vm-scalability: vm-scalability.throughput -52.8% regression                                        |
> | test machine     | 224 threads 2 sockets Intel(R) Xeon(R) Platinum 8480CTDX (Sapphire Rapids) with 256G memory        |
> | test parameters  | cpufreq_governor=performance                                                                       |
> |                  | runtime=300s                                                                                       |
> |                  | test=lru-file-readonce                                                                             |
> +------------------+----------------------------------------------------------------------------------------------------+
> | testcase: change | vm-scalability: vm-scalability.throughput -54.0% regression                                        |
> | test machine     | 224 threads 2 sockets Intel(R) Xeon(R) Platinum 8480CTDX (Sapphire Rapids) with 256G memory        |
> | test parameters  | cpufreq_governor=performance                                                                       |
> |                  | debug-setup=no-monitor                                                                             |
> |                  | runtime=300s                                                                                       |
> |                  | test=lru-file-readonce                                                                             |
> +------------------+----------------------------------------------------------------------------------------------------+
> 

Ouch!

I suspected this change could impact page_cache_next/prev_miss users, but had
no idea how much.

Unless someone sees something wrong in 9425c591e06a, the best approach
might be to revert and then add a simple interface to check for 'folio at
a given index in the cache' as suggested by Ackerley Tng.
https://lore.kernel.org/linux-mm/98624c2f481966492b4eb8272aef747790229b73.1683069252.git.ackerleytng@google.com/
-- 
Mike Kravetz