Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e5eacc1e-36f8-be9d-dfac-a68c1663498c@amd.com>
Date:   Wed, 21 Jun 2023 17:09:14 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [RFC PATCH v3 0/4] drm: Standardize device reset notification
Content-Language: en-US
To:     =?UTF-8?Q?Andr=c3=a9_Almeida?= <andrealmeid@igalia.com>
Cc:     kernel-dev@igalia.com, alexander.deucher@amd.com,
        pierre-eric.pelloux-prayer@amd.com,
        Simon Ser <contact@emersion.fr>, linux-kernel@vger.kernel.org,
        amd-gfx@lists.freedesktop.org, Rob Clark <robdclark@gmail.com>,
        Pekka Paalanen <ppaalanen@gmail.com>,
        dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
        Daniel Stone <daniel@fooishbar.org>,
        =?UTF-8?B?J01hcmVrIE9sxaHDoWsn?= <maraeo@gmail.com>,
        Dave Airlie <airlied@gmail.com>,
        =?UTF-8?Q?Michel_D=c3=a4nzer?= <michel.daenzer@mailbox.org>,
        Samuel Pitoiset <samuel.pitoiset@gmail.com>,
        =?UTF-8?Q?Timur_Krist=c3=b3f?= <timur.kristof@gmail.com>,
        Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
References: <20230621005719.836857-1-andrealmeid@igalia.com>
 <caa69e8e-f330-d819-e8cd-7b06aa8eb855@amd.com>
 <195dd084-a97b-ef08-a221-e39ffcd7cc09@igalia.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <195dd084-a97b-ef08-a221-e39ffcd7cc09@igalia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2J2bGxEcFpmd2hIckpXQmY2bmt5a1dRazlNMnk5aS9mOFhMRmxsOGdXTTRN?=
 =?utf-8?B?ZWhQT2Q1c3NwdndHazQ1V3BURDdONENGTGV3eGVFbVV5K1hiUS9IR0hXT3RJ?=
 =?utf-8?B?K0JHbE1US1Z3aCs3bzNDSnhjaXhUMnQvWmNsdEFuWVliZnBpVW1INjZpenJ4?=
 =?utf-8?B?ZnFkNmhjSHBSdElEMEVTNC83QzBwUU91MURwTnpSK1ZVZEFwYVdNZEpIZWpl?=
 =?utf-8?B?bE5OekhIWmJCUmhxQnl2SGdzRmZvekhQYXhEdFZHYjUxeWFDaXJHUEU2U0pa?=
 =?utf-8?B?LzBIUXBkMHVrQnFiQStqZGpGbzh4ZVZnOS9VcVcvNDFERzVFQVBxNTgrOUtH?=
 =?utf-8?B?NGlTUE9qeFVEWGN6SDlkYTFscWFOdURma3VaRDhtSThaSDcrRFNEZDk1dmxy?=
 =?utf-8?B?MmdhSGpobkFlVllsWDFZT3pSckhJTGt2bDhVUFlHQzBGUWZDT1hDbnFGZVgw?=
 =?utf-8?B?YktYbk1teFlYNWpFUXliVEptVU0zRi9FdGdIUE5DS2kyNkR6M0FzMENpNXgx?=
 =?utf-8?B?MHkyTnc2ZTdJZENHcXFBOVlZblE5WkxGNTBJc000aHNEaHZtaG5SVEMyYnU4?=
 =?utf-8?B?TFp3S1FNcW4vK1JYRGF4d1N2Yk01UktGUVIzdy9HaVkramk5ZCtmZUpORHpT?=
 =?utf-8?B?dzFrbkw1cEhnWFN1dHhOWDdmOURPUldubFNyNjViclhsaWNOaTJMM2VQdFZZ?=
 =?utf-8?B?VytkUlMwbm1sY29zTnBoYnlIY3BpK2xrLzhjMmd0Sy9HazRoRmFBaHZhVFBG?=
 =?utf-8?B?ZXoyZ21MQzhMN0MzL1IzWHhvQ0hocXBMaE93VlhWa1pkQTNvWTBVcXFkU0Fz?=
 =?utf-8?B?Nk9JQ28xRVY4MnZNT0VjR2t0V0V5QXpERlhMWHBDV2hVWG1aaXhFdXFKQ2Nq?=
 =?utf-8?B?WW9sTEhvOVA3cld5WlNuN2tVWitSL1NEV2tYcWZpRWpDWjVtejFaRStBZHZx?=
 =?utf-8?B?MHZzNmQ3QmRVbEhVRFg0MFdtQldNV1cvMlEzTjRmekVSV2VyM2VJcmlPY0RR?=
 =?utf-8?B?aW5uWlVLWGVHUzgzSzM1NW12VTNOZFg4TlUxMlMvRE9vQnhYbituODNyZlM1?=
 =?utf-8?B?L29CYTdxWXlVZkFJSnFiSHhwcTBaZm84ZkkyTUdUbmp6cnhFOGM1SnBoQTBP?=
 =?utf-8?B?V2l3NXlqak5SNlN6RGtEcGRuaWF3YjN0L3F3M3FEV29OVkZQangydzZNOThT?=
 =?utf-8?B?UVAxSUorVEVHcW5LNllPbVF2VXpsTFJzV3NQbVRLcEtXLzI2ZlRZbnNQSFpE?=
 =?utf-8?B?SjZEdFM3OGRwZjl5MGROaEFlV2NkSDh3V1FYNnlUZ3BlQmVlRG9vVDM3NCtw?=
 =?utf-8?B?T0VvaC9yMGdubHBaUG5YL0NwSS93RUZkem4zMC8wbnptOHpKVXFyVFV0MW1z?=
 =?utf-8?B?RGhXTXZKWENnWWZDS3FHejhDaGY0Y2tQLzFGWjZiaXJPR0UyS0E3MHd6VkhQ?=
 =?utf-8?B?UVZRVnRNaEZnNHA2WkhWd0VPaDh5ZFpXNnBDVFMrR0JwUzFFTXpXUkJPc1ZW?=
 =?utf-8?B?bkt4VGU0M0I5UCsyMzlVY3hRZ29JZjFsWTN5emFBT2piaHNJamw0VWJJTE4y?=
 =?utf-8?B?cWJGM2QreFJpWXBleE4xY2w1MGlLaGY1LzVUNTFjTC81Wm5wRWNGRW42OURR?=
 =?utf-8?B?bHk1VThaRWx2TVM5cnV6Zk80aU01NjRUcURyNmx5ZTYxWUVEZUZ2TkduQjJZ?=
 =?utf-8?B?MmtYUStGdHk4TjdBZTA0ZDd6OUdQbDBHZU92c0hvWlZmM1RTTmU4dktQRG52?=
 =?utf-8?B?U2NUZ1N2M1VCRElpaW52cWpWTGF2UmVqcitRakRSekRoakFYSjZ4cHhDMXRM?=
 =?utf-8?B?SXVBRUJFZWZwSVp6cDdPblpkOGltdlI2QVRzTnZGQnZWSklIV05EQUxFYVdX?=
 =?utf-8?B?YmRlMHlJSWxwZUsydkFJczRVSEpLZXhnQnlabDFaVGFSeHdheW9SaUIxajVJ?=
 =?utf-8?B?YUFmMmNOM1F5eWxzU1JVcm95U0N6aE9wbitNaTJiRHZsbm9HWUljQldTRE5y?=
 =?utf-8?B?Vnp6SDdQSDh0RFVmaXVZbmtlRjN6TitKcU9vREhDWnJPVmJacGJyVU8rVi8r?=
 =?utf-8?B?ZTA2ZGtod0RFcXBCMWMxWjA5Y2FOTDJJOG0xejFuNVM5TERkVXFBcTJZN1hD?=
 =?utf-8?B?S0hkbkdFbGRtdmtKZ290Y3JLbE8wSEo4QmkzMkdyQXUzRlJqSkhMelA4ekJq?=
 =?utf-8?Q?sSTKlD/Ywx7jzMpCgjz9K74zQZ/e35DfaiUqFfYWkWK2?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4bda986b-ca0c-412b-1681-08db72697daf
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2023 15:09:21.4346
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xhR7MsDS3B7hyVwGenVEM/bz9NpZ3p9O3cW3EF4S0BE5euhLD9i1TX+mIq6n7FBo
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6247
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 21.06.23 um 17:06 schrieb André Almeida:
> Em 21/06/2023 04:42, Christian König escreveu:
>> Am 21.06.23 um 02:57 schrieb André Almeida:
>>> Hi,
>>>
>>> This is a new version of the documentation for DRM device resets. As 
>>> I dived
>>> more in the subject, I started to believe that part of the problem 
>>> was the lack
>>> of a DRM API to get reset information from the driver. With an API, 
>>> we can
>>> better standardize reset queries, increase common code from both DRM 
>>> and Mesa,
>>> and make easier to write end-to-end tests.
>>>
>>> So this patchset, along with the documentation, comes with a new 
>>> IOCTL and two
>>> implementations of it for amdgpu and i915 (although just the former 
>>> was really
>>> tested). This IOCTL uses the "context id" to query reset 
>>> information, but this
>>> might be not generic enough to be included in a DRM API.
>>
>> Well the basic problem with that is that we don't have a standard DRM 
>> context defined.
>>
>> If you want to do this you should probably start there first.
>
> Any idea on how to start this? I tried to find previous work about 
> that, but I didn't find.

I'm not aware of any work in this area, maybe ping on the Mesa list as well.

Could be that someone looked into that but never send anything out.

>
>>
>> Apart from that this looks like a really really good idea to me, 
>> especially that we document the reset expectations.
>
> I think I'll submit just the doc for the next version then, given that 
> the IOCTL will need a lot of rework.

Yeah, agree completely.

Thanks,
Christian.

>
>>
>> Regards,
>> Christian.
>>
>>>    At least for amdgpu,
>>> this information is encapsulated by libdrm so one can't just call 
>>> the ioctl
>>> directly from the UMD as I was planning to, but a small refactor can 
>>> be done to
>>> expose the id. Anyway, I'm sharing it as it is to gather feedback if 
>>> this seems
>>> to work.
>>>
>>> The amdgpu and i915 implementations are provided as a mean of 
>>> testing and as
>>> exemplification, and not as reference code yet, as the goal is more 
>>> about the
>>> interface itself then the driver parts.
>>>
>>> For the documentation itself, after spending some time reading the 
>>> reset path in
>>> the kernel in Mesa, I decide to rewrite it to better reflect how it 
>>> works, from
>>> bottom to top.
>>>
>>> You can check the userspace side of the IOCLT here:
>>>   Mesa: 
>>> https://gitlab.freedesktop.org/andrealmeid/mesa/-/commit/cd687b22fb32c21b23596c607003e2a495f465
>>>   libdrm: 
>>> https://gitlab.freedesktop.org/andrealmeid/libdrm/-/commit/b31e5404893ee9a85d1aa67e81c2f58c1dac3c46
>>>
>>> For testing, I use this vulkan app that has an infinity loop in the 
>>> shader:
>>> https://github.com/andrealmeid/vulkan-triangle-v1
>>>
>>> Feedbacks are welcomed!
>>>
>>> Thanks,
>>>         André
>>>
>>> v2: 
>>> https://lore.kernel.org/all/20230227204000.56787-1-andrealmeid@igalia.com/
>>> v1: 
>>> https://lore.kernel.org/all/20230123202646.356592-1-andrealmeid@igalia.com/
>>>
>>> André Almeida (4):
>>>    drm/doc: Document DRM device reset expectations
>>>    drm: Create DRM_IOCTL_GET_RESET
>>>    drm/amdgpu: Implement DRM_IOCTL_GET_RESET
>>>    drm/i915: Implement DRM_IOCTL_GET_RESET
>>>
>>>   Documentation/gpu/drm-uapi.rst                | 51 ++++++++++++++++
>>>   drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c        |  4 +-
>>>   drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c       | 35 +++++++++++
>>>   drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.h       |  5 ++
>>>   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c       |  1 +
>>>   drivers/gpu/drm/amd/amdgpu/amdgpu_job.c       | 12 +++-
>>>   drivers/gpu/drm/amd/amdgpu/amdgpu_job.h       |  2 +
>>>   drivers/gpu/drm/drm_debugfs.c                 |  2 +
>>>   drivers/gpu/drm/drm_ioctl.c                   | 58 
>>> +++++++++++++++++++
>>>   drivers/gpu/drm/i915/gem/i915_gem_context.c   | 18 ++++++
>>>   drivers/gpu/drm/i915/gem/i915_gem_context.h   |  2 +
>>>   .../gpu/drm/i915/gem/i915_gem_context_types.h |  2 +
>>>   drivers/gpu/drm/i915/i915_driver.c            |  2 +
>>>   include/drm/drm_device.h                      |  3 +
>>>   include/drm/drm_drv.h                         |  3 +
>>>   include/uapi/drm/drm.h                        | 21 +++++++
>>>   include/uapi/drm/drm_mode.h                   | 15 +++++
>>>   17 files changed, 233 insertions(+), 3 deletions(-)
>>>
>>