Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp9614662rwd; Wed, 21 Jun 2023 09:31:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5c/AHSO+vWTE2Pna3882SBOtZD3XIyB8bGLhJXOzDzjZpdSmA/fnu5xuKbdKVXqrGpOLBV X-Received: by 2002:a9d:7ac8:0:b0:6b5:8b7a:552d with SMTP id m8-20020a9d7ac8000000b006b58b7a552dmr7705237otn.3.1687365067346; Wed, 21 Jun 2023 09:31:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687365067; cv=none; d=google.com; s=arc-20160816; b=NEHuNqNmycRr4JXuymwfxg4MmGfozH8tL1jqvD4/Kzxqes1w3YZYwOHt62XkfL93VP z0f6wN9yL6P1y4PJP/aw8gSfODZDf8K7qfPASYbgSK7Gx8BKhUGE4yQNhL6HdYKKvsd0 FEgOP3D+pHSbXTNP4NrMvNJp8ukqY6nKEVU20lEmbDNuGkek6JnaxHyL+3XzooBHVlHy BHGMRvyYlNdYuOEQQaJhweyYiZGKosGfa2ffz2Dvq6OTCzul79sFgXYJToRg8OaXfglf I7vymW0bLYe5Sips/WtwQcWjbnAAr/hIy+2WwzA7R71QB2Dg/izJxpAnykab7tpGYRvk mJYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=MwWE5K/dHstZtXS7EeLRtjUK7r2rBTjIqEtaixHPlNM=; b=or6bGSeF6/MOMTNlsN3D4qk1h3POd1f2MuyCS8gjc0J8LZ4D7esVl5meDzwAkzJXrk IZfupokrEDKyXgoloAJ/0vSqBbd2iIaR0EpIfxzDsn7+rWFBaj01azMsM9igkJHugz9y ZwSsMW7D+42vLPHpEKjm3s9Of3N2szKGVJZc+xPqcy7YgneVY8lwVt0zV2mZ2AQ/cg7c akMfaG+E3lGXTmlkmkQUEVLPRhg96A13qkjVC/p1mpVHutRASlU9m7hvLNq9J+Mn16hL ikloyznycy0iSW8BTHMmTbVDBWlqjqLDvihFewIptEOevmwTqT6ZL/c8f4DsNYe/Mpa4 rLqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q65-20020a632a44000000b0054405637a7esi4348496pgq.801.2023.06.21.09.30.48; Wed, 21 Jun 2023 09:31:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233362AbjFUPvw (ORCPT + 99 others); Wed, 21 Jun 2023 11:51:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232123AbjFUPvv (ORCPT ); Wed, 21 Jun 2023 11:51:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0578DBC for ; Wed, 21 Jun 2023 08:51:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8EE166159B for ; Wed, 21 Jun 2023 15:51:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1FBFC433C0; Wed, 21 Jun 2023 15:51:45 +0000 (UTC) From: Catalin Marinas To: will@kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, chris@zankel.net, jcmvbkbc@gmail.com, steven.price@arm.com, vincenzo.frascino@arm.com, leyfoon.tan@starfivetech.com, mason.huo@starfivetech.com, jeeheng.sia@starfivetech.com, conor.dooley@microchip.com, ajones@ventanamicro.com, Song Shuai Cc: linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: (subset) [PATCH V2 0/4] Remove WARN_ON in save_processor_state Date: Wed, 21 Jun 2023 16:51:43 +0100 Message-Id: <168736259084.605458.4732376069158804322.b4-ty@arm.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230609075049.2651723-1-songshuaishuai@tinylab.org> References: <20230609075049.2651723-1-songshuaishuai@tinylab.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 09 Jun 2023 15:50:45 +0800, Song Shuai wrote: > During hibernation or restoration, freeze_secondary_cpus > checks num_online_cpus via BUG_ON, and the subsequent > save_processor_state also does the checking with WARN_ON. > > In the case of CONFIG_PM_SLEEP_SMP=n, freeze_secondary_cpus > is not defined, but the sole possible condition to disable > CONFIG_PM_SLEEP_SMP is !SMP where num_online_cpus is always 1. > We also don't have to check it in save_processor_state. > > [...] Applied to arm64 (for-next/misc), thanks! I couldn't tell whether this series would go in as a whole but given that the patches are independent, I picked up the arm64 one. [2/4] arm64: hibernate: remove WARN_ON in save_processor_state https://git.kernel.org/arm64/c/615af0021a61 -- Catalin