Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <debdc47a-c377-e457-5643-415d93ced54a@acm.org>
Date:   Wed, 21 Jun 2023 08:41:58 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
From:   Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH] docs: target: Convert tcm_mod_builder.py print syntax to
 python3
To:     Rong Tao <rtoax@foxmail.com>, martin.petersen@oracle.com
Cc:     rongtao@cestc.cn, Jonathan Corbet <corbet@lwn.net>,
        "open list:SCSI TARGET SUBSYSTEM" <linux-scsi@vger.kernel.org>,
        "open list:SCSI TARGET SUBSYSTEM" <target-devel@vger.kernel.org>,
        "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Mike Christie <michael.christie@oracle.com>
References: <tencent_F3895D0EA868BCCE8C56221619BC093D660A@qq.com>
Content-Language: en-US
In-Reply-To: <tencent_F3895D0EA868BCCE8C56221619BC093D660A@qq.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/21/23 00:33, Rong Tao wrote:
> diff --git a/Documentation/target/tcm_mod_builder.py b/Documentation/target/tcm_mod_builder.py
> index 54492aa813b9..e2ef72925de3 100755
> --- a/Documentation/target/tcm_mod_builder.py
> +++ b/Documentation/target/tcm_mod_builder.py
> @@ -20,7 +20,7 @@ fabric_mod_port = ""
>   fabric_mod_init_port = ""
>   
>   def tcm_mod_err(msg):
> -	print msg
> +	print(msg)
>   	sys.exit(1)

How about deleting the file Documentation/target/tcm_mod_builder.py? I
don't think anyone is using this script. Additionally, it takes effort
to keep this script in sync with the rest of the SCSI target code. I'm
not sure anyone is interested in maintaining this script.

Thanks,

Bart.