Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 21 Jun 2023 09:35:43 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Thomas =?iso-8859-1?Q?Hellstr=F6m_=28Intel=29?= 
        <thomas_os@shipmail.org>, Sumitra Sharma <sumitraartsy@gmail.com>,
        Ira Weiny <ira.weiny@intel.com>
CC:     Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        <intel-gfx@lists.freedesktop.org>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        Fabio <fmdefrancesco@gmail.com>, "Deepak R Varma" <drv@mailo.com>
Subject: Re: [PATCH v2] drm/i915: Replace kmap() with kmap_local_page()
Message-ID: <649326df1b895_1c0dd29486@iweiny-mobl.notmuch>
References: <20230620180759.GA419158@sumitra.com>
 <79e1f37f-3ffa-0195-860b-08cc890d810e@shipmail.org>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <79e1f37f-3ffa-0195-860b-08cc890d810e@shipmail.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?4wLJSdcD0qdd10tl4d4V2nwgyB0gjN7Yn8E/Nrs+PeW+cQfhQzOFh0KpOr?=
 =?iso-8859-1?Q?0iGBI5XMJ6M+n09TOLnligAfiTNB0fLMSRmO1dH7N73YQs59KFFlyKha6l?=
 =?iso-8859-1?Q?uX33g48IzI1k5iYsrbjmVXMgpx9D9Yp1ATCc76GbYbyXOQFuu2r1YPydpK?=
 =?iso-8859-1?Q?o3MTnD7Gb572ucs8hhZAXKiTT0JeU52TwlGG2WLR9HZ3Urd8QN7QGetCy4?=
 =?iso-8859-1?Q?I06fJYsN9fdu3uKtMHiusTP7h89hVNV28pPma7JHxqHPX3Cd1zV3Ok0dBp?=
 =?iso-8859-1?Q?tCDDsZS8pE42D/cZtypJmqKXhdLl2SN5JK07oubqv0Qt65zEAUSyZsyUfn?=
 =?iso-8859-1?Q?hgp7y/6UTnQOZhezOvOi88fWhrFPAfphYmkkRI3ZGqLed/QTpbmNRc/Pmy?=
 =?iso-8859-1?Q?8X10yJbMIFo/3zHwQtVcyqUfn2QmhpID8vjHOD9MjshfAvbrBSyOfbAhZw?=
 =?iso-8859-1?Q?BcBGPB9YYoakog5BoakZe98+KLEIVe03UYspVRvKOerXtYYCnd6xwqqLZ3?=
 =?iso-8859-1?Q?5/x5cJfIPpt7tO/bWw6nj5+aLUGilUCoPO23G3SuzmMNlwxXAWQJhOZG79?=
 =?iso-8859-1?Q?DkGZwwweejfyJEnEEQQYTrDonDp1XN/kNVQBJ3ltwREiLtnpkuirDgXzPI?=
 =?iso-8859-1?Q?99/VhL3aG5xumYnxCRFx+yXNl+sRLbxLMCXTh8gP5YGKUwvC/ATwQ0deuW?=
 =?iso-8859-1?Q?KF66xopt///QY+SbxR4fO8A7yzwC2wBOJ5YcEKHFAsLXq+K6g/yDgw66oN?=
 =?iso-8859-1?Q?K+DYxuIgsnvbrA8Ixp2QZ9N56x1cJx7s9zi2rFwWlS/gzAaViA1g86Phpg?=
 =?iso-8859-1?Q?oHyk4T5t5vpjWu/3sEaXoscTfsgGwcMshNu6vNyHE9IKC5AoWfgsJsplhV?=
 =?iso-8859-1?Q?rIdhbr/CE/n1s9XVxv/sbB63VEI4MLAG0YDFppyBojfC1xjr9ayDYh7qfz?=
 =?iso-8859-1?Q?+P2hmkahkWKkjvLTIzTvDqJDTq4ZBacOGBB6S3X7xm7BKWsCAim5SYKCgl?=
 =?iso-8859-1?Q?+IFfnz/4BWhh8uNMXXdR8PdRZrNZ4I/lUblGl4HBd2p/+IlN3Q+FEfqyAW?=
 =?iso-8859-1?Q?2aJ4I1U9FUqAuIDXIXjSI6prGJTzQCGiUNQ/6HSWDvLRKYL9Em6GeEXhnq?=
 =?iso-8859-1?Q?lpgeW+0gZTRo2t8XDwS9jwfR/RWSNxYfcybfz2kr1j8JR3LaqrSDcPW/ye?=
 =?iso-8859-1?Q?PEDpgyhKheI3G+YzWJ6anXu9px5f86kbb+Eem7Zq04nz+0Hzmt/czyVOER?=
 =?iso-8859-1?Q?P6bH2iRApVorEloKdZo0G2VWVlIuYbc8XBDWtGnTUloIKKsH4hir7StdLf?=
 =?iso-8859-1?Q?Hb7yMJRuITxIQP7MZnppjlraewMSI9f//s1pQ+n9M7IsiUZUFr34m/cycR?=
 =?iso-8859-1?Q?TOqApGzU0xjHZ0pNsJcAvOz4DqygE4M+Xqf28ucHK/ZdHkvk0amL4QPXU4?=
 =?iso-8859-1?Q?93qG+1R3Xpzc+632NSihyrC7EDeyy2gDIg/5W6YJmwygSNWDzmtVMLQsEV?=
 =?iso-8859-1?Q?WVFSGLgB00yHpqzvFAUouYQXZs53NodCiiZ8T5UsXG+mu4DYPrZZr7GJ7O?=
 =?iso-8859-1?Q?zwuoS1xR0BKZMvn0IxfkmE5E0p7C0VP0sZPg4WnGKVL1D0Fo8GGgnWgB/x?=
 =?iso-8859-1?Q?qoZt9VlP4FXOj6TPhEPJGjeAyL8PSJEmxN?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b38ac795-bcde-42e6-460a-08db72759402
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2023 16:35:52.6687
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 55cTgIPdqj6RyrwGXRhjiR27xTP0lkaGruHrmGXcvks3uLu9T3OmEuUDc2eH2VGBB8Evwc4PA9WM2hv2PUvitA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7493
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thomas Hellstr?m (Intel) wrote:
> 
> I think one thing worth mentioning in the context of this patch is that 
> IIRC kmap_local_page() will block offlining of the mapping CPU until 
> kunmap_local(), so while I haven't seen any guidelines around the usage 
> of this api for long-held mappings, I figure it's wise to keep the 
> mapping duration short, or at least avoid sleeping with a 
> kmap_local_page() map active.
> 
> I figured, while page compression is probably to be considered "slow" 
> it's probably not slow enough to motivate kmap() instead of 
> kmap_local_page(), but if anyone feels differently, perhaps it should be 
> considered.

What you say is all true.  But remember the mappings are only actually
created on a HIGHMEM system.  HIGHMEM systems are increasingly rare.  Also
they must suffer such performance issues because there is just no other
way around supporting them.

Also Sumitra, and our kmap conversion project in general, is focusing on
not using kmap* if at all possible.  Thus the reason V1 tried to use
page_address().

Could we guarantee the i915 driver is excluded from all HIGHMEM systems?

> 
> With that said, my Reviewed-by: still stands.

Thanks!
Ira