Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761280AbXJRUwM (ORCPT ); Thu, 18 Oct 2007 16:52:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755454AbXJRUv6 (ORCPT ); Thu, 18 Oct 2007 16:51:58 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:52557 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754497AbXJRUv5 (ORCPT ); Thu, 18 Oct 2007 16:51:57 -0400 Date: Thu, 18 Oct 2007 22:51:47 +0200 From: Ingo Molnar To: Avi Kivity Cc: Andy Whitcroft , linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: latest checkpatch Message-ID: <20071018205147.GA1382@elte.hu> References: <20071015182118.GA4459@shadowen.org> <200710161759.l9GHxnkK012590@agora.fsl.cs.sunysb.edu> <20071017163916.GO21136@shadowen.org> <20071018111352.GA17039@elte.hu> <20071018192521.GC21136@shadowen.org> <20071018193929.GA22031@elte.hu> <4717BBD0.7070504@qumranet.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4717BBD0.7070504@qumranet.com> User-Agent: Mutt/1.5.14 (2007-02-12) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.1.7-deb -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 725 Lines: 25 * Avi Kivity wrote: > >> if (foo) > >> bar(); > >> baz(); > >> one(); > >> > > > > detecting that would be awesome - it's often the sign of a real bug > > because the intent is often to have bar() and baz() in the conditional > > block. > > This is more useful operating on an entire file, so the script can see > all the context. there's "checkpatch --file" for complete files, so it can see the full context if the user passes it in. Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/