Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a850fe4e-4f67-7209-4793-731f3d88f1f0@meta.com>
Date:   Wed, 21 Jun 2023 09:54:53 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.12.0
Subject: Re: [PATCH bpf-next v6 3/3] selftests/bpf: add testcase for TRACING
 with 6+ arguments
Content-Language: en-US
To:     menglong8.dong@gmail.com, alexei.starovoitov@gmail.com
Cc:     ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
        martin.lau@linux.dev, song@kernel.org, yhs@fb.com,
        john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
        haoluo@google.com, jolsa@kernel.org, benbjiang@tencent.com,
        bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
        Menglong Dong <imagedong@tencent.com>
References: <20230619114947.1543848-1-imagedong@tencent.com>
 <20230619114947.1543848-4-imagedong@tencent.com>
From:   Yonghong Song <yhs@meta.com>
In-Reply-To: <20230619114947.1543848-4-imagedong@tencent.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a2xNQUZiL29KOFp0Y2R0ZERleUhPZ1QyWGFHalBrUjMvOFdLVzk3Z2hha240?=
 =?utf-8?B?eTdLczFWRmtvZ0Z3NHNtR0ZlUnVCcXFxb21ZMXJiaHRTRE50dElVR0N4V3Q0?=
 =?utf-8?B?dTc0Q1RRL2NQVjhDU1hDb3BBWDVpSlJDd3ErbE5adnpBWjRQVjBnc1JzVFVE?=
 =?utf-8?B?Uit6S0phVko2STVpZmhIMlVZZmZWbU1tSUdRUDVET0RkYndFMGJ3eU5iVGhl?=
 =?utf-8?B?cUFIOVFTRlhuc01ONGJDSkVyZ3oxT1RXVk9ONkpGTmZyMHlLRDB4d1dGdEJP?=
 =?utf-8?B?OGZSWGpzMlZRNFM4THp2aHVlazNoNkZ6aEpzQjVtdXB1eVBzS3dmV2RTaXh5?=
 =?utf-8?B?ejlpR0MxMVhyUnBXWWxPc1JIc3o2bUJRbDNsUVQrT1Vlb1dmTWQ0MXUrSUFL?=
 =?utf-8?B?TE9jZ1RlSlZqVDkxREtwZlB5UVNNY2k1ckNObHBxV1BNRW5RYURuQm5Nencr?=
 =?utf-8?B?R2I0STcyc1lqY3ppdEhTYW10SzFCYUxLWlZhNmxORlFTZ2YzNEpIWlRvSnJX?=
 =?utf-8?B?VVAxR09MemhXRmlPZmxxRGZGd1lpSHVKL2dBeFRFUXpwUkp5RExIbUhKZTZZ?=
 =?utf-8?B?TFBuZ2drYkpLUHlENzhjT2lUdzV3QnJVTGRDS2pxaWZsMGh0c1FHektUdXF1?=
 =?utf-8?B?QXh0UzNxWUdFdGJFYVU2TUl4c3pQdlphZ0s5dVRoTW0xTkVqZWQ2WmNDR2s4?=
 =?utf-8?B?NVIzTVdmQVN5RkxQdE81RFExQytoL3V5bzQ0azlmekdoQy9XcFBzZTFNM2Zw?=
 =?utf-8?B?YTZyRCtiZlFpS3UrQ0xKbFlMdkVQRDVTLzJzLyt3Rmx5M3Z0U0dRTXRxODdl?=
 =?utf-8?B?TGhqK0xDWUlQLzBCV1M1bEYzOG5yWS8yZFljTmN1ZkVLbTI5aG1jQk9ZZGxa?=
 =?utf-8?B?TWNPQm1XZXdIa2FBajNETXU4c2pidkVjUGtwMEQxQVlKRHg1aWIwZmhMNCtw?=
 =?utf-8?B?dmM5ajVYZUFvOStzRHZrYkhjTko2UUxJb2NIaGZWdzlIc3g1YkNMcHh4bWhy?=
 =?utf-8?B?UGJLSmFQSkRIMDVicWl0QktPNWhiTXVvdDJEL2Zuc1ZDeG9McExKUTFLOU1H?=
 =?utf-8?B?ZHkvYXAzUjJSKzYwTitpZmxsTTBpVDQvNHNLNlQ3djJnRFpVak5wZUJXS0FS?=
 =?utf-8?B?YzdjelZlVmFibWl0Yk1adnN4VTBOcFhFdUlVN0psZkZUbFN0NEE1dWxQSUJz?=
 =?utf-8?B?dkRlRkRJUmo3K3MxU1FxMm4rNFJjQjJBVjZTcnc0alJWVUR5VWVSWmxTZnFx?=
 =?utf-8?B?UVVoN1lNbWdkY3doYWR2dHVyY1FtT3NLNHAyL2QzdVJYQTNZVEFYaVhBTjdW?=
 =?utf-8?B?L3ErZHkveW1CbElPUmk4NHJYWCt4bXhrbFZpbkhwcklMdUlPRFc3cW5FSVg3?=
 =?utf-8?B?b2tBV0pJN1ZIRkZNbS9sY2pnYXprcnBaZHJYMDhTbkk2d1BhOTdrdnRHamdJ?=
 =?utf-8?B?bWJjL0dSa2J4b2N5cE5QRVhVbVEyV3lmZUFOQStvaTg2SGRLZ3YzNjhkWDFN?=
 =?utf-8?B?aGdJQVgzMG5PNDR1aHRrWFl5SDFPN3Jpdm82TnhYWFJOT1l5QUt5c2sybUJB?=
 =?utf-8?B?NWlUbS9VeVV2YXAxMjAzMFFSL2owWUl4aFEyV1lFMGtXWkFITlFXcUIxWTJS?=
 =?utf-8?B?MXprS1ZXb1l5ZzNHajJSeEJVWWllaTdQZFdGNUpPVFRBaEhGM05zZnJGTWpX?=
 =?utf-8?B?bG5aUm5Mb2k1dy92ekZiSWxFcnpxV1lTbHFkclhKd0J0R2F5eW0wWTV3eFFo?=
 =?utf-8?B?TnZNQW9TdFFpUjRQOElEUUE3R1Y2T1hWNTFvcXM4TFlRK2FrSkkxb0d0YmZR?=
 =?utf-8?B?UUhVU3pkYzdFY29vc20wNDV2MVBZbG5VYzdSTWU2NFppd1RoNXIyalF3VzhW?=
 =?utf-8?B?cHkvdmtIckdIWFJBZlNOaGJzN0JacFprZEUzUlc3YjFmTWc3VHNHWVk2ZzhW?=
 =?utf-8?B?emJNVmQ3Yk5POEM5TzJiSVB5bzFvbjFSbmhwRzBzK0JKU3RpcXZ1SnRSUDR0?=
 =?utf-8?B?bXYrbm1oVFpuNWp0eXdLT013T3Z2QzVreFZTM05MUDM2YVIvRmFBT1QvU0xw?=
 =?utf-8?B?K0N1NkZ2VklKclV0VUJta21kSGllcEpseVo5bXJlY3hvKzBwNG4vbFlGeXNq?=
 =?utf-8?B?SkhVVlhBNXdvVG9MTWdqMXIxRndMSEp4YmlRTC9LNFF2WWh1emE4NzdOVVNt?=
 =?utf-8?B?RkE9PQ==?=
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cf25864a-61e1-4fd5-f71b-08db72783e61
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2023 16:54:57.2877
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fOp2DNqAn522Iibatwg5rFYNvra5hiCba/1R0gnbhoMX3R4vqE+ed3x1NuLuGgnG
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR15MB3788
X-Proofpoint-GUID: uFjiFVECl3_H_NDEdea20NfelUgQ2r45
X-Proofpoint-ORIG-GUID: uFjiFVECl3_H_NDEdea20NfelUgQ2r45
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-06-21_10,2023-06-16_01,2023-05-22_02
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/19/23 4:49 AM, menglong8.dong@gmail.com wrote:
> From: Menglong Dong <imagedong@tencent.com>
> 
> Add test9/test10 in fexit_test.c and fentry_test.c to test the fentry
> and fexit whose target function have 7/11 arguments.
> 
> Correspondingly, add bpf_testmod_fentry_test7() and
> bpf_testmod_fentry_test11() to bpf_testmod.c
> 
> Meanwhile, add bpf_modify_return_test2() to test_run.c to test the
> MODIFY_RETURN with 7 arguments.
> 
> Add bpf_testmod_test_struct_arg_7/bpf_testmod_test_struct_arg_7 in
> bpf_testmod.c to test the struct in the arguments.
> 
> And the testcases passed:
> 
> ./test_progs -t fexit
> Summary: 5/12 PASSED, 0 SKIPPED, 0 FAILED
> 
> ./test_progs -t fentry
> Summary: 3/0 PASSED, 0 SKIPPED, 0 FAILED
> 
> ./test_progs -t modify_return
> Summary: 1/0 PASSED, 0 SKIPPED, 0 FAILED
> 
> ./test_progs -t tracing_struct
> Summary: 1/0 PASSED, 0 SKIPPED, 0 FAILED
> 
> Signed-off-by: Menglong Dong <imagedong@tencent.com>

Acked-by: Yonghong Song <yhs@fb.com>