Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 21 Jun 2023 18:18:29 +0100
From:   Lee Jones <lee@kernel.org>
To:     baomingtong001@208suo.com
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: sm501: prefer unsigned int over unsigned
Message-ID: <20230621171829.GN10378@google.com>
References: <20230613082016.28701-1-luojianhong@cdjrlc.com>
 <25f84d945d94832e8d6b295cff004439@208suo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <25f84d945d94832e8d6b295cff004439@208suo.com>
Precedence: bulk

On Tue, 13 Jun 2023, baomingtong001@208suo.com wrote:

> 
> Fix the following coccicheck warning:
> 
> drivers/mfd/sm501.c:887: Prefer 'unsigned int' to bare use of 'unsigned'.
> 
> Signed-off-by: Mindtong Bao <baomingtong001@208suo.com>
> ---
>  drivers/mfd/sm501.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This patch did not make it to the upstream mailing list (LKML).

  https://lore.kernel.org/all/?q=%22mfd%3A+sm501%3A+prefer+unsigned+int+over+unsigned%22

I cannot take it unless it shows up there first.

Please debug this and resend.

> diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
> index 28027982cf69..f08ad7249dc5 100644
> --- a/drivers/mfd/sm501.c
> +++ b/drivers/mfd/sm501.c
> @@ -884,7 +884,7 @@ static inline struct sm501_devdata
> *sm501_gpio_to_dev(struct sm501_gpio *gpio)
>      return container_of(gpio, struct sm501_devdata, gpio);
>  }
> 
> -static int sm501_gpio_get(struct gpio_chip *chip, unsigned offset)
> +static int sm501_gpio_get(struct gpio_chip *chip, unsigned int offset)
> 
>  {
>      struct sm501_gpio_chip *smgpio = gpiochip_get_data(chip);

-- 
Lee Jones [李琼斯]