Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230614021505.59856-1-yangjihong1@huawei.com>
In-Reply-To: <20230614021505.59856-1-yangjihong1@huawei.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Wed, 21 Jun 2023 10:22:47 -0700
Message-ID: <CAM9d7cjqim4iyBKU1ob3uYXbycQTJ1f-XEL1fCQpiKDMirEuFQ@mail.gmail.com>
Subject: Re: [PATCH v3] perf stat: Add missing newline in pr_err messages
To:     Yang Jihong <yangjihong1@huawei.com>
Cc:     peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
        mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
        jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        james.clark@arm.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Tue, Jun 13, 2023 at 7:16 PM Yang Jihong <yangjihong1@huawei.com> wrote:
>
> The newline is missing for error messages in add_default_attributes()
>
> Before:
>
>   # perf stat --topdown
>   Topdown requested but the topdown metric groups aren't present.
>   (See perf list the metric groups have names like TopdownL1)#
>
> After:
>
>   # perf stat --topdown
>   Topdown requested but the topdown metric groups aren't present.
>   (See perf list the metric groups have names like TopdownL1)
>   #
>
> In addition, perf_stat_init_aggr_mode() and perf_stat_init_aggr_mode_file()
> have the same problem, fixed by the way.
>
> Signed-off-by: Yang Jihong <yangjihong1@huawei.com>
> Acked-by: Ian Rogers <irogers@google.com>
> Reviewed-by: James Clark <james.clark@arm.com>

Applied to perf-tools-next, thanks!