Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp9704287rwd; Wed, 21 Jun 2023 10:40:49 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7DLWdzXK7dW3gbDF56GzImNLLkvYMdwQd/vlmezkHUdEsRpL8LXLTldyR8QSPv0DEKCIGH X-Received: by 2002:a17:902:ce87:b0:1b5:6312:4c5b with SMTP id f7-20020a170902ce8700b001b563124c5bmr8504728plg.63.1687369249238; Wed, 21 Jun 2023 10:40:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687369249; cv=none; d=google.com; s=arc-20160816; b=piK8vvMIrgKwKuA3gbTKiIEESJ6LCXmpZnuYFA5/jDKybzyGzfKZteTbcn/8VQqciX a3KZU/u/PzkqBdf3DiP/dbRNvbEoNeONpvWEJyMDxekpFqpyNq/OXJcjZFr/xjWJK7SP hM5O1U7emtsiwVNUSrRAM52fCaAn4b+xKEHfkQBX5FV98KPWjwa76pIPlObCJ5ou473S KmJuyXFz/Guy+Oi9EQjTxCd2Vga9c7QloNn8RQXotqlMmO3665HYL2Vn/BL/nvBPFflN V7btERlYaR10XkN/cQksdriEhSdaFq4lLQzUcC+yqd3hy4BsjS49BbEnICtSLmWPw2xj kYRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version; bh=Urj9CwEIeG1Jb/YMojIhG+Aq56vrYpA4tDlDsapBWwE=; b=fVt5e//qbBuqXcr5g19iCttDos3X3kqgWXFCA7/w/aY7QUCy2s+zxllye5EkUm53TH VovQnOHogya3XyXDmbkB/34qmxtZkp+8CBxDSRTSygKKPMBXN+PZ1kkHfI7gjfW+JPNX 791k6+WSTPOKeIoqegB0IMK4vZ6PIV/koUX3Lbk2iapXeB4s34PP/mOPhXN3o74bpXi8 XoIH3pvBOaQWTaC1PZeB9fTXGdKSco3uKawP2clhKR72Ow/z2GBudt7zOLwWJXRgcbST +8971Uaafd5UattA30Lb72D0LO+ifSozsytA0+53wZItzPAbJt10NSj55VaKjfxmK74o v7cw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k10-20020a170902c40a00b001b23b699747si5390050plk.10.2023.06.21.10.40.35; Wed, 21 Jun 2023 10:40:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231147AbjFUR3N convert rfc822-to-8bit (ORCPT + 99 others); Wed, 21 Jun 2023 13:29:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229507AbjFUR3M (ORCPT ); Wed, 21 Jun 2023 13:29:12 -0400 Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45D1EE2; Wed, 21 Jun 2023 10:29:11 -0700 (PDT) Received: by mail-yb1-f171.google.com with SMTP id 3f1490d57ef6-bb2ffa1e235so5942527276.0; Wed, 21 Jun 2023 10:29:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687368550; x=1689960550; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sHKJ5E4QyaneB9JDT8DwEZgyuTNCEA7MDDSg1wRoMEI=; b=EF02C/IqTEdWvGevmILr5zJtLS27nm5s3cGXmsx1zeBnWpqby5fXoDRb8UVWZNwR5N L9B54+su2lQ2ojI7er/qQ585bbS3DGpIpZV92qZQztUInbcuDnSPMhNMtqT9EcAvSkxW agok7YmSnYMTHSQEznQjaPok1nniOHgGWGy9FFBPipCajH5BAiII3oK0iiXlJZ4ARPXy Yp7422E0F2teNauvOIjQqo2TpeAMOJQg643iRtPcQb6Pds241VBPEI69iwMPelEU7XZO zIWwhv2SqejzNY4PDrCMw29J+OLixJMkheStNOfWsFj19JuaYqUbP1ii0FvDlpkb52YJ szOg== X-Gm-Message-State: AC+VfDzCeDmrvDYASfsptTK4WluQ2OibL5Xt51JyZ3y3UlK+ENH+gEX3 PxYV2X4DpAIlAt9gchi6dzO/By47VpvBYm6qO64= X-Received: by 2002:a25:b1a3:0:b0:bca:531d:dcde with SMTP id h35-20020a25b1a3000000b00bca531ddcdemr11934138ybj.30.1687368550410; Wed, 21 Jun 2023 10:29:10 -0700 (PDT) MIME-Version: 1.0 References: <20230620132025.105563-1-wangrui@loongson.cn> In-Reply-To: <20230620132025.105563-1-wangrui@loongson.cn> From: Namhyung Kim Date: Wed, 21 Jun 2023 10:28:59 -0700 Message-ID: Subject: Re: [PATCH] perf annotate: Fix instruction association and parsing for LoongArch To: WANG Rui Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Huacai Chen , loongarch@lists.linux.dev, Tiezhu Yang , WANG Xuerui , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, loongson-kernel@lists.loongnix.cn Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 20, 2023 at 6:21 AM WANG Rui wrote: > > In the perf annotate view for LoongArch, there is no arrowed line > pointing to the target from the branch instruction. This issue is > caused by incorrect instruction association and parsing. > > $ perf record alloc-6276705c94ad1398 # rust benchmark > $ perf report > > 0.28 │ ori $a1, $zero, 0x63 > │ move $a2, $zero > 10.55 │ addi.d $a3, $a2, 1(0x1) > │ sltu $a4, $a3, $s7 > 9.53 │ masknez $a4, $s7, $a4 > │ sub.d $a3, $a3, $a4 > 12.12 │ st.d $a1, $fp, 24(0x18) > │ st.d $a3, $fp, 16(0x10) > 16.29 │ slli.d $a2, $a2, 0x2 > │ ldx.w $a2, $s8, $a2 > 12.77 │ st.w $a2, $sp, 724(0x2d4) > │ st.w $s0, $sp, 720(0x2d0) > 7.03 │ addi.d $a2, $sp, 720(0x2d0) > │ addi.d $a1, $a1, -1(0xfff) > 12.03 │ move $a2, $a3 > │ → bne $a1, $s3, -52(0x3ffcc) # 82ce8 > 2.50 │ addi.d $a0, $a0, 1(0x1) > > This patch fixes instruction association issues, such as associating > branch instructions with jump_ops instead of call_ops, and corrects > false instruction matches. It also implements branch instruction parsing > specifically for LoongArch. With this patch, we will be able to see the > arrowed line. > > 0.79 │3ec: ori $a1, $zero, 0x63 > │ move $a2, $zero > 10.32 │3f4:┌─→addi.d $a3, $a2, 1(0x1) > │ │ sltu $a4, $a3, $s7 > 10.44 │ │ masknez $a4, $s7, $a4 > │ │ sub.d $a3, $a3, $a4 > 14.17 │ │ st.d $a1, $fp, 24(0x18) > │ │ st.d $a3, $fp, 16(0x10) > 13.15 │ │ slli.d $a2, $a2, 0x2 > │ │ ldx.w $a2, $s8, $a2 > 11.00 │ │ st.w $a2, $sp, 724(0x2d4) > │ │ st.w $s0, $sp, 720(0x2d0) > 8.00 │ │ addi.d $a2, $sp, 720(0x2d0) > │ │ addi.d $a1, $a1, -1(0xfff) > 11.99 │ │ move $a2, $a3 > │ └──bne $a1, $s3, 3f4 > 3.17 │ addi.d $a0, $a0, 1(0x1) > > Signed-off-by: WANG Rui Applied to perf-tools-next, thanks!