Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp9717469rwd; Wed, 21 Jun 2023 10:52:15 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4hfEd6ShTABU4AbntYb9fIIC7uUBZW2mNsAyPVYDUe/ejVR8xORrsu2ETj/XvzQJp7rxmj X-Received: by 2002:a17:902:8689:b0:1b6:702b:11e with SMTP id g9-20020a170902868900b001b6702b011emr6888591plo.8.1687369934890; Wed, 21 Jun 2023 10:52:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687369934; cv=none; d=google.com; s=arc-20160816; b=LXQqN6mD2qDF7akWCrmiVR/fiz7s5TZJOw6t5X+1CRLxu7Wbi5NBo1MeUVWgo6odfW xBRuUcs8xq0xWESVaai1pfxBI1W/l0AZl2mCUCKnw4nGxe/eGQLuxzpkuvLDl0Zob7pa EQ1RkOcqepQ75seUqUOutkOSAvQsnCDytNNKFmPgfzTMV5qdKCaF1Q+xoLSRYQZnr0R2 8MDRMtt5zlGZU5w+1HamxsOBk1AIDZdi1bQ8bJKmxQYd4wg7eUg6eWWuue823P+yLRDK VztCEYK4PkIt+hLAHb7M9JIkq6p+2jlmdzj3bHkM0fweqJxiJy1UjFuqZssrEjwgarZ5 BFSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version; bh=bw2hzO0E99XhlN7ipSec3E59L5wuonuWacFMTWRYmHI=; b=jUv2x0f+kMRw+YTq5Ew5KjS+WiqiCU29t/LU/ystjP9DjM1fvZZ5AuYsVizIDG9ZOh +odl9Sxt88qrS7hLw3HHTKY2z2o9L1P7CpS4hxKmgs3uulk81iPi5/y7ANOAc4HQB/61 LF+f1avvqEadKwrl7yGPeNui/4OJrSt/yPx+xjOx6Hna5Grxto4VbXxQzLj3jO3t2T2r YPMKu9r1ZscFDpY10jIX4mvt/3yz2Gkz6YT1GNmZ0P7NcSwkYk0vKr+qtiTCzEaFDKA7 isF8HYkI1uG8vFU7cEkolSPRnbupwFZxpJOYkOM3N9grTUCGp84LmRb7pkyw2m9/PWrV CmWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q9-20020a170902788900b001b58767a0f7si4451721pll.60.2023.06.21.10.52.02; Wed, 21 Jun 2023 10:52:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231153AbjFUR1Q convert rfc822-to-8bit (ORCPT + 99 others); Wed, 21 Jun 2023 13:27:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231149AbjFUR1L (ORCPT ); Wed, 21 Jun 2023 13:27:11 -0400 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9866110A; Wed, 21 Jun 2023 10:27:09 -0700 (PDT) Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-6b13e2af122so4715219a34.2; Wed, 21 Jun 2023 10:27:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687368428; x=1689960428; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6MhTlH8vHzbFj0GHoNEXbCWkZrmdxXHp7k0D25qpFIY=; b=iSM4ymv1QQf9c87PTCPEKNxLg0B0Eyx+OpgM4K9bVTIHNTD7sjXRkKPhvmzstro36W y5qyMHeQy/mVzVC6Nvfp0b6T0kkYAT/yXnj4mZdPnMjDIrCd96ZLXTCR1DDTqghKy2Iy QsPmXVUU88y6/UwQXFsQvMbAEx8FkRDH/alOoy/nv7rrdxxHcScoyMlTYnlVV4sQ5abu DtBCurYhkPMQ9T/EBdYllFHRy3GuUB+062ZpTO4mB1xL3orxeTUtWN/wd4OiSjdaSGV7 com8ksYlmJOd0WEkdN8Hxk4cBUDDqRG87BNX/NS743YD5+8Iwl/z7AaH3V6XqxudcVYm 55lA== X-Gm-Message-State: AC+VfDxDunpY9RKY4GcZWO1iG99yCOhdBhXgcV1K4vByKIKqvh71KDJL TdNGnGxDGCCdDfAgdgJmPzDzzgO0cdajxvjd6VQ= X-Received: by 2002:a05:6359:c07:b0:12e:32a1:d83e with SMTP id gn7-20020a0563590c0700b0012e32a1d83emr7478466rwb.23.1687368428516; Wed, 21 Jun 2023 10:27:08 -0700 (PDT) MIME-Version: 1.0 References: <20230619082036.410-1-lidong@vivo.com> In-Reply-To: From: Namhyung Kim Date: Wed, 21 Jun 2023 10:26:57 -0700 Message-ID: Subject: Re: [PATCH] tools: Fix incorrect calculation of object size by sizeof To: Arnaldo Carvalho de Melo Cc: Li Dong , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Sean Christopherson , "open list:PERFORMANCE EVENTS SUBSYSTEM" , "open list:PERFORMANCE EVENTS SUBSYSTEM" , opensource.kernel@vivo.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 20, 2023 at 3:42 PM Namhyung Kim wrote: > > Hi Arnaldo, > > On Tue, Jun 20, 2023 at 3:06 PM Arnaldo Carvalho de Melo > wrote: > > > > > > > > On Tue, Jun 20, 2023, 3:19 PM Namhyung Kim wrote: > >> > >> Hello, > >> > >> On Mon, Jun 19, 2023 at 1:21 AM Li Dong wrote: > >> > > >> > What we need to calculate is the size of the object, not the size of the > >> > pointer. > >> > > >> > Signed-off-by: Li Dong > >> > >> Since this problem was introduced in the current dev cycle and not in the > >> mainline yet, I think we can skip the Fixes tag. > >> > >> Acked-by: Namhyung Kim > > > > > > I think we should have it anyway, if not for the stable guys to pick it up, for documentation sake :-) > > Ok, I'll add that. Thanks for the reply while on your vacation. :) Applied to perf-tools-next with the below tag, thanks! Fixed: 51cfe7a3e87e ("perf python: Avoid 2 leak sanitizer issues")