Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230621065839.635809-1-tero.kristo@linux.intel.com>
In-Reply-To: <20230621065839.635809-1-tero.kristo@linux.intel.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Wed, 21 Jun 2023 19:44:12 +0200
Message-ID: <CAJZ5v0j8nebEAjC3L--Dz-2UkHUDAPxMTJ5P2zAh+=yVW4ASyg@mail.gmail.com>
Subject: Re: [PATCH] cpufreq: intel_pstate: Fix energy_performance_preference
 for passive
To:     Tero Kristo <tero.kristo@linux.intel.com>
Cc:     rafael@kernel.org, viresh.kumar@linaro.org,
        srinivas.pandruvada@linux.intel.com, lenb@kernel.org,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Niklas Neronin <niklas.neronin@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Wed, Jun 21, 2023 at 8:59 AM Tero Kristo <tero.kristo@linux.intel.com> wrote:
>
> If the intel_pstate driver is set to passive mode, then writing the
> same value to the energy_performance_preference sysfs twice will fail.
> This is caused by the wrong return value used (index of the matched
> energy_perf_string), instead of the length of the passed in parameter.
> Fix by forcing the internal return value to zero when the same
> preference is passed in by user. This same issue is not present when
> active mode is used for the driver.
>
> Fixes: f6ebbcf08f37 ("cpufreq: intel_pstate: Implement passive mode with HWP enabled")
> Reported-by: Niklas Neronin <niklas.neronin@intel.com>
> Signed-off-by: Tero Kristo <tero.kristo@linux.intel.com>
> ---
>  drivers/cpufreq/intel_pstate.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 2548ec92faa2..f29182512b98 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -824,6 +824,8 @@ static ssize_t store_energy_performance_preference(
>                         err = cpufreq_start_governor(policy);
>                         if (!ret)
>                                 ret = err;
> +               } else {
> +                       ret = 0;
>                 }
>         }
>
> --

Applied as 6.5 material, thanks!