Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 21 Jun 2023 17:47:48 +0000
To:     lee@kernel.org
From:   Raymond Hackley <raymondhackley@protonmail.com>
Cc:     devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
        luca@z3ntu.xyz, pavel@ucw.cz, raymondhackley@protonmail.com,
        robh+dt@kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible
Message-ID: <20230621174735.1161-1-raymondhackley@protonmail.com>
In-Reply-To: <20230621150141.GE10378@google.com>
References: <20230602130644.259933-1-raymondhackley@protonmail.com> <20230602131009.260239-1-raymondhackley@protonmail.com> <20230621150141.GE10378@google.com>
Feedback-ID: 49437091:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Lee,

On Wednesday, June 21st, 2023 at 3:01 PM, Lee Jones <lee@kernel.org> wrote:


> On Fri, 02 Jun 2023, Raymond Hackley wrote:
>=20
> > Add devicetree binding for Richtek RT5033 Flash LED charge pump used fo=
r
> > camera flash LEDs.
> >=20
> > Signed-off-by: Raymond Hackley raymondhackley@protonmail.com
> > ---
> > Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >=20
> > diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b=
/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > index 4d2ffe5fcfc7..37d2a93780ab 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > @@ -20,6 +20,7 @@ properties:
> > compatible:
> > enum:
> > - ocs,ocp8110
> > + - richtek,rt5033-led
>=20
>=20
> Why is "-led" appended on to this one and not the others?
>=20

"richtek,rt5033" has already been taken by a MFD device, and this LED is
a part of rt5033 MFD, so "-led" is appended here.

> > - sgmicro,sgm3140
> >=20
> > enable-gpios:
> > --
> >=20
> > 2.30.2

I tried to configure protonmail not to send encrypted mails.
Hope that it works for you.

Regards,
Raymond