Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763329AbXJRVss (ORCPT ); Thu, 18 Oct 2007 17:48:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757354AbXJRVsl (ORCPT ); Thu, 18 Oct 2007 17:48:41 -0400 Received: from cantor.suse.de ([195.135.220.2]:55994 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755874AbXJRVsk (ORCPT ); Thu, 18 Oct 2007 17:48:40 -0400 Date: Thu, 18 Oct 2007 23:48:37 +0200 From: Andi Kleen To: Andrew Morton Cc: Bernhard Walle , linux-kernel@vger.kernel.org, kexec@lists.infradead.org, ak@suse.de, vgoyal@in.ibm.com Subject: Re: [patch 1/3] Add BSS to resource tree Message-ID: <20071018214836.GA3459@bingen.suse.de> References: <20071018111535.356215664@strauss.suse.de> <20071018111535.883533731@strauss.suse.de> <20071018142642.5b3f6ba4.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071018142642.5b3f6ba4.akpm@linux-foundation.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 560 Lines: 14 > > +extern char _text[], _end[], _etext[], _edata[], _bss[]; > > These should be in a header file. Normally the "no externs in .c" rule doesn't apply to assembler or linker script defined labels. That's because the point of the header file is to type check them, but there is nothing to type check here. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/