Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp9902178rwd; Wed, 21 Jun 2023 13:27:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ78bzrGX3I+XWdDHG18rm11RfPy9m1jBMiON7Vm72M2EWcR+cNPIWYBa0VaKP6BmHT2jcm/ X-Received: by 2002:a05:6830:1618:b0:6b5:e816:b650 with SMTP id g24-20020a056830161800b006b5e816b650mr693586otr.25.1687379226687; Wed, 21 Jun 2023 13:27:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687379226; cv=none; d=google.com; s=arc-20160816; b=q8YrJHHDIidPeyTnvcFm1n5Jjz2UUcW/oGGT0BkBEiDGCwlXiQYrSjYzi73Vw1Jhx5 Nm0ATKIog9/Cvf1jdk2FMb9mL3z4bCmxHJJFaGaUyf+0DObAaenYfqY7X3ywOVH46ZIL ddWISUEXs0xw2Xc9McZ2npv3POruP1yFEBTZmGqnrKmyLP+jkpnWJ0rK4mDbnKjtBOvB i5EXyPkw5iST9V92bN9WyNSI5dhlA3tI3iscnXj26PRazc4KT4cQixZecCnMo5Z4mzRE y1ZAm2FqHwhPsrDYce+h+wGSnWMFhP0EuZyJzAaHEOE6zIij9LnLljJW26HN+cX8n9uT Kwzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=WuUybQbPOcjVIbT2CwJemUnUwwfspN2YLMZ5n+okRSc=; b=Qr0Tx00dI+6BcYi8m3Pms7TO+Z3+3Zoa326xkZz4IlaTF85QVcABd3d3NFxjUo4N7V Ubi+RFSiNSS9WGLeHTTwMd1O5zolkEjdE9BudoDe+JPWY0BI3HHmpaQBfcH8s168PUnd WSmggwthmPNjaKNNFXDwd8XpQ/8W08A1ZYAKKtWOCzJbuxx5T1hnuMYLohagZ36eqVZn H3CpirrNxfB/bMDWj2jnMpBo4wlB4y+syPW8no3tVmMbwfz998Ln5nb1tcaT4qA8e7G7 2c7SXgJ68zEwL+flXH+SmPArV0C3n65Jl5UkZ97bh5VbidwCndYBS/QsoorC06JLEeBl Qmow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lbsWLd82; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q188-20020a632ac5000000b00543e3449f28si4791233pgq.616.2023.06.21.13.26.54; Wed, 21 Jun 2023 13:27:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lbsWLd82; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230323AbjFUUOQ (ORCPT + 99 others); Wed, 21 Jun 2023 16:14:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229961AbjFUUOO (ORCPT ); Wed, 21 Jun 2023 16:14:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AE05199E for ; Wed, 21 Jun 2023 13:14:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7E094616C2 for ; Wed, 21 Jun 2023 20:14:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 980C9C433C8; Wed, 21 Jun 2023 20:14:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687378452; bh=dCDy3A/rSNHdhp/mXd4huyXQOqZFkZsHTIPIxDQhj1o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lbsWLd827a+PxMQHbt38u8IpyWB5Z0MoDwCAqH7tAxr6C8D2NtuYuQ7jWmhUegU0C 32AXpzlJNA53IP9fqpkriSMSrSnVgZ1h7Bx85DFPLNXyEFBKWWXz+e0g+c9H3RM8Py OLr5T1WjcA2ofwM3UmTxVfnFhbjZiXZrkW2+IVnCBhm+otwXbeGqzyMuRAqG6CEGhK 0/WQFLgOJyMV66NNAC64hLUKF+bz9JaJqA4e/DCf47l88Vaj90fzb/eSsyHo/qz523 CFBP5/2/cWggjNwYt9LRZ4PIVdbSLnCqtG55uEC9tqd2eXBtQUBcAFFWbUbFjbaoIP mbPmVg3jJ3s5w== Date: Wed, 21 Jun 2023 13:14:11 -0700 From: Jakub Kicinski To: Eric Dumazet Cc: syzbot , Johannes Berg , bpf@vger.kernel.org, davem@davemloft.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [net?] possible deadlock in netlink_set_err Message-ID: <20230621131411.6be73cc6@kernel.org> In-Reply-To: References: <000000000000e38d1605fea5747e@google.com> <20230621124246.07f9833c@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Jun 2023 22:05:13 +0200 Eric Dumazet wrote: > > Doesn't seem like netlink_set_err() wants to be called from just any > > context. Should we convert nl_table_lock to alwasy be _bh ? > > > > Jakub I already sent a fix : > > https://patchwork.kernel.org/project/netdevbpf/patch/20230621154337.1668594-1-edumazet@google.com/ Ah, I didn't spot it, LG!