Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 21 Jun 2023 15:29:11 -0500
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     Rob Herring <robh@kernel.org>
Cc:     Lizhi Hou <lizhi.hou@amd.com>, Bjorn Helgaas <bhelgaas@google.com>,
        linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, max.zhen@amd.com,
        sonal.santan@amd.com, stefano.stabellini@xilinx.com
Subject: Re: [PATCH V9 0/6] Generate device tree node for pci devices
Message-ID: <20230621202911.GA116530@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230620220818.GA418170-robh@kernel.org>
Precedence: bulk

On Tue, Jun 20, 2023 at 04:08:18PM -0600, Rob Herring wrote:
> On Thu, Jun 15, 2023 at 09:50:36AM -0700, Lizhi Hou wrote:
> > This patch series introduces OF overlay support for PCI devices which
> > primarily addresses two use cases. First, it provides a data driven method
> > to describe hardware peripherals that are present in a PCI endpoint and
> > hence can be accessed by the PCI host. Second, it allows reuse of a OF
> > compatible driver -- often used in SoC platforms -- in a PCI host based
> > system.

> >  drivers/of/dynamic.c                          | 164 ++++++++++++++
> >  drivers/of/overlay.c                          |  42 +++-
> >  drivers/of/unittest-data/Makefile             |   3 +-
> >  .../of/unittest-data/overlay_pci_node.dtso    |  22 ++
> >  drivers/of/unittest.c                         | 210 +++++++++++++++++-
> >  drivers/pci/Kconfig                           |  12 +
> >  drivers/pci/Makefile                          |   1 +
> >  drivers/pci/bus.c                             |   2 +
> >  drivers/pci/of.c                              |  81 ++++++-
> >  drivers/pci/of_property.c                     | 190 ++++++++++++++++
> >  drivers/pci/pci.h                             |  19 ++
> >  drivers/pci/quirks.c                          |  12 +
> >  drivers/pci/remove.c                          |   1 +
> >  include/linux/of.h                            |  25 ++-
> >  14 files changed, 768 insertions(+), 16 deletions(-)
> >  create mode 100644 drivers/of/unittest-data/overlay_pci_node.dtso
> >  create mode 100644 drivers/pci/of_property.c
> 
> Bjorn, I think this is pretty close to being in shape for merging. Do 
> you have any comments on the PCI bits? Would you prefer that I ack the 
> DT bit and you take it or vice-versa?

I acked the PCI bits (modulo some trivial comments), and this seems
more DTish than PCIish, so happy if you would take them.

Bjorn