Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp9932294rwd; Wed, 21 Jun 2023 13:56:02 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5WBr47udxneJuvAeZVvH7pR2lfxjje6fYQtJq+0DVml8asj4UYfZthD5EwOd5B+ZNV7hkA X-Received: by 2002:a17:902:ced0:b0:1b5:25f8:2160 with SMTP id d16-20020a170902ced000b001b525f82160mr19501193plg.30.1687380962526; Wed, 21 Jun 2023 13:56:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687380962; cv=none; d=google.com; s=arc-20160816; b=SDxZDcYoM0rZPGk9l7ZuM4xa8ZxoEGkBFFOoy6MbESAojVuw4+AcBZ+sKHO/CqjtUz gfaRR2nibbL6ePps1bMKs4eX/jSEabnME7HnRo1024qCgdP76ggxD041/fx6Rlqjkx9J O05FY5eaZLJl7IWjvu/uOsHmkrMEoNn6kVajxeyFw4Vphql5RKycMBcHRiQrALz+INis KPK40QkbWrj+MpDRJ20skCv61dWLPXxauuPIS+wG2sYl/19ZqeAi6DslTRyt0IRaLQKJ SmJEKYaf5DVrj+nNWszu63zFijqiQh7rdkvHs0RJMUdpQgr58PE8ly9LPSoUx5M7m9nL bo8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=ZLj5idC5I/QLiRFMvWiNyMDzS3MjZTMihHHTmTOAHD4=; b=rIzacs52DHONRNetv+A1aWY/DBcdxx9bDl37XYRbzRVKdtL/xxVGz65jNu/ZCULmd/ wmwzRbXlx1DwDgp2+T1LPlKMwLt9bYD1ba/Q13Wz2yRSRzBSYRgQz26J+GG14r0C+5cw vxUh596IgRRDpHEY+TdWCSlkmUmFHH4yF78FZ+nBQd9SXyBt7FW+q13+inMYCknkeQin cwWgZ5M+/Ne5+aVxQYv9YOWhp6fLZEX/861CiLSuFDf6nlhJ2LPXh/kpO3KFf5vLGSgP 8DKqI9e1yoAw9Yu4i3ay2oUed5PUk3L0t9HNEamxVBrElP44VwkACuh13CgQegpm9xBz C9JQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=QJwNsmdP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e4-20020a17090301c400b001b1be1317a1si5744295plh.219.2023.06.21.13.55.48; Wed, 21 Jun 2023 13:56:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=QJwNsmdP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229595AbjFUUik (ORCPT + 99 others); Wed, 21 Jun 2023 16:38:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229999AbjFUUij (ORCPT ); Wed, 21 Jun 2023 16:38:39 -0400 Received: from mail-vk1-xa33.google.com (mail-vk1-xa33.google.com [IPv6:2607:f8b0:4864:20::a33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5DF219BD; Wed, 21 Jun 2023 13:38:34 -0700 (PDT) Received: by mail-vk1-xa33.google.com with SMTP id 71dfb90a1353d-471b3ad20e1so1198154e0c.1; Wed, 21 Jun 2023 13:38:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687379914; x=1689971914; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZLj5idC5I/QLiRFMvWiNyMDzS3MjZTMihHHTmTOAHD4=; b=QJwNsmdPlDmntrEtGy94/MBwAUCDKiL6efLCv+MnQtJ60YrqrNX8JtAfWruIJKP8u8 ivgZJWi555Oy00x39+3TORAu41cPfOHYeeoPvxcNszPm3uYCSvtAVLoFkjH97VpWwGQr dTIrJopGXiopUN84IXeJrAIywdxRh6ml4/YCVnE9VarLvlASWW59ftTqIQZxgDjlARE0 Aur01U3FStnPsC/P5HboSLQ81eY3HeclJ9uopSSzbvaZdk+nidrGAPfFs1+dxtP11F2j TOUuVQmwWWapKr6MFs3+OuK5N7309W0NUyvU3EmR53SA+cyXDjuAGr5pLuu5l1EXXIKV K17w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687379914; x=1689971914; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZLj5idC5I/QLiRFMvWiNyMDzS3MjZTMihHHTmTOAHD4=; b=Q8QXGZXxYKhmaQxWnKgcwTDNEJPUVz3ZMxljqyjtOECseNh5A6OEZK9q3P0pkZJjg2 kD8+03r3tT6ynwXpmco20+6qG2rVjsJdTmRbNLWfYM7ysNtptGHOC+CD7FfoJnFHQRbV n+29wEfzeKMsVnHiicElG5Vl1oHSXNQWEX68K30lLjp62JNiUzJj8thxTmP9L2PtWLWd xqjR+miZ3iPxzJfZ9xuPITFLz9xCyBNIaSXJCaEojM2C8gvYpoTIhDVYbQRLzv+ak5tN 8SJxxo6lf+ZNW8bspjKTrNc1fP6ElX3hF/xu472TqM3sURZbii96SGadOjuyY45JCeXq MwgA== X-Gm-Message-State: AC+VfDz7W+pOYz8s/fEzF6Rqp3CloAeVQS/1cJKz5k5NRXlQszlQikHL /VIHcar9DEtGLo76CfH+6DAAQnsg8Rx8HLJ5W4K6rfEDCjQ0yw== X-Received: by 2002:a1f:c1c6:0:b0:471:8787:2c6c with SMTP id r189-20020a1fc1c6000000b0047187872c6cmr4706478vkf.6.1687379913586; Wed, 21 Jun 2023 13:38:33 -0700 (PDT) MIME-Version: 1.0 References: <20230621191302.1405623-1-paweldembicki@gmail.com> <20230621191302.1405623-2-paweldembicki@gmail.com> <27e0f7c9-71a8-4882-ab65-6c42d969ea4f@lunn.ch> In-Reply-To: <27e0f7c9-71a8-4882-ab65-6c42d969ea4f@lunn.ch> From: =?UTF-8?Q?Pawe=C5=82_Dembicki?= Date: Wed, 21 Jun 2023 22:38:22 +0200 Message-ID: Subject: Re: [PATCH net-next 2/6] net: dsa: vsc73xx: add port_stp_state_set function To: Andrew Lunn Cc: netdev@vger.kernel.org, linus.walleij@linaro.org, Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org =C5=9Br., 21 cze 2023 o 21:33 Andrew Lunn napisa=C5=82(a): > > > + struct vsc73xx *vsc =3D ds->priv; > > + /* FIXME: STP frames isn't forwarded at this moment. BPDU frames = are > > + * forwarded only from to PI/SI interface. For more info see chap= ter > > + * 2.7.1 (CPU Forwarding) in datasheet. > > Do you mean the CPU never gets to see the BPDU frames? > > Does the hardware have any sort of packet matching to trap frames to > the CPU? Can you match on the destination MAC address > 01:80:C2:00:00:00 ? > Analyzer in VSC73XX switches can send some kind of packages to (and from) processor via registers available from SPI/Platform BUS (for some external analysis). In some cases it's possible to configure: if packet will be copied or forwarded to this special CPU queue. But BPDU frames could be sent to processor via CPU queue only. So It's impossible to forward bridge control data via rgmii interface. -- Pawel Dembicki