Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp9932693rwd; Wed, 21 Jun 2023 13:56:29 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5tMXNnXZjeci+PV8Ag7JlUQ+xV9gUALfq+N0HbsWWxNw1HSmD9YJ5OnYxlR/rXNLRm+FSg X-Received: by 2002:a17:90a:f2d2:b0:25e:86ab:f4d7 with SMTP id gt18-20020a17090af2d200b0025e86abf4d7mr15077168pjb.22.1687380989142; Wed, 21 Jun 2023 13:56:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687380989; cv=none; d=google.com; s=arc-20160816; b=GHthlQVwrVMFv8P+kJQ0ipAYach0tE87Y+ohXwVSjFRRLzdH6dUDG0lJBlx1SUiIhW FVTF/LM2VY1ZiErcfW03ZI4WvDg1zhCndgwDmVPyLG0i0qDMs0FbbeFfmsvk9PHB45R8 UraKH6IBESuCbW+MqRHU6gsYZLh0iaDsup+eBmyhYXVplDAROjdDrP43i+FDMf3IflCa 3olvB23FktmIVlDGqZqa3ifY0A52W/46yPey6N+7iKgqbhbpPv0iWrMBqj8g7yY6yNyb ZDxtf6KAp0aGPUO8rbl95MPrRmRooKw7lObb5A6w2vD2w3HSxju3QwF1hD2sliIxgEFq Skrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=vGbSHuU+pmHiul7+7XWEYqoMZY5mR0tPj8yIdpqxfoQ=; b=fp5QH8sH7uOH4VJ210gOxf9Dqli5Q+Y4jD3lV/800o1GgE9YGi0A9l7ycMtBNpXPKg Rb/16NQxcvU9HsIeBUFhaAk5NU2sQgCFbWyvF8IZ3PV3eeA4hQwc0eUvYPNMEVEscn4u 2LZUpPUUvUEeezARgokKrrTkmKxEh2gu8e9gtz9CW04rtqsL8Gjty2h5laZhjRQDyLtL Qey1xKTtEd5VpJ1xsHyNponTTYcMk61Om8bjUsDb61QvA5QmagTgQzA8DEQo9opygvbp 83jyWgLyxn9BwAtcN5vgL4agJ9XDaZSDKTNdumvBq8gMDnI5pGQfuHP/69FwO+Eh3lZd bX2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aVBcOHwh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b71-20020a63344a000000b00543ed2931d2si4964328pga.456.2023.06.21.13.56.17; Wed, 21 Jun 2023 13:56:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aVBcOHwh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229680AbjFUUqO (ORCPT + 99 others); Wed, 21 Jun 2023 16:46:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229601AbjFUUqM (ORCPT ); Wed, 21 Jun 2023 16:46:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FE2D10D2 for ; Wed, 21 Jun 2023 13:46:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9ADE5616BE for ; Wed, 21 Jun 2023 20:46:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 774D8C433C0; Wed, 21 Jun 2023 20:46:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687380371; bh=ripGwAImlGjHyuVMQp4ULj5BV9Mh3c5XiZNw2xG5rgI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aVBcOHwhn0CyYV41IepkWHkwOLDC90bWDSETmIEgsSmKVFfLrujsPj+2TCVUCZL3I fCCY6O630u2/2UT+FmlYwb1mRzUIBIarCqsh+WyAfJgc93kgMM3dWHiwl3eUxRs/Ex jeqyuK8j7PbhySN0qjL+ymyq2h6lXjrf8NCgh+upNWbLZNEfoyQkwKZd4HLPkoD+cF jnM17i98t4ZD3caWn/A4HimWCt5MUyjXkljMZnbgcJeogpqa4ZCji4yDU9mc5l6sEX 3yVgsVW7L9CkuBnMjEU5063vEhc3WV9UcMW9do9/QTQ+N9zX858C0X79YKQeB1l/j8 r9D2BU96+X0bw== Date: Wed, 21 Jun 2023 21:46:05 +0100 From: Mark Brown To: Maxim Kochetkov Cc: alsa-devel@alsa-project.org, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Benjamin Mugnier , Krzysztof Kozlowski , Greg Kroah-Hartman , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Claudiu Beznea , Charles Keepax , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] ASoC: codecs: max98090: Allow dsp_a mode Message-ID: References: <20230621115328.156457-1-fido_max@inbox.ru> <3805dc65-113f-453a-90a9-2ae6204004ba@sirena.org.uk> <0ada8334-4006-438f-8461-5c4c8e13f65d@inbox.ru> <08fb24b9-ab7d-da27-5ab7-e1d3270c8b43@inbox.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xFMqdEWfE/HZ3Aek" Content-Disposition: inline In-Reply-To: <08fb24b9-ab7d-da27-5ab7-e1d3270c8b43@inbox.ru> X-Cookie: When among apes, one must play the ape. X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xFMqdEWfE/HZ3Aek Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 21, 2023 at 10:57:18PM +0300, Maxim Kochetkov wrote: > On 21.06.2023 17:35, Mark Brown wrote: > > > > > I'm saying there should be some interlock between these two settings, if > > > > > nothing else setting DSP A mode should force TDM mode with automatically > > > > > configured slot sizes. > Ok. How about that: > --- > sound/soc/codecs/max98090.c | 52 ++++++++++++++++++++----------------- > sound/soc/codecs/max98090.h | 2 ++ > 2 files changed, 30 insertions(+), 24 deletions(-) That looks plausible, yes. I do note that the driver ignores tdm_width (and the entire TDM configuration) when configuring BCLK, I guess it only works in clock consumer mode for TDM? If that's the case there should really be some validation, and there should probably be a check for slot width being 16 since that looks like the only thing supported. Those were already broken though. --xFMqdEWfE/HZ3Aek Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSTYYwACgkQJNaLcl1U h9Cdegf+M3QEGRYrVk+Y7+QiD1MfHGt5GVDIMEyPuTUJDRGem8nC1umYM/jbF1VN Y35F5/Wc6UeD+VmMuvNKqwzX2xrB6NAvRdVtFXcC1L9TSldc55IT1pYT/+XFZe3Q YT0OWIObLCAOQHUnKmzAXQDbBnInswna9MFIi530D8VxL0D+ovILaNJhKWINjRGe gsMwcH/0zfKFGPsPkG+oeZWUADq2Pnio6YuEuhXgRrTz44mGGO2F2NQJuF1bsw0t kHqE3yFFj1sAz6CT0C2VBLCmEdZa7GJJJIih62gaKgPLi9IOyYLYRSq8WeekAjHB RU64YCU1LaHwwtpU4ZDKmwuEuejrEg== =sbbb -----END PGP SIGNATURE----- --xFMqdEWfE/HZ3Aek--