Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v1 2/2] platform/x86: wmi: Replace open coded
 guid_parse_and_compare()
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Hans de Goede <hdegoede@redhat.com>,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Mark Gross <markgross@kernel.org>
References: <20230621151155.78279-1-andriy.shevchenko@linux.intel.com>
 <20230621151155.78279-2-andriy.shevchenko@linux.intel.com>
From:   Armin Wolf <W_Armin@gmx.de>
Message-ID: <6f674805-b773-be24-4f27-1c86fbf1e3f6@gmx.de>
Date:   Wed, 21 Jun 2023 23:21:39 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20230621151155.78279-2-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
UI-OutboundReport: notjunk:1;M01:P0:wjKg/LMVlJ8=;l7r2+fyqhnXwj2RjoemiGCK/Hch
 6+YXKGUDDk7fiJJ2563J5W48O8koQGVhHNHZe1vtBBR/inymfpWPLI2JbRwOvtNUSlaeEyVp0
 Bh/ACylbmeEORR/WqYbDjHzqpkxPum++xSEeWVVsImJMg6b40MghvjLUtFVBqCAQS6W+XnisB
 i7pGXhT6MMZnTuXQI1m7clqMraTj8p+Jt6Xrq/3SxLJlxGXzwo+qiUppB75M4YkOfJ6J+erTr
 KB4xVeQt/N5iJ7t1Q4Pq12Hk7xSaTt/o04kEVgXSyaSMqYUb/5Kdkdvum7RhJPSJJKdpLD92p
 bVFs/oImgLTUEfosWlOQO4tu71RnOT33m4H0kARBknPjju24gxXn/Bsn7NlVfM7Bg3sCElu+a
 IMDKvx5QLXbOWhqIxE3Dtv64sqp7lZ9BuZdSrjeQRexH0760f1ZvpwA4Oa95Ms2L4eFVWys9r
 kIgQQqLdUrnbSwvQsgh3faXnR42mpUeDO8i5QilDYFjwL3WY6CDInq9xti2aLveoxXzUSOMkp
 2Y7eKl2bdBEPl5BIYFYR0JEsy3bCD58etr90ulqQBBfJzq6UN2bIuv4kb7P9Q+1F0LjkkQIVQ
 ScbLC+nPiy97kByC9Zo7BH2mLB2toJsoHy2wzWji5PaAHVSeNOEpFwBVzUMT5JgrMyJzRp9yd
 ybVQC8G0Ko4SlNqr7Z6zPWAftMtICzJdK3MwmKCOsYmNan1jYwyzN2n2gYlkDKfm7QFANy+kC
 wjHMj5fyfbkPiYPwtbfoQJutYlgKFNhPqMHXDZlcBTJhpXX45eMI2j+PhoUHIKlBf2NA0+hmi
 Tj3Gq/P7RplRbXDgUjGO4p1wQjd9cWTvkjL7n619QBIN2mWAuWcK6+urMlXdqn8ZRUY7RmrBW
 l3wy43EPC0C3gVr0JYEJuRh1dcU7+AXWaNaeKrj0jSxjCgheHi+ok9dWmly6B3eIaAh11CXb8
 qMPdSg==
Precedence: bulk

Am 21.06.23 um 17:11 schrieb Andy Shevchenko:

> Even though we have no issues in the code, let's replace the open
> coded guid_parse_and_compare().
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>   drivers/platform/x86/wmi.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
> index 098512a53170..a78ddd83cda0 100644
> --- a/drivers/platform/x86/wmi.c
> +++ b/drivers/platform/x86/wmi.c
> @@ -1241,11 +1241,7 @@ static bool guid_already_parsed_for_legacy(struct acpi_device *device, const gui
>   	list_for_each_entry(wblock, &wmi_block_list, list) {
>   		/* skip warning and register if we know the driver will use struct wmi_driver */
>   		for (int i = 0; allow_duplicates[i] != NULL; i++) {
> -			guid_t tmp;
> -
> -			if (guid_parse(allow_duplicates[i], &tmp))
> -				continue;
> -			if (guid_equal(&tmp, guid))
> +			if (guid_parse_and_compare(allow_duplicates[i], guid))
>   				return false;
>   		}
>   		if (guid_equal(&wblock->gblock.guid, guid)) {

Works on my Dell Inspiron 3505, so for this patch:
Tested-by: Armin Wolf <W_Armin@gmx.de>

Armin Wolf