Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp9996952rwd; Wed, 21 Jun 2023 14:58:42 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ65P3jo4PEMWOFwMrF0helsmgtRNVvXZyKUJLkvF/ep5492/Vef3oVUzm1DrRz7Gcmc8vZ/ X-Received: by 2002:a05:6808:1594:b0:3a0:5802:1b0c with SMTP id t20-20020a056808159400b003a058021b0cmr1350290oiw.4.1687384722011; Wed, 21 Jun 2023 14:58:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687384721; cv=none; d=google.com; s=arc-20160816; b=XgpRflZtA0Xey79mgYxgIuQeAJ1dVHZVDMZPrVyPes3FF81kWbkYuIX0gk+YEqKQq/ e/iYDh5uyDYd+5/Q/+0nW1aP9NbcaKqOnC3HCosP/+Mb3Dq7rWiCUJZ4ywaVY00puRSp 5Jo7nnlKLlfsZuVCED+gvxioo8W3NNzrGqVJ2PezdeRskZ4eF3JR86DaSMhDVYsGqdFL dZy2Pm3ClMRTSn8eXYNRvpm1QZj5PJbcxmDjQb4l1ptrQXJnaDKzLcyFD4z0iBvrEtF4 6SVY1132TW1Wg0ykD4AaiEAtvF3tmz2OZZOkNQmAG3/PQxrGEGF1HFbZkWTDH7L3jCLs 3i2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=LVtcBpBVguZA8qoqqhoUInWb/zY6DUWD1bjs2LWSb0I=; b=Oj/55wWWwnGX6o1ImZaq0uwHQbi0ej2aj+18BnYf/qQbjbnRjp7tNZZVdMwNKrHum9 W6IcWZ0yKjw2qIrYDjjNHhcLB2A2deXag9e3wLN35OL8SysGLDBOtvbFpPbwO5iO80Qc 6nws1DTq818jfzoEX+1+DV711beHcXnYvDrb72uQT0Um9BEetlYm4jaf168XiURW7gVq Tkl85XgqJCGCIssKEjOYWro+GD+uk+m6ghLbciCFAk+kwl/ZFsxGuN0deVs+rSm25c7q hpc0BuFMXJYeUr7kA19FGbsWne+78Y3foWURZOpxsGZ/u98o6Ku+VL+qW2B3KGCqvRbn +0Qw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=HVXsgsJ2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q3-20020a638c43000000b00536b4c4b695si4657217pgn.136.2023.06.21.14.58.29; Wed, 21 Jun 2023 14:58:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=HVXsgsJ2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229796AbjFUV3u (ORCPT + 99 others); Wed, 21 Jun 2023 17:29:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230348AbjFUV3r (ORCPT ); Wed, 21 Jun 2023 17:29:47 -0400 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AA901BCD for ; Wed, 21 Jun 2023 14:29:45 -0700 (PDT) Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-6687466137bso2473450b3a.0 for ; Wed, 21 Jun 2023 14:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1687382985; x=1689974985; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LVtcBpBVguZA8qoqqhoUInWb/zY6DUWD1bjs2LWSb0I=; b=HVXsgsJ2YYMXYdInroPiqaqbGEH1WjW4jAMh+uUvV+Uw5eiEQ2T1cO3J24tu2UHtEC 3/qMGW8RCfpt140xoltctrA2zl28kzVYi2S0Np2xPzOBl3Kj668sHAslYlppaiOa6Huv dIPfWyUQGWS0cdms7hGp/ovR66Ul7OKcNJqqg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687382985; x=1689974985; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LVtcBpBVguZA8qoqqhoUInWb/zY6DUWD1bjs2LWSb0I=; b=JYUiabiGv8FKa6pNosMNPaBxU+NlHWOTnL5FSWHDiWVzJ6H3wTEhV25erA5anEtXTy 332AeOYFlTNcBHxUyUP0itNMTq6Eo35j6GymmKlN9v7ryz/40CBq8p021hBjZ3Ya6QTC WwAgxt9cCOzmEfD0oiJ3j8QoqueWoC2yWQZY38vK0QNLiBf414KpIghTFAb2h9xHLiIQ 7bfr1liDirFIM8ZToUynxa2bPCriF8vN7sPhPxhQKUBTT7od+iZSlv4A3mYBTjCqNadr wJtZPqBNwyNkpyDnN1vzYWuJrdImaGflDmD76PYdI2nUXNM4+BSn5pwZd97pcCMtHVmA /CTg== X-Gm-Message-State: AC+VfDyMggWH2DFyx5UPmAYvUizq+6EVVPuS14ODnW+R8cVhCBrcAUEq G+1q5l+PA6vOatIYElYTRnXNmI7FcudxLx/NU+A= X-Received: by 2002:a05:6a00:2484:b0:666:ecf4:ed6d with SMTP id c4-20020a056a00248400b00666ecf4ed6dmr12103959pfv.18.1687382984779; Wed, 21 Jun 2023 14:29:44 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id 5-20020aa79145000000b006689ecd0ff4sm3061860pfi.208.2023.06.21.14.29.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jun 2023 14:29:44 -0700 (PDT) Date: Wed, 21 Jun 2023 14:29:43 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: Namjae Jeon , Steve French , Sergey Senozhatsky , Tom Talpey , linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH][next] ksmbd: Use struct_size() helper in ksmbd_negotiate_smb_dialect() Message-ID: <202306211429.DA43E8D39D@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 21, 2023 at 03:29:22PM -0600, Gustavo A. R. Silva wrote: > Prefer struct_size() over open-coded versions. > > Link: https://github.com/KSPP/linux/issues/160 > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook -- Kees Cook