Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp9997497rwd; Wed, 21 Jun 2023 14:59:27 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6JfLPnlsC7ibLsHEgki4FRX6mrRGFx41gFlHSbGzMDcP3TwYOE6r+DOEcanPp7xmRM/HYZ X-Received: by 2002:a05:6870:e353:b0:1a3:1cb3:37e9 with SMTP id a19-20020a056870e35300b001a31cb337e9mr11877567oae.4.1687384767279; Wed, 21 Jun 2023 14:59:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687384767; cv=none; d=google.com; s=arc-20160816; b=KuWL2b/sY3c+JiA08p5gYiqkO7Hc77QmQZnx0ep5H7Y5MHWR2ekjwABCu6MnolmThr miOga9ZnjrOtlTznuVP41swVd2HCkNJVyaiIguQaqZpZZ9FFjJbnEvrN64Ur2ut2AXUA Hxc7W+rwjgWfuN7DRitY7kLyqhbT39O6mvH3UWnFFRwJKTGMhSwsaRhQk0LnR20StCBY wzlhzHRybDsI8O7Mlzl7BurPM5TX3zWkcTvOrUu1qzRtEIsxYWIidmca0u81t5i8EI1E /o77QIGugQ2OF47pJPprzPYsbl59tNunI7LqvqOoSY2496GtWSPDVqhTLjc/HT5zOZSd zxLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=C6mtJxu2dDNF02+pBprjp3JwCVt0pkUhvAR6JSdjzgk=; b=caBXhuLxUOzXBVJC8HG1me96GkzUSA4+NnjClz0d+RMaTr/oWyvP0nWCH6Wbq1uaAH quRETtBbXZGuFrbDfAAVXFc7DtZ2gJpFLELpcchfpNwCCR7WKx6Su5o3zh19HIfSj51t I5iapczvyvO+NGcOVL+faymHkkkNWCRPS8w3kgerNaMPyqMzWpYFILrpCmxlOEvjPJcP wvVtiCwIPZPzVcQiuidvm/SlkPTVfmJjMK2xTk7FR5GZYywcPlJfPnf8RdFGQSjVLAPf z7Mg5P+Ba0/+OosX3xXhq28X61KNAI6nM6awMRi9nDqSHGDmZDPYP7RmFCNtCtzZjJfx fHbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mgtth32W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z9-20020aa79e49000000b006689a4f67a5si4521603pfq.80.2023.06.21.14.59.15; Wed, 21 Jun 2023 14:59:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mgtth32W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229909AbjFUVdm (ORCPT + 99 others); Wed, 21 Jun 2023 17:33:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229530AbjFUVdk (ORCPT ); Wed, 21 Jun 2023 17:33:40 -0400 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A7159B for ; Wed, 21 Jun 2023 14:33:39 -0700 (PDT) Received: by mail-yb1-xb29.google.com with SMTP id 3f1490d57ef6-bfe6ea01ff5so1365702276.3 for ; Wed, 21 Jun 2023 14:33:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687383218; x=1689975218; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=C6mtJxu2dDNF02+pBprjp3JwCVt0pkUhvAR6JSdjzgk=; b=mgtth32W59FwEqC/Km5G2zehnzpp7m2UioIe3CZkBFFGFVGG3pmEc8DCbMGiWn+gOQ duF2oUW1s8ZjqzoLMQQVDC1dxpXQlWUkHBEL232UAykVCvgKKwYkOKBFOcUvZY4cUCfe j1qYJf7X7DPU8aulo/HefJg2wMoJU56sminRD3teMlZSKPVbEh8UWGLecCLZ5peYUqRt 2RxGcMDdt2NsLJI4g0qHQbQCQylXYUIoJ1rk27ZsDjj6WVKU8tW80Tb/M9Re9LFrGgUj fWDyNSMtygFB6mQ+6OR7YdnYbwm4AN02uuBlgCxreM2I3kLDuTbW83TniXT5MsBlmERs V1pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687383218; x=1689975218; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C6mtJxu2dDNF02+pBprjp3JwCVt0pkUhvAR6JSdjzgk=; b=FyPft28T6XIdEqzNyqFE3/IsZkJR7FgFRhX6oQflzhR/enzJaApd7/iofyytVmKVBe Vs72maYi/cs+v6KkBl9/6qVPK6o7fimyztxdwJsl0wjNWZyEFCMV35Ozdh68FMAiJ9SE BSt0KQ6HNfBCaNvOfWABrz3BSDvXO24GEXYlAQCBc9VT6xLGI5AlMh78ALgKjPCCDOM5 a5ASaUOLutG7oRoyfHtNoG2qwG6u+X0GwoeyGJT+NJYUo//HNk6E1EC4anNf7rB8b0vH zANWAtxAPu6zI+m1UDZz9jj4kBGKW4ClCd5cN1+/IZbWzVLY75+p4rGkrDwPYB0VDgYo dNMw== X-Gm-Message-State: AC+VfDxB/48qHxjGJ2fRaMvOAJ2ZpA57A9rlvx2eq0nXjBxAFxuv+Jsy +OsgHP+UOqBdSNw2g73RWu0XZ9qDs5G9XOyvVJct6A== X-Received: by 2002:a25:ad1e:0:b0:bd6:8725:2258 with SMTP id y30-20020a25ad1e000000b00bd687252258mr13318133ybi.60.1687383218657; Wed, 21 Jun 2023 14:33:38 -0700 (PDT) MIME-Version: 1.0 References: <20230621191302.1405623-1-paweldembicki@gmail.com> <20230621191302.1405623-4-paweldembicki@gmail.com> In-Reply-To: <20230621191302.1405623-4-paweldembicki@gmail.com> From: Linus Walleij Date: Wed, 21 Jun 2023 23:33:27 +0200 Message-ID: Subject: Re: [PATCH net-next 4/6] net: dsa: vsc73xx: Add bridge support To: Pawel Dembicki Cc: netdev@vger.kernel.org, Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 21, 2023 at 9:14=E2=80=AFPM Pawel Dembicki wrote: > This patch adds bridge support for vsc73xx driver. > It introduce two functions for port_bridge_join and > vsc73xx_port_bridge_leave handling. > > Those functions implement forwarding adjust and use > dsa_tag_8021q_bridge_* api for adjust VLAN configuration. > > Signed-off-by: Pawel Dembicki Given that we use the approach from the other patches, this makes perfect sense. Reviewed-by: Linus Walleij Yours, Linus Walleij