Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 21 Jun 2023 21:29:21 +0000
To:     Armin Wolf <W_Armin@gmx.de>
From:   =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Hans de Goede <hdegoede@redhat.com>,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
        Mark Gross <markgross@kernel.org>
Subject: Re: [PATCH v1 1/2] platform/x86: wmi: Break possible infinite loop when parsing GUID
Message-ID: <TnTqU2wwXh3DG07kYUwMAe0hdBiaKiuoMOqBCBIttT27lXdw-KZVV8fZ7x-Zrg_Ux8mJUHClgyFHRbDoCRmhaOI7GwOPhUPYBRLzThV8iYI=@protonmail.com>
In-Reply-To: <25715979-8148-8d1d-fd67-a973661f9781@gmx.de>
References: <20230621151155.78279-1-andriy.shevchenko@linux.intel.com> <25715979-8148-8d1d-fd67-a973661f9781@gmx.de>
Feedback-ID: 20568564:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi


2023. j=C3=BAnius 21., szerda 23:20 keltez=C3=A9ssel, Armin Wolf <W_Armin@g=
mx.de> =C3=ADrta:

> [...]
> > @@ -895,11 +901,7 @@ static int wmi_dev_match(struct device *dev, struc=
t device_driver *driver)
> >   =09=09return 0;
> >
> >   =09while (*id->guid_string) {
> > -=09=09guid_t driver_guid;
> > -
> > -=09=09if (WARN_ON(guid_parse(id->guid_string, &driver_guid)))
>=20
> Hi,
>=20
> just an idea: how about printing an error/debug message in case of an mal=
formed GUID?
> This could be useful when searching for typos in GUIDs used by WMI driver=
s.
> [...]

Wouldn't it be better to change `__wmi_driver_register()` to check that?


Regards,
Barnab=C3=A1s P=C5=91cze