Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230620170027.1861012-1-weilin.wang@intel.com>
In-Reply-To: <20230620170027.1861012-1-weilin.wang@intel.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Wed, 21 Jun 2023 17:08:56 -0700
Message-ID: <CAM9d7cichi8QpVFjCDUf8e5aJEuZg1JPHtMBEs_FSNtsm8VoeA@mail.gmail.com>
Subject: Re: [PATCH v5 0/3] Add metric value validation test
To:     Weilin Wang <weilin.wang@intel.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Ian Rogers <irogers@google.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        Kan Liang <kan.liang@linux.intel.com>,
        Samantha Alt <samantha.alt@intel.com>,
        Perry Taylor <perry.taylor@intel.com>,
        Caleb Biggers <caleb.biggers@intel.com>, ravi.bangoria@amd.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hello,

On Tue, Jun 20, 2023 at 10:00 AM Weilin Wang <weilin.wang@intel.com> wrote:
>
> This is the fifth version of metric value validation tests.
>
> We made the following changes from v4 to v5:
>  - Update "()" to "{}" to avoid creating sub shell and successfully skip test on non-Intel
>  platform. [Ravi]
>
> v4: https://lore.kernel.org/lkml/20230618172820.751560-1-weilin.wang@intel.com/
>
> Weilin Wang (3):
>   perf test: Add metric value validation test
>   perf test: Add skip list for metrics known would fail
>   perf test: Rerun failed metrics with longer workload

Tested-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung


$ ./perf test -v validation

107: perf metrics value validation                                   :
--- start ---
test child forked, pid 1900992
Launch python validation script ./tests/shell/lib/perf_metric_validation.py
Output will be stored in: /tmp/__perf_test.program.Mm9Rw
Starting perf collection
...
Workload:  perf bench futex hash -r 2 -s
Total metrics collected:  200
Non-negative metric count:  200
Total Test Count:  100
Passed Test Count:  100
Test validation finished. Final report:
[
    {
        "Workload": "perf bench futex hash -r 2 -s",
        "Report": {
            "Metric Validation Statistics": {
                "Total Rule Count": 100,
                "Passed Rule Count": 100
            },
            "Tests in Category": {
                "PositiveValueTest": {
                    "Total Tests": 200,
                    "Passed Tests": 200,
                    "Failed Tests": []
                },
                "RelationshipTest": {
                    "Total Tests": 5,
                    "Passed Tests": 5,
                    "Failed Tests": []
                },
                "SingleMetricTest": {
                    "Total Tests": 95,
                    "Passed Tests": 95,
                    "Failed Tests": []
                }
            },
            "Errors": []
        }
    }
]
test child finished with 0
---- end ----
perf metrics value validation: Ok