Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8d87f85d-f239-bc8b-c48b-143ceac30082@gmail.com>
Date:   Thu, 22 Jun 2023 09:46:21 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v2 2/2] clk: nuvoton: Use clk_parent_data instead of
 string for parent clock
Content-Language: en-US
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     mturquette@baylibre.com, sboyd@kernel.org, arnd@arndb.de,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-clk@vger.kernel.org, soc@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, schung@nuvoton.com,
        Jacky Huang <ychuang3@nuvoton.com>
References: <20230621031605.234149-1-ychuang570808@gmail.com>
 <20230621031605.234149-3-ychuang570808@gmail.com>
 <2023062103-obtuse-parasitic-e675@gregkh>
From:   Jacky Huang <ychuang570808@gmail.com>
In-Reply-To: <2023062103-obtuse-parasitic-e675@gregkh>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2023/6/21 下午 08:51, Greg KH wrote:
> On Wed, Jun 21, 2023 at 03:16:05AM +0000, Jacky Huang wrote:
>>   
>> -	hws[AXICLK_MUX] = ma35d1_clk_mux(dev, "axiclk_mux", clk_base + REG_CLK_CLKDIV0,
>> -					 26, 1, axiclk_sel_clks,
>> -					 ARRAY_SIZE(axiclk_sel_clks));
>> -	hws[SYSCLK0_MUX] = ma35d1_clk_mux(dev, "sysclk0_mux", clk_base + REG_CLK_CLKSEL0,
>> -					  2, 1, sysclk0_sel_clks,
>> -					  ARRAY_SIZE(sysclk0_sel_clks));
>> -	hws[SYSCLK1_MUX] = ma35d1_clk_mux(dev, "sysclk1_mux", clk_base + REG_CLK_CLKSEL0,
>> -					  4, 1, sysclk1_sel_clks,
>> -					  ARRAY_SIZE(sysclk1_sel_clks));
>> +	hws[AXICLK_MUX] = ma35d1_clk_mux(dev, "axiclk_mux", clk_base + REG_CLK_CLKDIV0, 26, 1,
>> +					 axiclk_sel_clks, ARRAY_SIZE(axiclk_sel_clks));
>> +
>> +	hws[SYSCLK0_MUX] = ma35d1_clk_mux(dev, "sysclk0_mux",
>> +					  clk_base + REG_CLK_CLKSEL0, 2, 1,
>> +					  sysclk0_sel_clks, ARRAY_SIZE(sysclk0_sel_clks));
>> +
>> +	hws[SYSCLK1_MUX] = ma35d1_clk_mux(dev, "sysclk1_mux", clk_base + REG_CLK_CLKSEL0, 4, 1,
>> +					  sysclk1_sel_clks, ARRAY_SIZE(sysclk1_sel_clks));
>> +
> No need to reformat lines that are not actually changing anything, as
> this makes the patch harder to review for real changes in it :(
>
> thanks,
>
> greg k-h


Dear Greg.


Thanks for your advice.

I will modify the patch again to remove these irrelevant parts that have 
no practical effect.


Best Regards,

Jacky Huang