Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp10316364rwd; Wed, 21 Jun 2023 20:59:27 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ48n3zN81yNZQC9BWZjzq+Fh6VEllQDI/lZydRjg/LTLrxD+HWGnFwK0n6TL0w4G6/N0geJ X-Received: by 2002:a05:6a21:78a7:b0:10b:e88f:597c with SMTP id bf39-20020a056a2178a700b0010be88f597cmr8038992pzc.44.1687406366878; Wed, 21 Jun 2023 20:59:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687406366; cv=none; d=google.com; s=arc-20160816; b=VB09lWYDyMBJHMO7/9XPas+VUi2ZcTZZiK+D/G1qcEACCxkeVJr04aU0AZtIyJJi+p xiKzfXQVU64/UseiKX8MUxuJcCP8fAkUWFtcNschbL3swGx5j70Ph0+shVyirQH8u9w9 Smg3t5XasQot4Wibaz/XMffsuN7SrFVO7qjPb5/f2LDoHbszOJy2UobtqUkyeekDDGhA jnp+tWE7hadfyRbZuHckQ5aRxXcVkEBhwmNoEt+koq+aMkIxtY+gVnUB4kTK2k+DQDk9 PccmQdkCyxYTuBDvh+gd0MynBZigs2TIVJ/be78SxwLSjP3DN9VnfZ1dTCNoV+bsoJ94 wKxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=4lHcgK2qHBzynMgDy4i22PJ6oJ25dqBvwyYGONszUJI=; b=cqmESp+bXC3ChMZP6kVZoqiXulTeLV+yX3QBQL030Mold33pRSREf5iWXl8kdhBbst ecgLFTrR49ARbD5ZyK/JigvfhziEk8xrOrKRRF9yhjmgmFESVaAkVJifJ4+YWNPlyf27 Dp8MWQIqDyoI52FQ5uoWWUfp6zrejBX3xyJgNKyWXMgZmVj+WwBqvgGUA9+zgMoh28Ki MgmSAjxz9O1x9y1BlFEU/RqwYP/Q4mm2U70AN2qihUv4hwRLBXcDjxYI6RJM9NyXI1X7 pD8SAfQLxqlGcYoPamfdZiWZdjBjgnhJsmnjP5i/1HBwdU+Oa9KVIyvYZu/PkKdZ31Sp MGoA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n11-20020a170902d2cb00b001afe110eb66si2920666plc.532.2023.06.21.20.59.15; Wed, 21 Jun 2023 20:59:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229960AbjFVDv5 (ORCPT + 99 others); Wed, 21 Jun 2023 23:51:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229549AbjFVDvz (ORCPT ); Wed, 21 Jun 2023 23:51:55 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDC2D122; Wed, 21 Jun 2023 20:51:53 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 685FE67373; Thu, 22 Jun 2023 05:51:49 +0200 (CEST) Date: Thu, 22 Jun 2023 05:51:49 +0200 From: Christoph Hellwig To: Guenter Roeck Cc: Christoph Hellwig , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Mike Snitzer , Joern Engel , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Pavel Machek , dm-devel@redhat.com, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-mtd@lists.infradead.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 14/24] init: clear root_wait on all invalid root= strings Message-ID: <20230622035149.GA4667@lst.de> References: <20230523074535.249802-1-hch@lst.de> <20230523074535.249802-15-hch@lst.de> <8c1992bc-110a-4dad-8643-766c14bf6fd4@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8c1992bc-110a-4dad-8643-766c14bf6fd4@roeck-us.net> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 21, 2023 at 02:07:13PM -0700, Guenter Roeck wrote: > On Tue, May 23, 2023 at 09:45:25AM +0200, Christoph Hellwig wrote: > > Instead of only clearing root_wait in devt_from_partuuid when the UUID > > format was invalid, do that in parse_root_device for all strings that > > failed to parse. > > > > Signed-off-by: Christoph Hellwig > > In linux-next, almost all of my boot tests from usb drives as well > as a few others fail with "Disabling rootwait; root= is invalid." > in the log. Bisect points to this patch. Can you send such a log, and the command line you've used?