Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a44290cc-5954-8d5a-f84c-9e5a68732ea4@intel.com>
Date:   Thu, 22 Jun 2023 07:43:13 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.12.0
Subject: Re: [PATCH 0/9] Add support for Firefox's gecko profile format
To:     Anup Sharma <anupnewsmail@gmail.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Ian Rogers <irogers@google.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1687375189.git.anupnewsmail@gmail.com>
Content-Language: en-US
From:   Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki
In-Reply-To: <cover.1687375189.git.anupnewsmail@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 21/06/23 22:35, Anup Sharma wrote:
> This patch series adds support for Firefox's gecko profile format.
> The format is documented here [1]
> 
> The series adds a new python script that can be used to convert the 
> perf script to gecko profile format. To use this script, use the
> following commands: 
> 
> perf record 
> perf script -F +pid > perf_data.txt
> python3 firefox-gecko-converter.py > gecko_profile.json

Why not use the perf script python interface?

https://perf.wiki.kernel.org/index.php/Latest_Manual_Page_of_perf-script-python.1

> 
> Also dont forget to change the chown of the output file to the user[2].
> 
> [1] https://github.com/firefox-devtools/profiler/blob/main/docs-developer/gecko-profile-format.md
> [2] https://bugzilla.mozilla.org/show_bug.cgi?id=1823421
> 
> Anup Sharma (9):
>   scripts: python: Add check for correct perf script format
>   scripts: python: implement add sample function and return it
>   scripts: python: Introduce thread sample processing in
>     convertPerfScriptProfile
>   scripts: python: Implement parsing of input data in
>     convertPerfScriptProfile
>   scripts: python: implement function for thread creation
>   scripts: python: implement get or create stack function
>   scripts: python: implement get or create frame function
>   scripts: python: Finalize convertPerfScriptProfile and return profile
>     data
>   scripts: python: Add temporary main function for testing purposes
> 
>  .../scripts/python/firefox-gecko-converter.py | 249 ++++++++++++++++++
>  1 file changed, 249 insertions(+)
>  create mode 100644 tools/perf/scripts/python/firefox-gecko-converter.py
>