Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230621063749.3358430-1-irogers@google.com> <CAM9d7cg-r7Nw807egNFVRBgEXwgBV=A2pVEb+MBS4gvFgnNynQ@mail.gmail.com>
 <CAP-5=fVBbXoGuNeaYADA1RgY4wfSN8CgAJVEBjmOQGZ=-OiOAQ@mail.gmail.com>
In-Reply-To: <CAP-5=fVBbXoGuNeaYADA1RgY4wfSN8CgAJVEBjmOQGZ=-OiOAQ@mail.gmail.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Wed, 21 Jun 2023 22:21:12 -0700
Message-ID: <CAM9d7cixNAgxU58YNLHOpdZzDqk1t_ypOCQKEyo8+chFHd1HrQ@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] perf symbol: Remove symbol_name_rb_node
To:     Ian Rogers <irogers@google.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Yang Jihong <yangjihong1@huawei.com>,
        Carsten Haitzler <carsten.haitzler@arm.com>,
        Changbin Du <changbin.du@huawei.com>,
        Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Jason Wang <wangborong@cdjrlc.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Wed, Jun 21, 2023 at 9:28 PM Ian Rogers <irogers@google.com> wrote:
>
> On Wed, Jun 21, 2023 at 8:51 PM Namhyung Kim <namhyung@kernel.org> wrote:
> >
> > Hi Ian,
> >
> > On Tue, Jun 20, 2023 at 11:37 PM Ian Rogers <irogers@google.com> wrote:
> > >
> > > Most perf commands want to sort symbols by name and this is done via
> > > an invasive rbtree that on 64-bit systems costs 24 bytes. Sorting the
> > > symbols in a DSO by name is optional and not done by default, however,
> > > if sorting is requested the 24 bytes is allocated for every
> > > symbol.
> > >
> > > This change removes the rbtree and uses a sorted array of symbol
> > > pointers instead (costing 8 bytes per symbol). As the array is created
> > > on demand then there are further memory savings. The complexity of
> > > sorting the array and using the rbtree are the same.
> > >
> > > To support going to the next symbol, the index of the current symbol
> > > needs to be passed around as a pair with the current symbol. This
> > > requires some API changes.
> > >
> > > Signed-off-by: Ian Rogers <irogers@google.com>
> > >
> > > v2. map__find_symbol_by_name_idx so that map__find_symbol_by_name
> > >     doesn't need an optional parameter. Separate out
> > >     symbol_conf.sort_by_name removal.
> > > ---
> >
> > [SNIP]
> > >  void dso__sort_by_name(struct dso *dso)
> > >  {
> > > -       dso__set_sorted_by_name(dso);
> > > -       return symbols__sort_by_name(&dso->symbol_names, &dso->symbols);
> > > +       mutex_lock(&dso->lock);
> > > +       if (!dso__sorted_by_name(dso)) {
> > > +               size_t len;
> > > +
> > > +               dso->symbol_names = symbols__sort_by_name(&dso->symbols, &len);
> > > +               if (dso->symbol_names) {
> > > +                       dso->symbol_names_len = len;
> > > +                       dso__set_sorted_by_name(dso);
> > > +               }
> > > +       }
> > > +       mutex_unlock(&dso->lock);
> >
> > I think this part deserves a separate commit.
>
> Using the mutex or the use of sorted_by_name?

For the mutex originally, but might be better to split further. :)

And now it grabs the mutex unconditionally, I think
we can check the condition without the mutex first
and again with the mutex if not sorted.

Thanks,
Namhyung