Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230615142016.419570-1-zhiguangni01@gmail.com> <22bba771-f10b-8624-1874-5eb747e798dd@intel.com>
In-Reply-To: <22bba771-f10b-8624-1874-5eb747e798dd@intel.com>
From:   Liam Ni <zhiguangni01@gmail.com>
Date:   Thu, 22 Jun 2023 13:06:10 +0800
Message-ID: <CACZJ9cU81BObhY3RGb9mdhfWxqhNW=JhjSOyUXpizZ-S8hjdEQ@mail.gmail.com>
Subject: Re: [PATCH] x86,NUMA:Get the number of ram pages directly in numa_meminfo_cover_memory()
To:     Dave Hansen <dave.hansen@intel.com>
Cc:     dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com,
        akpm@linux-foundation.org, rppt@kernel.org, x86@kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, 22 Jun 2023 at 01:49, Dave Hansen <dave.hansen@intel.com> wrote:
>
> On 6/15/23 07:20, Liam Ni wrote:
> > In a previous implementation,The ram page is calculated
> > by counting the number of holes,
> > however,the number of ram pages is calculated during hole calculation.
> > Therefore,we can directly calculate the amount of ram pages.
>
> What problem does this patch solve?

I has send patch V2 to improve the execution efficiency of
numa_meminfo_cover_memory()
by optimize the way of calculating missing pages.

patch V2:
https://lore.kernel.org/all/20230619075315.49114-1-zhiguangni01@gmail.com/

In the previous implementation, We calculate missing pages as follows:
1. calculate numaram by traverse all the numa_meminfo's and for each of
them traverse all the regions in memblock.memory to prepare for
counting missing pages.

2. Traverse all the regions in memblock.memory again to get e820ram.

3. the missing page is (e820ram - numaram )

But,it's enough to count memory in memblock.memory that doesn't have
the node assigned.
we only need to traverse memblock.memory **once**.