Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <27a64673-63f1-e438-ff17-164b008c674b@amd.com>
Date:   Thu, 22 Jun 2023 10:57:57 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
From:   Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [PATCH] perf evsel amd: Fix IBS error message
References: <3b0abd4a-6450-c282-65ff-ec0c7df67b03@amd.com>
 <20230621062359.201-1-ravi.bangoria@amd.com>
 <CAM9d7chbpiSJ6eSu9_Gs7aLZZb58gtHsvH9tsE-U4eM1eyDvKQ@mail.gmail.com>
Content-Language: en-US
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     acme@kernel.org, peterz@infradead.org, irogers@google.com,
        jolsa@kernel.org, adrian.hunter@intel.com,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        sandipan.das@amd.com, ananth.narayan@amd.com,
        santosh.shukla@amd.com, Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <CAM9d7chbpiSJ6eSu9_Gs7aLZZb58gtHsvH9tsE-U4eM1eyDvKQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dFl3cis5Q3hYWTJSRHBZQ2xCbnFDZ014M1A4OFlBdGJuWGlYS2dtSjR4bGJz?=
 =?utf-8?B?WTJ3TUhvUnZib25uVGtLb0tWbStKV1JvV0NlU1hzejJqUXdJdTlUMkNTay9Y?=
 =?utf-8?B?aUpPbkZqQ0N3Vk5Ddm1KNzJ6amU3amhLbHJHZ1hqSUt4b2dxeXpZR1VpbVBs?=
 =?utf-8?B?aklKNUJUSUdGblRIVWhPY25nNEFGUDBySUZDU1luZTA3MzI0a09LYVFBWksw?=
 =?utf-8?B?OVZ3V1Y1V3ZhUjdYZk43OWhmeTMxU0lsRHlHR1RIUFpJTytMZDZPZTh2K2po?=
 =?utf-8?B?Q0VaSS9CbUE3U1hzTm8zRDhzVHM2REg2ZHU3S1c2Q1dMRHdzWDNBMUtQVEp0?=
 =?utf-8?B?T2VjY21SeC9CSDBYbVBVYUx4VTJJVmNOSnQvampUY0Y5a2cwMGJjZ0lxUnhH?=
 =?utf-8?B?OUNCM21lMlNVV2tiQVowSUM1SE1JbGFBb0p5bWdIb3BKTWF0VDVwWTI3U2ts?=
 =?utf-8?B?MEkrUW9EZU9ZV1dJZkF2L2RkTUk1Qm10MWhRZDVFZVZTc0QvNVFjMmZjVGw5?=
 =?utf-8?B?eDRPek1BaGpEUUxXT09YanBaNjJEZUQ4SHRTZ1BiZWJYUERya0JTTC9HV0M5?=
 =?utf-8?B?TTF5VlJ6R3B2Q1VSUWN1MUtqTXdMSVNKRWhGZkR2dUZab1FONDVaa0ZVQVVn?=
 =?utf-8?B?cjRXL3JWdGEzWnVuaVFZUmxkb2huOG44RTBDWFdDZnUwU0tZMC9QaVhVTW9z?=
 =?utf-8?B?RmorVGxwbitLb0pwU3E0VXlHcWJyYkdSM3V6WHVHV1BNTUF3aGNBRCtRM2dZ?=
 =?utf-8?B?T3BVREdSRUpvWDk5L3AySjQvK2Y0SUYrUmo1T3RmbzJ3TGwxWHUydjIzMGRR?=
 =?utf-8?B?UHo1YWlJZVFJR3ZnOXZ4VzB2cnBLWlZocUpnZFh3YWxLdS9DVjNWdXAxcjA2?=
 =?utf-8?B?NFQwQjRma0JUL1c5LzRBTXdweENta0o5bFNaQ3k4Q2N0eG5PM3FveFRCclRP?=
 =?utf-8?B?Q2VMdEt4ZWl0NkI3dTMxb0VDeCt3NVdYYzJFbzhPOTBpRmNOS0locU8zM2tJ?=
 =?utf-8?B?b2p5YU16TCtIVEdLVU5Lb0VlSFpRZlZNZ2tLY0V0Sit3NlhYV2t5VFlHaC8r?=
 =?utf-8?B?b2dEWHVYSzBmVCtJdHJSbjJpdjdlNkowVHRPT1kvSzR3dStPZ1c5bG9DRXlU?=
 =?utf-8?B?RzRwMkNNa0NCRlBSQXhlL21lNUtIRHZJRzlIcW1lUDlrN3NQTzJocFdCS3l2?=
 =?utf-8?B?dUF2NHhzYUM1MGUvYlVWbjlEbFpsYWpPT2huWmdwd2Jra0M1ZFBBNnpmZksy?=
 =?utf-8?B?dFVVcEJlcVVzVjMySHZUWWF2YVVVcE1Zc0FPM2FSR2pkR3BXU2NtK0t4Rjgx?=
 =?utf-8?B?N2c1YmtkbDRGVURuY3h0OWMxQXZReDQ3a3hYRG5NWlJVUnhCSGNnc3VOWmpa?=
 =?utf-8?B?dm5GeWVhMWxXdFYvWjVJR2RERGhvQWoyY1BQTTlRMldMTzAyd2JvNVBZQU5m?=
 =?utf-8?B?OFljQ2pHNjhhTXBVKzFZZmpxbUdZc2E1Sm96NXIxS3ZNYnYxWmlPaEhhdUVP?=
 =?utf-8?B?V2xqZ3RJQWwrNlc3R0RBRSsvTnovL1VueGJRN0RXd3JOWEdjbkcyYVdrTU8w?=
 =?utf-8?B?V0FtMGtmMXJXZU8yT1RxZmphTmVRWlFIVlJLZlRZZm9OMWM3WVlMN2p2cHZB?=
 =?utf-8?B?b1dHRTVkYnFpQXdMeUE5TEpTV2Q0aFByMzVrc1dKQ3JTczByaDFaQ2ZFYm8r?=
 =?utf-8?B?bGowdjZmdUtMTll5Yk9iOUR4SDcvT0EvSWJiRFZWMWp2M1pSZDBYVU1PQ3dY?=
 =?utf-8?B?aEtSL3hVOTVRT2pWK2U0Ymo3NS9Ndmw5by9ydE9Dd09pQ0FaYzFrVFZ4QXBr?=
 =?utf-8?B?RjIxSmFSTTNlWG9aQXVPSEpiSDRCd0UycmRCT2FnMzRFTEQ1VC9KVlhiUHRr?=
 =?utf-8?B?MHJMWnFkRlI4KzkyTGVVYVVjcmpMVXJ1TjVjRGtwY0gzb0ZIZ2FMZW82cDhN?=
 =?utf-8?B?SUY4djZTZlNQSzErUGNiY3NOb28yaTFkSzMzNUN1ZmV4QzNOcVNiMzlQeWtt?=
 =?utf-8?B?NWl3MjRkZUFndldqL0kwdTBhdXhSY0drUDVWVzB5c1c4am5rT3RwUjRnaFFa?=
 =?utf-8?B?MGdRN1V0ZHloekw2cHFERFFjbzRTQXFESVd1eHpWeEt6S2tLdTExdXhBZlhq?=
 =?utf-8?Q?QKf05kWpBJESLM0syH/sDal5B?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 24dddbe7-466b-48cc-d7c3-08db72e17855
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2023 05:28:11.9026
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0fjIgiiapKSV4hu7167I20nUFYLj39pI48VVY53/g5PmMpN5Y4/2mtdOnnbDnf6k/4rt1N9C/Zn3JqcAxnO/AQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7241
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Namhyung,

On 22-Jun-23 4:03 AM, Namhyung Kim wrote:
> Hi Ravi,
> 
> On Tue, Jun 20, 2023 at 11:24 PM Ravi Bangoria <ravi.bangoria@amd.com> wrote:
>>
>> AMD IBS can do per-process profiling[1] and is no longer restricted to
>> per-cpu or systemwide only. Remove stale error message.
>>
>> Before:
>>   $ sudo ./perf record -e "{ibs_op//,ibs_op//}" -C 0
>>   Error:
>>   AMD IBS may only be available in system-wide/per-cpu mode.
>>   Try using -a, or -C and workload affinity
> 
> It was strange that the -C option was given already.

Hmm. evsel->core.system_wide is bit confusing for me. A Comment on it's
definition says "irrespective of user requested CPUs or threads":

        /*
         * system_wide is for events that need to be on every CPU, irrespective
         * of user requested CPUs or threads. Map propagation will set cpus to
         * this event's own_cpus, whereby they will contribute to evlist
         * all_cpus.
         */
        bool                     system_wide;

So, I guess evsel->core.system_wide doesn't depend on -a / -C.

> 
>>
>> After:
>>   $ sudo ./perf record -e "{ibs_op//,ibs_op//}" -C 0
>>   Error:
>>   The sys_perf_event_open() syscall returned with 22 (Invalid
>>   argument) for event (ibs_op//).
>>   /bin/dmesg | grep -i perf may provide additional information.
> 
> It can run newer perf tools on an old kernel but the old error
> message seems to be invalid anyway.  So I'm ok with removing it.

Right.

>>
>> [1] https://git.kernel.org/torvalds/c/30093056f7b2
>>
>> Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com>
>> ---
>>  tools/perf/util/evsel.c | 10 +++-------
>>  1 file changed, 3 insertions(+), 7 deletions(-)
>>
>> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
>> index 356c07f03be6..65b0b70830f0 100644
>> --- a/tools/perf/util/evsel.c
>> +++ b/tools/perf/util/evsel.c
>> @@ -3092,14 +3092,10 @@ int evsel__open_strerror(struct evsel *evsel, struct target *target,
>>                         return scnprintf(msg, size,
>>         "Invalid event (%s) in per-thread mode, enable system wide with '-a'.",
>>                                         evsel__name(evsel));
>> -               if (is_amd(arch, cpuid)) {
>> -                       if (is_amd_ibs(evsel)) {
>> -                               if (evsel->core.attr.exclude_kernel)
>> -                                       return scnprintf(msg, size,
>> +               if (is_amd(arch, cpuid) && is_amd_ibs(evsel)) {
>> +                       if (evsel->core.attr.exclude_kernel) {
>> +                               return scnprintf(msg, size,
>>         "AMD IBS can't exclude kernel events.  Try running at a higher privilege level.");
> 
> I'm not sure if it's enough.  The IBS PMUs have CAP_NO_EXCLUDE then
> it can't exclude user events too, right?

That's correct. Let me try to fix this whole `if (is_amd())` part properly.

Thanks for your feedback,
Ravi