Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <45c62cab-a779-e843-9f98-a0d14d2bc97b@inbox.ru>
Date:   Thu, 22 Jun 2023 09:30:10 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 1/1] ASoC: codecs: max98090: Allow dsp_a mode
Content-Language: en-US
To:     Mark Brown <broonie@kernel.org>
Cc:     alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Benjamin Mugnier <benjamin.mugnier@foss.st.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        Claudiu Beznea <claudiu.beznea@microchip.com>,
        Charles Keepax <ckeepax@opensource.cirrus.com>,
        linux-kernel@vger.kernel.org
References: <20230621115328.156457-1-fido_max@inbox.ru>
 <3805dc65-113f-453a-90a9-2ae6204004ba@sirena.org.uk>
 <e6be75f6-054f-6c3b-00b4-a5e112bcefc3@inbox.ru>
 <b763d08e-f751-480c-96b6-339a53856768@sirena.org.uk>
 <ed9606a4-4be6-7403-6e32-1c045ac0bdf6@inbox.ru>
 <adbe1b82-9478-4462-ace9-968723a6ce3f@sirena.org.uk>
 <0ada8334-4006-438f-8461-5c4c8e13f65d@inbox.ru>
 <c054b036-d5fd-482b-adc4-913edbcd007c@sirena.org.uk>
 <08fb24b9-ab7d-da27-5ab7-e1d3270c8b43@inbox.ru>
 <b83bf5c9-5998-4683-8f28-1eff432742ed@sirena.org.uk>
From:   Maxim Kochetkov <fido_max@inbox.ru>
In-Reply-To: <b83bf5c9-5998-4683-8f28-1eff432742ed@sirena.org.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 21.06.2023 23:46, Mark Brown wrote:
>> Ok. How about that:
>> ---
>>   sound/soc/codecs/max98090.c | 52 ++++++++++++++++++++-----------------
>>   sound/soc/codecs/max98090.h |  2 ++
>>   2 files changed, 30 insertions(+), 24 deletions(-)
> 
> That looks plausible, yes.
> 
> I do note that the driver ignores tdm_width (and the entire TDM
> configuration) when configuring BCLK, I guess it only works in clock
> consumer mode for TDM?  If that's the case there should really be some
> validation, and there should probably be a check for slot width being 16
> since that looks like the only thing supported.  Those were already
> broken though.

Yep, tdm_width is not used in the driver and I can drop it. We already 
have slot_width validation in set_tdm_slot(), so only 16 is allowed. I 
didn't check/use clock provider mode. But it looks fine for me. 
set_fmt() just sets frame width here: 32 - by default, 48/64 - 3/4 slots 
if configured. We also check slots count in set_tdm_slots(). It will 
work for I2S/TDM.