Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934154AbXJSANU (ORCPT ); Thu, 18 Oct 2007 20:13:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754432AbXJSANM (ORCPT ); Thu, 18 Oct 2007 20:13:12 -0400 Received: from smtp20.orange.fr ([80.12.242.27]:23620 "EHLO smtp20.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754134AbXJSANL (ORCPT ); Thu, 18 Oct 2007 20:13:11 -0400 X-Greylist: delayed 1838 seconds by postgrey-1.27 at vger.kernel.org; Thu, 18 Oct 2007 20:13:11 EDT X-ME-UUID: 20071018234228809.C58FF1C0008A@mwinf2011.orange.fr Date: Fri, 19 Oct 2007 01:42:28 +0200 From: Samuel Ortiz To: Thomas Gleixner Cc: Andrew Morton , linux-kernel@vger.kernel.org, Paul Sokolovsky , Ben Dooks Subject: Re: [RFC] [PATCH -mm] ASIC3 driver Message-ID: <20071018234227.GB19183@caravaggio> Reply-To: Samuel Ortiz References: <20071018091239.GA11360@caravaggio> <20071018150544.6852d5c9.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 862 Lines: 29 On Fri, Oct 19, 2007 at 12:15:47AM +0200, Thomas Gleixner wrote: > On Thu, 18 Oct 2007, Andrew Morton wrote: > > > + > > > +#include > > > +#include > > > +#include > > > > Please see the large comment at the top of linux/irq.h. I believe this > > driver will fial to compile on at least arm. > > > > We really should fix this. > > drivers are fine with: #include > > If they need linux/irq.h, then they do probably something really > nasty. The asic3 adds irqs to a board, through GPIOs. Is that a valid case ? Cheers, Samuel. > tglx - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/