Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 22 Jun 2023 09:17:19 +0200
From:   Robert Richter <rrichter@amd.com>
To:     Terry Bowman <terry.bowman@amd.com>
Cc:     alison.schofield@intel.com, vishal.l.verma@intel.com,
        ira.weiny@intel.com, bwidawsk@kernel.org, dan.j.williams@intel.com,
        dave.jiang@intel.com, Jonathan.Cameron@huawei.com,
        linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,
        bhelgaas@google.com
Subject: Re: [PATCH v6 01/27] cxl/port: Fix NULL pointer access in
 devm_cxl_add_port()
Message-ID: <ZJP1f0XboCKhhR6F@rric.localdomain>
References: <20230622035126.4130151-1-terry.bowman@amd.com>
 <20230622035126.4130151-2-terry.bowman@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230622035126.4130151-2-terry.bowman@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?txDZzIOPqMJx9uPS2WE0+gO5HqYSM9g/CwXet+ji7vwUyUlS6h0nDPCtxWkl?=
 =?us-ascii?Q?nB7M0p9DMgV+jcF+e+TcIlS6HpkPwyu+uEq6U1LY2BOMBFZC/uDwIYLvkQKG?=
 =?us-ascii?Q?xh2xefggrJtW2BUlXH9f95h1nmDJuC9Q7fTXE18YxCGoIY5fBB47jG7vQd/0?=
 =?us-ascii?Q?EvAvgZxDuKc7RO3s4YvnhVxnMvUMpt61Mvgv1ZpaIZE9xF+hPur1KyA8hJR8?=
 =?us-ascii?Q?b3iKKL8vAXFaCqgMCKjZW1oxfwCaOXgzRa4xgmaACGMBPyH/7pzPr0Es8ap1?=
 =?us-ascii?Q?+EK6/ypArj0l6H7xVdO5Q3Hzn33d201yeGgAyXmX44IZp2yFNePZJ1W0Vp79?=
 =?us-ascii?Q?oPF0Rc7xtkoi9ziDvae5xbjm1aMB3puoVsuiwBmmvaoLRWkZBtqRjFWrQRTs?=
 =?us-ascii?Q?g4jox1ojV9jUQfZb8CMdp9WUG5vWDRxurBQLUoQdRY+qrw9CmguC3G0J4ZL4?=
 =?us-ascii?Q?noBXzgVkTL9UUceDqAG1bju6g/dNSvNagPTKnW7A5x0G4hSrNbrgbnmiqV8T?=
 =?us-ascii?Q?cmIK1BaCJkoSmhjuXF1GODq5gCcqEPO3JcQ3D3jaQMLg+Ly38+cYq7i5m9bv?=
 =?us-ascii?Q?6MVAlH4naIMWglvqGSFlTYmjoP2L5guIfx3AFbY3v3UA+eByzn0PQyXtHyVs?=
 =?us-ascii?Q?PUHJOWSbKerHS9OZKuM72WB6hlZgTN20zUelqJ9ZT9Nu5tC8ZaxXh/xmNUj2?=
 =?us-ascii?Q?kmusGcV8K9CBtEVNnVk29s4ns1diY5gq99sxbkHkH1UIbu5zGzmfiITTRtGi?=
 =?us-ascii?Q?zaLEGll1qLHX2UCv2aeNZbn6FtkVL7L9VXAv8aE8SC4fNv/F0HHSgg0wKs4l?=
 =?us-ascii?Q?vAvjbTWhrXYcxyrVqex01XVkW7OpSgl1bx4yumF5KoIjSKK9IJLlKknMI92D?=
 =?us-ascii?Q?KAhzswJtN6lim2nH9nPfQ/og/CUsf8UpWzVV65HUuxvTK3zziMXlg7sDNW/x?=
 =?us-ascii?Q?4UwJ7/4wUKbCQCbvvZ5TCILCdoOQR51akXArbsqg1BvYxUkfIRFOTSx4FhCU?=
 =?us-ascii?Q?1b/bO6vc5NxWIuudpeZOrEJOh/lHUnutrpQDDMVvk2cJFeuQwp4UZx2B3om4?=
 =?us-ascii?Q?+Yt3n8LZ1/UCOvl1RP4VUBDSp8Cc7AWklvFoKEbKllLa2BcDe4ENdsQwwQvS?=
 =?us-ascii?Q?WKWXsmprvnqLF5V+LPwvw04OEJw76HgxIj8WBuyuPbYRE6KzY+nOrcK25h0U?=
 =?us-ascii?Q?2YPpxFWqhcs3tcIpUgBCwfZaquR89ZEfEnokUCuaPsxIz/bnlJ0Q4Wz/7ogQ?=
 =?us-ascii?Q?SX8H7j3R87gnvKAfwtXjRGLK5K8OR85B8LYEvG9LlKZlJukJjot/W95pfu+3?=
 =?us-ascii?Q?EytuW2FNR31p5Cn45TraeGTWJDxo3fmwj0GQJVVgAWWHw7pwIEGga6Ec7SDY?=
 =?us-ascii?Q?4ij41XZUlR9bglf1t7kHep1MAIQhBvVw1Y0wSor6ciKVm0TsSIG5WBIBwnjS?=
 =?us-ascii?Q?03W7peG1Wp7imH6xAptpr3dDDS/iRaQZMCGTVcg8UjVKEPiPgBfFQT8a8rRo?=
 =?us-ascii?Q?ajeu9DBiakJYdC3cZjvQvrbQyxo83iHhT5DdlT6/lzDEif8n2hgA+gi6taFe?=
 =?us-ascii?Q?BKLLCFmSleK1tPpoWsQGLAgAOeHteDzutJfn6I+A?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 150d90af-7bbf-4b95-583e-08db72f0bb7b
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3657.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2023 07:17:26.8643
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0bCKaJRbOJXIU7q/54xtjD0IJky1Q3y2Ijy1+Vk+0YxJ1xVFuJzCO/m7lOOjo4LqePMkAUkNftoNJsDLaZN5zg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5444
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 21.06.23 22:51:00, Terry Bowman wrote:
> From: Robert Richter <rrichter@amd.com>
> 
> In devm_cxl_add_port() the port creation may fail and its associated
> pointer does not contain a valid address. During error message
> generation this invalid port address is used. Fix that wrong address
> access.
> 
> Fixes: f3cd264c4ec1 ("cxl: Unify debug messages when calling devm_cxl_add_port()")
> Signed-off-by: Robert Richter <rrichter@amd.com>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> Link: https://lore.kernel.org/r/20230519215436.3394532-1-rrichter@amd.com
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
>  drivers/cxl/core/port.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

This patch can be dropped as it is already upstream:

 a70fc4ed20a6 cxl/port: Fix NULL pointer access in devm_cxl_add_port()

Instead, this is the base commit for the remaining patches of the
series.

-Robert