Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp10569308rwd; Thu, 22 Jun 2023 01:34:10 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7a5cJrdTzno2yEp2JYmRUhNbawSeBgMNT0pIaSE6aDVqL9hfWqRc/fAYpaERGYefbd1N3b X-Received: by 2002:a17:90b:3141:b0:259:548b:d394 with SMTP id ip1-20020a17090b314100b00259548bd394mr12479306pjb.28.1687422850185; Thu, 22 Jun 2023 01:34:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687422850; cv=none; d=google.com; s=arc-20160816; b=pAK/4AEkCYFbMBp7ZzNkCgl7WOVHvkBdptQtdb0YUsCmoJVOtHQcpUMIt12IbhWYBK K8n4tBOVn9uTQKYyoGDTnh1vN4BRaH5LGdlTkorhAMigH9pxCZf7zTECqXXfeL9SHFA2 /LCW/UhDafQ8bFLjctg04dm9GyKFhVK1blN4/S+ikrshMERNGRHqR1rPqZUCW9rYtjfW Eogo8gQK7NFLVO4uDKlg+954CAFbF1bNq7E2xMo1E/pOKO17psUrya8ebtjjuf7yyPDU 7g8PfL07dyxYL4j3Uwb7ygssRxCIHM1PEtM/uLXJPiJSLlZUtIPQfTertRbFQRIvnwom qH1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=LkAmp/eBQd0cTktY86obokW51TRlbdxhv/mUSDQv+nU=; b=0PwxD3ZonisWqDSageoRWIwPnpB9ZwIyGjw8p0kHnDqpCRQ8Rxj7NM7jiRKqL5yINA Nk4j/QJldAT9jZ9rHOYdx0BKzz3gxPtfHwzHzeaPbrUYRtMS0a6UefKqWpdL4KPYwwg/ o0sd3KWJVGukFWgBDCS3Estv1IsjhpkVHwR/Y0+b+b8d9a/W6+uB9hQ6dQn5nNNg/dos AKoWxO4fYDA+RBY7ZBTUBbx++6c1MLR4cIE1zms5uCsnXZ/yd3EPKCekeOaQXWnviKLa iReHKDbq2gfyr/YThHkDM+5L+FL9Jy/f9kRKx+CkgcbesTdOOOib76Xt4MbWentWA9GM AvHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ryTD1hao; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h15-20020a17090a130f00b0025bf45ac365si1112082pja.82.2023.06.22.01.33.47; Thu, 22 Jun 2023 01:34:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ryTD1hao; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230120AbjFVIXC (ORCPT + 99 others); Thu, 22 Jun 2023 04:23:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229862AbjFVIW5 (ORCPT ); Thu, 22 Jun 2023 04:22:57 -0400 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AE151BF4 for ; Thu, 22 Jun 2023 01:22:55 -0700 (PDT) Received: by mail-yb1-xb29.google.com with SMTP id 3f1490d57ef6-bfee679b7efso1533598276.0 for ; Thu, 22 Jun 2023 01:22:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687422174; x=1690014174; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LkAmp/eBQd0cTktY86obokW51TRlbdxhv/mUSDQv+nU=; b=ryTD1haolYTGV5QhKbwvtO1zw8ha75NRjxLsZio0r8q11fXJAp1d1UhuGi2mBdtzoS Yd8SdHE7/3KfHvnaMlTK2Nz5jp/oI5ytf96D2RrI0CvQAMmTVufEaiix0nCH1Hy517jj 1wadPnb2zAVAiqSyEeMfPJSjfROYLnwTCflkT3TIU/a13cBP0m0nhByfFDf5r+waO8rX nIhExbPbf6vWiCRZIBWWsQnwoOLnSjLZ/EK8aM88r1L1O3QHg2bsosfvD+x98vx8TSMb /ap4uqa2wSP7grW2zTnOgcwoS2qRShdC+FlDAkjXmtQ1a1EaHiz8i4AAeTUaj39uEkma FWyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687422174; x=1690014174; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LkAmp/eBQd0cTktY86obokW51TRlbdxhv/mUSDQv+nU=; b=R5hXSQlnH2wVjAViGqCmHBjHH02dTXcwn+BiaBcl6hEl5Fjje8Zcf/kcrxAjuReg25 FUvYiDMKl/zbdwcbNeWkwcpW42gyzDt1n8j4xozv32aNdagNZWU3WVS4XDxQnfJKIWLi J6OdZ0V5rH4qakVorJnfzf0Y+jTlTewjRs8C4BpW9rb0Ybp+Ae9lklykZfk2HMDz1FJR 1ut+TWwP6k+D+ZkL/g/wualmqSVGh1mKcufE95hvbiQn6VCj5h2a1zjS3BzqENntEFYO PsazKQaifhU5Af+DfH2Jekvf55g0XL8Us1CRPyiQQS9bn0/y5PKYcDC2qm4+hf+jvkFR qUAg== X-Gm-Message-State: AC+VfDx85hor2rxkJmYdHIWgHAgkMzmZEOYQ/jaLZJC6X+mZ3qLBFLr/ Kif4OmhoAXjQKcwpYDayUO7cGB+6VvDUOePAHwZbGg== X-Received: by 2002:a25:9112:0:b0:bc8:cd2c:2fb with SMTP id v18-20020a259112000000b00bc8cd2c02fbmr13116488ybl.9.1687422174141; Thu, 22 Jun 2023 01:22:54 -0700 (PDT) MIME-Version: 1.0 References: <20230607151127.1542024-1-pavacic.p@gmail.com> <20230607151127.1542024-4-pavacic.p@gmail.com> In-Reply-To: From: Linus Walleij Date: Thu, 22 Jun 2023 10:22:42 +0200 Message-ID: Subject: Re: [PATCH v4 3/3] drm/panel-fannal-c3004: Add fannal c3004 DSI panel To: Paulo Pavacic , Jagan Teki , Marek Vasut , Maya Matuszczyk Cc: neil.armstrong@linaro.org, sam@ravnborg.org, airlied@gmail.com, daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 21, 2023 at 5:09=E2=80=AFPM Paulo Pavacic = wrote: > A lot of modifications to st7701 are required. I believe it would > result in a driver that doesn't look or work the same. e.g compare > delays between initialization sequences of panel-fannal-c3004 and > panel-st7701. I think it would be optimal to create st7701s driver and > have special handling for st7701s panels. If there was a flag for > whether panel is st7701 or st7701s it would end up looking like a > mess. What matters is if the original authors of the old st7701 driver are around and reviewing and testing patches at all. What we need is active maintainers. (Added Jagan, Marek & Maya). I buy the reasoning that the st7701s is perhaps substantially different from st7701. If st7701s is very different then I suppose it needs a separate driver, then all we need to to name the driver properly, i.e. panel-sitronix-st7701s.c. Yours, Linus Walleij