Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp10642045rwd; Thu, 22 Jun 2023 02:48:54 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6bEwBfiXEEU7YG3PFcA/haJNgzfepF3BRB+rmva7sDkyyVXHyVJZDY0LMt+9U+LHFEKwW6 X-Received: by 2002:a17:902:7e85:b0:1b6:9c8e:11ae with SMTP id z5-20020a1709027e8500b001b69c8e11aemr5090833pla.21.1687427334237; Thu, 22 Jun 2023 02:48:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687427334; cv=none; d=google.com; s=arc-20160816; b=KACZSR2P0Yr5ebV0yRhi9yQwL4QGfYVZ+fE2UQ9rPrEGFJXDwXFFMcqeyrow/E7zrw eED2CjcBKj9j/ggcJ4RUDiGQVhW7DvW2DZVXUVS4mnfD9UCTqwLL7q89ElS4Yacd0Lb2 i8aWaNK78uF4ATmoiAWbcLnWao7kb7hr9j8ntjyHsOWLX+m2XMMOlTKzKTll6ssJu4xF 7JZd43GmT6stX+ktbncYMO30pron21MwGwBCvhD2lgJelMoZ9ycF5AmvyOMIFpRsSODa aerTxBJfAiL4wry1agF52VNkVq+l39/rBLaibpp5jHARnKGULZRjFI6RwB+U2yYr4wLl THmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=npaepgHE+SANahOnIwVKBTvWdyFMP30URQTrbG6KQ1Y=; b=AQp1VjKiU7TWiU/PcpoXu3xsTbgrOiyizoILdYSR8GmxDmKRS32QKDqijW/OUjfnBI vF9NmQ0WdhdQjjqJbfcpI6+X/F7FHPp3VA+A1+ggzC3hz4R4rQOi3YCAdRWhsmptlvUF WJczmilzNYwvccmIL2jpKS0hHgaCdWb0pJeVUIbHGKN8NLe3Unx83doLL9mNPOtrEBQO h3ygyuvft6x9RARylwxHeOIcEstnih5QE568m7vrcxrtYP6mLKAzNZgfZasCHsZgvmFN hE+7Cpn4p8bSRQ7g88MLF+lRNt0T/YdeRsoaNIvglWxV0ROaBPjPXV19Tss+3u+pRxKf R+5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b18-20020a170903229200b001b049396666si6933764plh.601.2023.06.22.02.48.41; Thu, 22 Jun 2023 02:48:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232103AbjFVJah (ORCPT + 99 others); Thu, 22 Jun 2023 05:30:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232000AbjFVJ3n (ORCPT ); Thu, 22 Jun 2023 05:29:43 -0400 Received: from andre.telenet-ops.be (andre.telenet-ops.be [IPv6:2a02:1800:120:4::f00:15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 987604220 for ; Thu, 22 Jun 2023 02:22:44 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed20:991a:a831:ea4b:6058]) by andre.telenet-ops.be with bizsmtp id C9Nj2A0021yfRTD019NjNe; Thu, 22 Jun 2023 11:22:43 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qCGWX-000BvU-CF; Thu, 22 Jun 2023 11:22:43 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qCGWY-003Vvt-VX; Thu, 22 Jun 2023 11:22:42 +0200 From: Geert Uytterhoeven To: Laurent Pinchart , Kieran Bingham , David Airlie , Daniel Vetter , Thomas Zimmermann , Magnus Damm Cc: dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH 04/39] drm: renesas: shmobile: Fix ARGB32 overlay format typo Date: Thu, 22 Jun 2023 11:21:16 +0200 Message-Id: <7cc1dea4833e6fb9b30aa35f801f14338578dfb1.1687423204.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When configurating a CHn Source Image Format Register (LDBBSIFR), one should use the corresponding LDBBSIFR_RPKF_* definition for overlay planes, not the DDFR_PKF_* definition for the primary plane. Fortunately both definitions resolve to the same value, so this bug did not cause any harm. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c index 0e34573c3cb3d032..7e49e2873da1bb6f 100644 --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c @@ -94,10 +94,10 @@ static void __shmob_drm_plane_setup(struct shmob_drm_plane *splane, format |= LDBBSIFR_AL_1 | LDBBSIFR_RY | LDBBSIFR_RPKF_RGB24; break; case DRM_FORMAT_ARGB8888: - format |= LDBBSIFR_AL_PK | LDBBSIFR_RY | LDDFR_PKF_ARGB32; + format |= LDBBSIFR_AL_PK | LDBBSIFR_RY | LDBBSIFR_RPKF_ARGB32; break; case DRM_FORMAT_XRGB8888: - format |= LDBBSIFR_AL_1 | LDBBSIFR_RY | LDDFR_PKF_ARGB32; + format |= LDBBSIFR_AL_1 | LDBBSIFR_RY | LDBBSIFR_RPKF_ARGB32; break; case DRM_FORMAT_NV12: case DRM_FORMAT_NV21: -- 2.34.1