Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp10647874rwd; Thu, 22 Jun 2023 02:55:30 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7Mkq5NUxuJ2VnU9/OsConW9Q2evCIow1W6/hQDQshof5g9uRiESgVsir6E1EMNativ6a6s X-Received: by 2002:a05:620a:4043:b0:763:ddcf:682 with SMTP id i3-20020a05620a404300b00763ddcf0682mr4305541qko.43.1687427730291; Thu, 22 Jun 2023 02:55:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687427730; cv=none; d=google.com; s=arc-20160816; b=EZrGQRfVsnxMsyv4UKbCXgYCtwRRcsq33/sVOSETQjAkSbpoAP1V9IXHOFtyJ5YVU8 pUy0ZOCn3rJnsNlTtQrmtN3P7VGC6dugGFqeIe1Uww4iGOhd0s7kmIaNN01Fm2GxxpGz /r/4N68nN7zBA5KMzABamXR/enh2e2gHtjQh8qnKeJW0iTxcwmdBEj/isKibNCXfuF9l DesJL3NEja4rGuBlVei1eWwQkCxnWxvhnXCbtrMX46iS5/PfNQcsIfC6WPt8eR8g4dVg qzwuHwDWhaZuhRb6wn3baZ+18ziHIXzoeezLEGb74lalgzvCJT57M17qbSr2AhAHWsBB vsUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=A6kDunl//DlUMhzxywEO+v1JnwHwkeSiOMAek8jQnUQ=; b=r8xQ09P0jJJDbIAHAKt+6GZ0y0OGhIXM90GfwyoEkJyQy+cfMyZG2L5ax8q6YSIg47 ZrU/qydOAn8zssxgFvJv8uNPcHoUj0tfzjJokvpc9MkMbvWTUufvdEyGsJwJOwrir0GJ YLOpoAg6+WxJqFBbBHOSL3EIUXwFyB63aSqn1NcaE+9q7czTl5F4tnJ6UINgVYFeYX0H 5M0SS4vD+faCGZ4foyEIjkILUfl4oD9cUqNhDvR4p07V6m4rmewIzdumEY+tFla/78zj OP+H2LZa3kgdu2W4S6y9a07T1A74DMUwG9KrmR3gyOlkIrTVc87Je96cVjAyDeoftj9K H5zg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w11-20020a63b74b000000b0055338653beesi1810585pgt.271.2023.06.22.02.55.18; Thu, 22 Jun 2023 02:55:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232365AbjFVJbJ (ORCPT + 99 others); Thu, 22 Jun 2023 05:31:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232333AbjFVJ3t (ORCPT ); Thu, 22 Jun 2023 05:29:49 -0400 Received: from baptiste.telenet-ops.be (baptiste.telenet-ops.be [IPv6:2a02:1800:120:4::f00:13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F9264C3D for ; Thu, 22 Jun 2023 02:22:46 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed20:991a:a831:ea4b:6058]) by baptiste.telenet-ops.be with bizsmtp id C9Nj2A0011yfRTD019Njq6; Thu, 22 Jun 2023 11:22:43 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qCGWX-000BvR-BY; Thu, 22 Jun 2023 11:22:43 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qCGWY-003Vvq-Uo; Thu, 22 Jun 2023 11:22:42 +0200 From: Geert Uytterhoeven To: Laurent Pinchart , Kieran Bingham , David Airlie , Daniel Vetter , Thomas Zimmermann , Magnus Damm Cc: dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH 03/39] drm: renesas: shmobile: Fix overlay plane disable Date: Thu, 22 Jun 2023 11:21:15 +0200 Message-Id: <9feb39aaab796fc4b59c6c83c3d96757482f714d.1687423204.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Merely writing zero to the CHn Source Image Format Register is not sufficient to disable a plane, as the programmed register value is not propagated immediately to the current side. This can be seen when using the -P option of modetest: the extra plane is displayed correctly, but does not disappear after exit. Fix this by doing the full update dance using the Blend Control Register, like is done when enabling the plane. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c index 850986cee848226a..0e34573c3cb3d032 100644 --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c @@ -215,7 +215,10 @@ static int shmob_drm_plane_disable(struct drm_plane *plane, splane->format = NULL; + lcdc_write(sdev, LDBCR, LDBCR_UPC(splane->index)); lcdc_write(sdev, LDBnBSIFR(splane->index), 0); + lcdc_write(sdev, LDBCR, + LDBCR_UPF(splane->index) | LDBCR_UPD(splane->index)); return 0; } -- 2.34.1