Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 22 Jun 2023 10:26:18 +0100
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Lucas Tanure <tanure@linux.com>
CC:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Kevin Hilman <khilman@baylibre.com>, Nick <nick@khadas.com>,
        Artem <art@khadas.com>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-amlogic@lists.infradead.org>,
        <linux-arm-kernel@lists.infradead.org>,
        Conor Dooley <conor@kernel.org>
Subject: Re: [PATCH v4 2/3] dt-bindings: serial: amlogic,meson-uart: Add
 compatible string for T7
Message-ID: <20230622-unsent-willing-574906af5e1a@wendy>
References: <20230622084045.519203-1-tanure@linux.com>
 <20230622084045.519203-3-tanure@linux.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="ddIyo+hP71qlkpK4"
Content-Disposition: inline
In-Reply-To: <20230622084045.519203-3-tanure@linux.com>
Precedence: bulk

--ddIyo+hP71qlkpK4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey Lucas,

On Thu, Jun 22, 2023 at 09:40:44AM +0100, Lucas Tanure wrote:
> Amlogic T7 SoCs uses the same UART controller as S4 SoCs and G12A.
> There is no need for an extra compatible line in the driver, but
> add T7 compatible line for documentation.
>=20
> Co-developed-by: Conor Dooley <conor@kernel.org>

You can delete this, I don't need a Co-developed-by tag for review
feedback.

> Signed-off-by: Lucas Tanure <tanure@linux.com>
> ---
>  .../devicetree/bindings/serial/amlogic,meson-uart.yaml      | 6 ++++++
>  1 file changed, 6 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.=
yaml b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> index 01ec45b3b406..4ca4673169aa 100644
> --- a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> @@ -46,6 +46,12 @@ properties:
>            - amlogic,meson8b-uart
>            - amlogic,meson-gx-uart
>            - amlogic,meson-s4-uart
> +      - description: Everything-Else power domain UART controller on G12=
A compatible SoCs

s/Everything-Else/Always-on/
Otherwise,
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Perhaps it can be fixed on application, I don't know how the amlogic
maintainers operate.

Cheers,
Conor.

> +        items:
> +          - enum:
> +              - amlogic,meson-t7-uart
> +          - const: amlogic,meson-g12a-uart
> +          - const: amlogic,meson-ao-uart
>        - description: Everything-Else power domain UART controller on G12=
A SoCs
>          items:
>            - const: amlogic,meson-g12a-uart
> --=20
> 2.41.0
>=20

--ddIyo+hP71qlkpK4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZJQTugAKCRB4tDGHoIJi
0lalAQC26MkvYfk+N8oVCKB3gmbONVI77MG2hQKQm4gPBQBMpAEAmhCQCy5FYk2G
fefLgjHl2z94F9oOu9SJ+Zj8fkWhOgg=
=vwt5
-----END PGP SIGNATURE-----

--ddIyo+hP71qlkpK4--