Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp10712741rwd; Thu, 22 Jun 2023 03:58:21 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6a2FJ0XmvJpc+VCONQecPemruS0Wo9qWg6/dNy2cpzLYbAJONx/9eZFw1srH0DD2OE9jTG X-Received: by 2002:a05:6830:110e:b0:6b2:9005:1870 with SMTP id w14-20020a056830110e00b006b290051870mr15652285otq.36.1687431501578; Thu, 22 Jun 2023 03:58:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687431501; cv=none; d=google.com; s=arc-20160816; b=FmzlqgpoZL9QGJeBmXSk06lpcmOtxH2SswFtDhLbCvGgCXC2vj2tXeLIvUx4ip4Pn/ F9+NXgoSmRi/q5UZNPjbv3a4iMFsxgveSokxZFgzCwB0BN47pi8RsLGlAdiyLTCcxnjR KUcT2ou0orl5nCo6OoarNnk4s3f0SxPYJh/Vc6r6+JNNjJ4/E3lBTMWxWUq0ZWWjx31b E0VXDKHLeFhxC5whbTBSN5gPnTy4s6js9+fQP6qegYORO54QtrL5YsRMt2s4ztGUWf1n S/pCHyHuzLnoyAbl1XcWN1p3osfeCsiQ88LSQncPnUryzzNTDHa7Nzd2t+Q9RGkYrPyr JYEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=vFxpvmcRYUWaWDIVQkGRSO4d07SCJOW4rGKCWk7rjHU=; b=m4uKDTT0OW/kUeyFwR5353QuFx2Dx3K/TNx6JyQUe6KwLGoutxMkSau3xjObN1Khxe 2xEtIdXlJaUilXKKJVip2J/QDvo8XslHdIBZpz9YivzF9I4dfj78y0kn82TGRWY4R5TR c8r5LKdjPAh7YqRno0fW8wowN/t+lhXmVjLpwXrp4veUBiFad1I56JunRPOIy3BzVcP9 zEP5hv35hRJbq/oHS/JguwchVLnh5wokwScMhKYNiu2AuNo59MWOkMviJVYi3ZeOEr5v 1P1QWjT0pYvz/T5flUDx7MH8ln4qbBHswTqUxJIDW43NvSrC6mi7sI54zeD9uOEKZ5AU aHkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rxLossX0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s18-20020a632c12000000b0054fdcafcc67si6047597pgs.604.2023.06.22.03.58.10; Thu, 22 Jun 2023 03:58:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rxLossX0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230193AbjFVKMY (ORCPT + 99 others); Thu, 22 Jun 2023 06:12:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230293AbjFVKMW (ORCPT ); Thu, 22 Jun 2023 06:12:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E850810F0 for ; Thu, 22 Jun 2023 03:12:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 68A83617C0 for ; Thu, 22 Jun 2023 10:12:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A930C433C8; Thu, 22 Jun 2023 10:12:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687428730; bh=LHQoMIKlPCUVdYDVCU+rYUKAonEIdfte0Fij6zTMRmM=; h=From:To:Cc:Subject:Date:From; b=rxLossX0EbeSaaBeVLTFvPuG7sSp18ayt72v2KAtT/YGRyU4hKHuUo6kbsVZ8B9K4 ucwp80MO1u8fUoMOms09Kw8YM3Nd0JMp2MkepNIsN2dckdiiFXY+KJjR+UBES6ExcD zr1njea+km9wev3tF+JjGyjZ12NRw+t9oSKnxJroYrYwaVSE2/hhwJmQiZdRYfBF5b sAORaC1pCfMDuQ2USst8jnSEKu6PkL7ftZRwhfKI/GItuE08mmorW9pSv9mbHtXHFq i+OViyXgiGJjfjQM5sFEUec5ShO+P4IFp9esgUqLT3Avs3dv/aWLkokJXZd+3pMtkW vWHCB7ORroxQw== From: Arnd Bergmann To: Liam Girdwood , Mark Brown Cc: Arnd Bergmann , Jaroslav Kysela , Takashi Iwai , Krzysztof Kozlowski , Richard Fitzgerald , Shenghao Ding <13916275206@139.com>, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH] ASoC: tas2781: fix Kconfig dependencies Date: Thu, 22 Jun 2023 12:11:23 +0200 Message-Id: <20230622101205.3180938-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann The new driver has two modules that both get enabled for build testing when all codecs are selected. The comlib part has an i2c dependency, so this remains disabled on builds without i2c, but then the other one fails to link: ERROR: modpost: "tasdevice_dev_bulk_write" [sound/soc/codecs/snd-soc-tas2781-fmwlib.ko] undefined! ERROR: modpost: "tasdevice_dev_update_bits" [sound/soc/codecs/snd-soc-tas2781-fmwlib.ko] undefined! ERROR: modpost: "tasdevice_dev_bulk_read" [sound/soc/codecs/snd-soc-tas2781-fmwlib.ko] undefined! ERROR: modpost: "tasdevice_dev_read" [sound/soc/codecs/snd-soc-tas2781-fmwlib.ko] undefined! ERROR: modpost: "tasdevice_dev_write" [sound/soc/codecs/snd-soc-tas2781-fmwlib.ko] undefined! There are many ways to address this, adding an explicit dependency seems to be the clearest method that keeps the structure of the driver otherwise unchanged. Fixes: ef3bcde75d06d ("ASoC: tas2781: Add tas2781 driver") Signed-off-by: Arnd Bergmann --- sound/soc/codecs/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index f481f02a35710..2a62dbd5339e4 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -1741,6 +1741,7 @@ config SND_SOC_TAS2781_COMLIB tristate config SND_SOC_TAS2781_FMWLIB + depends on SND_SOC_TAS2781_COMLIB tristate default n -- 2.39.2