Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp10846628rwd; Thu, 22 Jun 2023 05:47:23 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4bZAS17jRIXXDhR91QplynbZdTvzJQhXillHJ7Bp4NDAFfLKNdQE8fSuzLXlDD1NrNqKUF X-Received: by 2002:a05:6830:16d4:b0:6af:a045:214a with SMTP id l20-20020a05683016d400b006afa045214amr12683410otr.38.1687438043152; Thu, 22 Jun 2023 05:47:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687438043; cv=none; d=google.com; s=arc-20160816; b=gMxc+0WAbCN1I/AbpIF8wCmqQN2XZVNp9DyIrFS7DVO7qC8pcnCqI997JTja8/T1QT czaA27Uh0H+zVnEsmVJUPK3MTNrEK9wXsRJSE3KkQHNgOptnEelAF1a933wKrN71LTKv XqXql4+kGX7F8RYTFNuduWRFqi29PkZtSF9aXt/BPXqY5i5JvEmS99/rxrTk0x+obrUL 8+YaL1K4NVXBtZdAfCNgsaRiOSRqWdXhguzXLhgp4Jp44xb4dWA1JSJPKCyujso/Ch1g 2eaGrB3hKi/zPkuVXS9CDQ7Xtqmc2G6CZ6oBluXESZ3+ObkmCz8u5hFmMec6yVzW0AbB 5/lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=ItrbNwagQiNZn/pILAkHjQwxtuNZrABZ6sA9bDjp5jA=; b=MOYYrTINlkm/he0BWUueyn1J7aGRRXXOVldvWdmti/lpTbEAqFVKmOs/mhNLSFrnDd DnauTBAFdMKyMS/7ifNDTiyADCo6K9utTewdA4XcNf7s7kFqECIQAAanr3NFhyvp9DAf v1aPAo1MJwETi6RjRwEoyDSWRF9HtahK4kMKO/kxCNb9PK1mSzHgeV3ILKrKRc/mKHrF 7O+kY8V15Ro8LIZuSLaUYU8FQdEd3r2pfTA7mjIRyZZdbxCRILOyDSMBQt8Jc40JkKfO nMCrlG9OlhHb+iXgaIEd5xzhlzHD1qpyMEN2BI2fquQnyj3V7cbGYeODO1uIXRko9HeP hcyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Rf4fiH6j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a63-20020a639042000000b00537c6c285a0si1434912pge.167.2023.06.22.05.47.10; Thu, 22 Jun 2023 05:47:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Rf4fiH6j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231238AbjFVMbs (ORCPT + 99 others); Thu, 22 Jun 2023 08:31:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229915AbjFVMbr (ORCPT ); Thu, 22 Jun 2023 08:31:47 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C76CAB4 for ; Thu, 22 Jun 2023 05:31:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687437106; x=1718973106; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=VJAOY2tOh8YJLH4ChJtkKP7Ffaf6ITsW6/7BsgVWH2c=; b=Rf4fiH6j0HfbAa5sAEO+WDP+qpYYzoVC7tL2kmt2/j6+hzqRaUxJQkWT AAqvip60Dnz8TPfdJb2xW+/Zpy0NH9KJQrnXeA0VJq+cKRtRTc/9iM1tL u4/hSkPcXedYh+1HrV6rRGCw6WP046br6QMFaLnkAXdL9CyEjeBfq6DIE 4pwlwFpcf1Dfy/+0uEn9eXx12ASyxc9LQ3muf5AoWYSZzsQ4xuOYobovJ JbYapm5bz3lY9uXjO/I69RRKr7enCgYq76zQTmxDbtBKXrdCVw3zMeFwZ AOw7zeQE3xZiEI8PvLu+Ll1YaMF/6MJx+ALhbXbzSH7HbX42wxrgLA+q7 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="340810619" X-IronPort-AV: E=Sophos;i="6.00,263,1681196400"; d="scan'208";a="340810619" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2023 05:31:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="1045145887" X-IronPort-AV: E=Sophos;i="6.00,263,1681196400"; d="scan'208";a="1045145887" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga005.fm.intel.com with ESMTP; 22 Jun 2023 05:31:45 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qCJTU-005lRA-0W; Thu, 22 Jun 2023 15:31:44 +0300 Date: Thu, 22 Jun 2023 15:31:43 +0300 From: Andy Shevchenko To: Lee Jones Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/1] mfd: ipaq-micro: Use %*ph for printing hexdump of a small buffer Message-ID: References: <20230612212007.3621-1-andriy.shevchenko@linux.intel.com> <20230621171040.GK10378@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230621171040.GK10378@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 21, 2023 at 06:10:40PM +0100, Lee Jones wrote: > On Tue, 13 Jun 2023, Andy Shevchenko wrote: > > > The kernel already has a helper to print a hexdump of a small > > buffer via pointer extension. Use that instead of open coded > > variant. > > That's not all you're doing is it? > > Nice try. 2 patches please. I'm not sure it's possible to split to two clean patches that don't overlap each other like by 70%. Can you elaborate a bit more on your vision on this? -- With Best Regards, Andy Shevchenko